mbedtls

Author	SHA1	Message	Date
Werner Lewis	25690a98f0	Rename oret to expected_ret Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-12-14 09:36:48 +00:00
Manuel Pégourié-Gonnard	48232ed2c1	Merge pull request #6743 from minosgalanakis/bignum/implement_modular_negation Bignum: Implement fixed width modular negation	2022-12-13 09:54:38 +01:00
Demi Marie Obenour	1362c5ab16	Test for both PKCS 7 bugs found by OSS-Fuzz Previously the same test was repeated twice. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com> Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>	2022-12-12 21:59:02 +01:00
Werner Lewis	91a2aabb86	Refactor mpi_core_sub tests to use arch_split Tests are refactored to generate separate cases for 32-bit and 64-bit limbs using arch_split. Duplicate arguments and branching in the test function is removed. Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-12-12 17:18:43 +00:00
Manuel Pégourié-Gonnard	a9ac61203b	Merge pull request #6666 from daverodgman/fast_unaligned Fast unaligned memory access macros	2022-12-12 12:18:17 +01:00
Minos Galanakis	9a60b2373b	bignum_mod_raw testsuite: Refactored `mpi_mod_raw_neg()`. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-12-12 11:13:56 +00:00
Minos Galanakis	6118a3e5aa	test_suite_bignumg_mod_raw: Added test for mpi_mod_raw_neg Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-12-12 11:13:56 +00:00
Valerio Setti	785116a5be	test: pake: modify opaque key verification before destruction Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-12-12 11:59:25 +01:00
Valerio Setti	31e99bb0c7	test: pake: fix: destroy key only in opaque case Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-12-09 14:35:10 +01:00
Valerio Setti	9d313dfeeb	test: pake: minor enhancement for opaque keys Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-12-09 11:38:59 +01:00
Dave Rodgman	c18d932705	Add generated files Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-12-09 09:44:10 +00:00
Manuel Pégourié-Gonnard	578664601e	Fix missing dependency declaration in test muladd() (restartable or not) is only available when at least one short weirstrass curve is enabled. Found by depends.py curves (now that restartable is part of full). Also, document that restartable only work for short weierstrass curves (actually unrelated, but this made me think of that). Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>	2022-12-09 10:09:33 +01:00
Manuel Pégourié-Gonnard	cc6e0a650f	Fix missing initialisation of PSA Crypto This fixes the two failures in test_suite_x509parse when both ECP_RESTARTABLE and USE_PSA_CRYPTO are enabled. The failure happened because the operation is dispatched to PSA when restart is disabled (max_ops == 0). Previously it was correct for this test function not to initialize PSA, because it depends on ECP_RESTARTABLE which used to conflict with USE_PSA_CRYPTO, but that's no longer the case. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>	2022-12-09 10:09:32 +01:00
Valerio Setti	2a3ffb4203	test: pake: add test for opaque password key Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-12-08 16:27:46 +01:00
Dave Rodgman	48223bc19e	Bump version to 3.3.0. No changes to .so versions. Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-12-08 14:43:19 +00:00
Tom Cosgrove	6129268fee	Bignum: Implement mbedtls_mpi_mod_raw_inv_prime() and tests Fixes #6023. Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-12-08 09:44:10 +00:00
Tom Cosgrove	a7f0d7b029	mbedtls_mpi_core_exp_mod() ouuput may alias input A Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-12-08 08:46:28 +00:00
Gilles Peskine	3e5d56e7d4	Remove duplicated test cases Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-12-07 22:57:54 +01:00
Valerio Setti	f11e05a413	test: psa: minor improvements to test Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-12-07 16:02:45 +01:00
Dave Rodgman	90af1a10ab	Merge pull request #6734 from daverodgman/fix_test_dep_spelling Fix spelling of test dependency	2022-12-07 09:06:29 +00:00
Janos Follath	d45924d862	Merge pull request #6733 from tom-cosgrove-arm/issue-6293-mod_exp-memory Have mbedtls_mpi_core_exp_mod() take a temporary instead of allocating memory	2022-12-07 08:32:31 +00:00
Gilles Peskine	8781dd0e61	Fix overly large allocations of MPIs The second argument of ASSERT_ALLOC is a number of array elements, not a number of bytes. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-12-06 23:05:06 +01:00
Gilles Peskine	de09ddd64e	Move tests of random-in-range functions to their own suite The random-in-nrange test code has auxiliary functions that are common to all the interfaces (core, mod_raw (upcoming), mod (upcoming), legacy), and does some differential testing to check that all the layers consume the RNG in the saame way. Test them all in the same test suite. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-12-06 22:50:11 +01:00
Dave Rodgman	1fe45295d7	Merge pull request #6685 from gilles-peskine-arm/valgrind-cf-skip-tests Rationalize Valgrind tests	2022-12-06 18:39:32 +00:00
Dave Rodgman	92011eef34	Merge pull request #6717 from tom-cosgrove-arm/fix-typos-2212 Fix typos prior to release	2022-12-06 15:00:34 +00:00
Dave Rodgman	614688711d	Fix spelling of test dependency Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-12-06 14:44:08 +00:00
Tom Cosgrove	0a0ddedfb7	Have mbedtls_mpi_core_exp_mod() take a temporary instead of allocating memory Last PR needed for #6293 Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-12-06 14:37:18 +00:00
Werner Lewis	3f2999ad25	Rename test_suite_bignum_mod.data for consistency Use the same naming convention as bignum and bignum_core now that test data is generated. Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-12-06 11:55:32 +00:00
Werner Lewis	e1b6b7c0ac	Implement mbedtls_mpi_mod_add() Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-12-06 11:55:32 +00:00
Valerio Setti	ba22c9c1ff	test: pake: remove useless check in ssl_ecjpake_set_password() Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-12-06 11:42:33 +01:00
Valerio Setti	2e1e43fb82	test: pake: fix error in ssl_ecjpake_set_password() Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-12-06 11:41:57 +01:00
Tom Cosgrove	f51f972d67	Apply review comments Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-12-05 15:47:40 +00:00
Tom Cosgrove	1797b05602	Fix typos prior to release Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-12-04 17:19:59 +00:00
Valerio Setti	e7518ba28e	test: pake: reshaping the ssl_ecjpake_set_password() Removed the "error injection" strategy. Now the functions checks for all the errors in a row. Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-12-02 12:09:43 +01:00
Gilles Peskine	da9746e8ce	Test NOT_ACCEPTABLE cases for MPI get-random Test some cases where mbedtls_mpi_core_random() or mbedtls_mpi_random() should return MBEDTLS_ERR_MPI_NOT_ACCEPTABLE. These test cases use a very small range that makes the NOT_ACCEPTABLE case likely. The test code uses a deterministic RNG whose implementation is in the test framework, so we know that the tests will pass reproducibly unless the implementation the test framework changes. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-12-01 23:46:31 +01:00
Gilles Peskine	e3a1b81cb9	Switch mpi_random_many test function to testing core The test function mpi_random_many() is the main function for testing the get-random-in-range function. It validates that the random generator's output is within the desired range, and performs some basic statistical checks including checking that small ranges are covered exhaustively. Switch this function from testing mbedtls_mpi_random() to testing mbedtls_mpi_core_random(). This does not reduce the test coverage of mbedtls_mpi_random() because the same properties are now validated indirectly via mpi_random_values() which checks that mbedtls_mpi_random() and mbedtls_mpi_core_random() produce identical values for identical inputs. As of this commit, mpi_random_many() still uses some legacy mpi functions internally because the corresponding functions don't exist yet in core. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-12-01 23:46:31 +01:00
Gilles Peskine	34e8a2c287	Test mbedtls_mpi_random differentially from mbedtls_mpi_core_random For good cases, test that mbedtls_mpi_random() produces the same output as mbedtls_mpi_core_random(). Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-12-01 23:46:31 +01:00
Gilles Peskine	6f949ea67b	New constant-flow function mbedtls_mpi_core_uint_le_mpi Compare a single-limb MPI with a multi-limb MPI. This is rather ad hoc, but will be useful for mbedtls_mpi_core_random. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-12-01 23:06:43 +01:00
Tom Cosgrove	62b20488f1	Implement mbedtls_mpi_mod_sub() Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-12-01 14:27:37 +00:00
Valerio Setti	4452e98ec1	test: pake: add tests for set password functions Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-12-01 15:08:35 +01:00
Dave Rodgman	481a5e427b	Improve parsing of test data Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-12-01 13:31:20 +00:00
Dave Rodgman	7fc53dd83d	Suppress over-eager compiler warnings in tests Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-12-01 11:42:29 +00:00
Paul Elliott	266f79c136	Merge pull request #6426 from aditya-deshpande-arm/driver-wrapper-key-agreement Add driver dispatch layer for raw key agreement, along with test call for transparent drivers.	2022-12-01 11:40:52 +00:00
Dave Rodgman	9dc55ba932	Suppress over-eager compiler warnings in test code Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-12-01 10:49:57 +00:00
Dave Rodgman	63e6a88874	Suppress over-eager compiler warning in tests Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-12-01 10:01:08 +00:00
Dave Rodgman	fb5fedcd00	Add tests for alignment.h Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-12-01 09:40:03 +00:00
Gilles Peskine	edaa17b350	Merge pull request #6547 from yanesca/extract_mod_exp_from_prototype Bignum: Extract mod exp from prototype	2022-11-29 21:40:07 +01:00
Gilles Peskine	d1bc6da3d3	Fix the build with MBEDTLS_TEST_HOOKS && !MBEDTLS_USE_PSA_CRYPTO Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-29 21:14:19 +01:00
Aditya Deshpande	b6bc7524f9	Minor formatting fixes to address code review comments Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>	2022-11-29 16:53:29 +00:00
Gilles Peskine	3ffd6bce81	Create a separate test suite for constant-time functions This is the first step in arranging that functions from constant_time.c are tested in test_suite_constant_time.function. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-29 15:44:21 +01:00
Gilles Peskine	77e68c3176	Move constant-time HMAC testing to its own suite These are very CPU-intensive, so make it easy to skip them. And conversely, make it easy to run them without the growing body of SSL tests. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-29 15:42:36 +01:00
Manuel Pégourié-Gonnard	0b9b560770	Merge pull request #6601 from valeriosetti/issue6502 Avoid assumptions about implementation in EC J-PAKE tests	2022-11-29 11:21:23 +01:00
Manuel Pégourié-Gonnard	f9720cfa78	Merge pull request #6670 from gilles-peskine-arm/pkcs7-use-after-free-20221127 PKCS7: Fix some memory management errors	2022-11-29 11:17:27 +01:00
Gilles Peskine	a13f5eb7b8	Add missing dependency for the fuzzer-constructed test data Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-28 21:30:04 +01:00
Dave Rodgman	d98ac8b75e	Merge remote-tracking branch 'dave/fast_xor' into fast_unaligned	2022-11-28 15:06:25 +00:00
Aditya Deshpande	1ac41dec09	Add test function for opaque driver (simply returns PSA_ERROR_NOT_SUPPORTED), and address other review comments. Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>	2022-11-28 14:46:30 +00:00
Valerio Setti	a34d0308cc	test: psa_pake: fix dependency Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-28 11:46:36 +01:00
Gilles Peskine	4f01121f6e	Fix memory leak on error in pkcs7_get_signers_info_set mbedtls_x509_name allocates memory, which must be freed if there is a subsequent error. Credit to OSS-Fuzz (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=53811). Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-27 22:02:10 +01:00
Gilles Peskine	391005cb3b	Fix structures initialized too late in tests Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-27 21:55:29 +01:00
Gilles Peskine	2336555444	Improve test failure reporting Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-27 21:55:29 +01:00
Gilles Peskine	290f01b3f5	Fix dangling freed pointer on error in pkcs7_get_signers_info_set This fixes a use-after-free in PKCS#7 parsing when the signer data is malformed. Credit to OSS-Fuzz (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=53798). Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-27 21:55:29 +01:00
Janos Follath	e7190a2960	mpi_mod_io_neg: fix use of uninitialized value Uninitialized values are invalid for the tested functions and we shouldn't be testing that. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-26 18:46:54 +00:00
Janos Follath	0020df9cf9	mpi_mod_io: test with various buffer sizes Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-26 17:23:16 +00:00
Janos Follath	8dfc8c41b7	mbedtls_mpi_mod_write: prevent data corruption The function wasn't converting back data to internal representation when writing it out. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-26 15:39:02 +00:00
Janos Follath	d7bb35257b	mbedtls_mpi_mod_read/write: restrict pre-conditions Require equality for the number of limbs in the modulus and the residue. This makes these functions consistent with residue_setup(). Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-26 14:59:27 +00:00
Janos Follath	6ef582f2b8	Bignum Mod Tests: improve readabilty and style Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-26 14:19:02 +00:00
Janos Follath	339b439906	Bignum Mod: remove unused parameter in io_neg test The value was overwritten and the length wasn't used either. This latter could have lead to a buffer overflow as well. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-26 12:24:34 +00:00
Janos Follath	566c91db27	Bignum Mod: io_neg test pass data directly Pass buffer directly instead of constructing it in the function. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-26 12:24:34 +00:00
Minos Galanakis	96070a53a8	bignum_tests: Refactored `mpi_mod_io_neg()` This patch refactores the negative testing suite to utilised non-hardcoded input data. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-11-26 12:24:34 +00:00
Janos Follath	91f3abdfda	Bignum Mod: improve residue_setup test - Rename input variables to match their purpose. - Assert fields upon success Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-26 12:24:34 +00:00
Janos Follath	f55505d38b	Bignum Mod Raw: fix tests after rebase Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-25 17:58:40 +00:00
Janos Follath	799eaeefdb	Bignum Mod: move init before any goto Test macros have goto instructions to the end where everything is freed. We need to call init before that happens to make calling free functions safe. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-25 17:55:00 +00:00
Janos Follath	91295d2b8f	Bignum Mod: remove endianness from modulus The external representation before included more than just endianness (like reading in Mongtomery curve scalars or converting hashes to numbers in a standard compliant way). These are higher level concepts and are out of scope for Bignum and for the modulus structure. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-25 17:55:00 +00:00
Janos Follath	3e3fc91c33	Bignum Mod: pass endianness as a parameter The external representation before included more than just endianness (like reading in Mongtomery curve scalars or converting hashes to numbers in a standard compliant way). These are higher level concepts and are out of scope for Bignum and for the modulus structure. Passing endianness as a parameter is a step towards removing it from the modulus structure. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-25 17:55:00 +00:00
Janos Follath	d3eed33709	Bignum Mod Raw: pass endianness as a parameter The external representation before included more than just endianness (like reading in Mongtomery curve scalars or converting hashes to numbers in a standard compliant way). These are higher level concepts and are out of scope for Bignum and for the modulus structure. Passing endianness as a parameter is a step towards removing it from the modulus structure. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-25 17:55:00 +00:00
Janos Follath	50cd4b842b	Bignum Mod: Restrict residue setup In theory we could allow residues to have more allocated limbs than the modulus, but we might or might not need it in the end. Go for the simpler option for now and we can extend it later if we really need it. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-25 17:55:00 +00:00
Janos Follath	b62bad442e	Bidnum Mod: fix check in setup We want to make sure that the value has at least as many limbs allocated as the modulus as we need this to be able to do any operations in constant time. An invariant of the API is that the residue values are canonical, make sure that the residue is compared to the entire modulus. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-25 17:55:00 +00:00
Minos Galanakis	8b375451c5	bignum_mod: Refactored `mbedtls_mpi_mod_read/write()` This patch adjusts the I/O methods and the tests. Documentation has also been updated to be more clear. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-11-25 17:55:00 +00:00
Minos Galanakis	aed832ac16	bignum_mod: Adjusted input checking for `mbedtls_mpi_mod_residue_setup()` This patch adjusts the logic of the size checking of the method, and refactors the tests. Documentation has also been updated. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-11-25 17:55:00 +00:00
Minos Galanakis	a17ad48e2d	bignum_mod: Fixed an issue with input checking in `mpi_mod_residue_setup` This patch is inverting the input type checking logic in the method, in order to ensure that residue < modulus. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-11-25 17:55:00 +00:00
Minos Galanakis	8f24270630	test_suite_bignum_mod: Added tests for hight level IO This patch adds the following tests for the high levet IO api: * mpi_mod_io_neg * mpi_mod_io Manually generated test data has also been included. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-11-25 17:55:00 +00:00
Janos Follath	590ae5363d	Merge pull request #6656 from tom-cosgrove-arm/bignum_pr_6225-updated Bignum: add mod_raw_add	2022-11-25 17:53:31 +00:00
Dave Rodgman	5a1d00f03d	Merge remote-tracking branch 'origin/development' into fast_xor Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-11-25 17:10:25 +00:00
Dave Rodgman	bf9b23abf8	Merge pull request #6648 from gilles-peskine-arm/psa-ecb-null-0 Fix NULL+0 undefined behavior in PSA crypto ECB	2022-11-25 17:07:46 +00:00
Bence Szépkúti	6e85673e8d	Merge pull request #3431 from naynajain/development-pkcs7 PKCS7 Parser - RFC 2315	2022-11-25 15:55:46 +01:00
Tom Cosgrove	ddad40b1de	Free the modulus before the data in it in mod_raw_add tests Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-11-25 14:18:52 +00:00
Janos Follath	505a228b7b	Merge pull request #6606 from gabor-mezei-arm/6222_bignum_low_level_subtraction Bignum: Add low level subtraction	2022-11-25 13:27:23 +00:00
Dave Rodgman	f1419dbbe8	Merge pull request #6381 from tom-cosgrove-arm/pr2164 mbedtls: fix possible false success in mbedtls_cipher_check_tag()	2022-11-25 10:55:10 +00:00
Bence Szépkúti	ae79fb2c2e	Merge branch 'development' into pr3431	2022-11-25 03:12:43 +01:00
Tom Cosgrove	50fc127a4e	Change order of test arguments for bignum_mod_raw to simplify Python script Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-11-24 21:29:23 +00:00
Dave Rodgman	7a910a8be0	Minor formatting tweaks Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-11-24 21:17:40 +00:00
Tom Cosgrove	54d87bf5c2	Take limb count from the modulus in mod_raw_add tests Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-11-24 16:22:38 +00:00
Werner Lewis	f907576245	Pass correct arguments in test Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-11-24 16:18:06 +00:00
Werner Lewis	baa34b6248	Add test function for mpi_mod_raw_add Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-11-24 16:18:06 +00:00
Gabor Mezei	cbcbf4e434	Remove hand-written tests got raw_mod_sub The generated tests cover all off the hand-written tests. Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-11-24 11:48:59 +01:00
Dave Rodgman	3172e4e1c9	Fix typo in test_suite_common Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-11-23 19:38:13 +00:00
Dave Rodgman	15531bc6d2	Test for all alignment combinations Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-11-23 16:51:12 +00:00
Gabor Mezei	b3b3466657	Test subtraction if the parameters are aliased to each other Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-11-23 14:44:14 +01:00
Gabor Mezei	4d3f3c5430	Fix the checking of the used limbs Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-11-23 14:44:14 +01:00
Gabor Mezei	68a45e0aaf	Fix potential not initialized warning Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-11-23 14:44:14 +01:00
Gabor Mezei	cefe03a10c	Add tests for low level subtraction with modulus Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-11-23 14:44:13 +01:00
Gilles Peskine	42649d9270	Fix NULL+0 undefined behavior in ECB encryption and decryption psa_cipher_encrypt() and psa_cipher_decrypt() sometimes add a zero offset to a null pointer when the cipher does not use an IV. This is undefined behavior, although it works as naively expected on most platforms. This can cause a crash with modern Clang+ASan (depending on compiler optimizations). Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-23 14:16:52 +01:00
Janos Follath	cf0e86c9b8	mpi_core_exp_mod: remove manual tests The previous commit added generated tests, we don't need the manually added tests anymore. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-22 21:40:24 +00:00
Janos Follath	05867cb036	mpi_core_exp_mod: add generated tests Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-22 21:37:10 +00:00
Janos Follath	0f0d1e88a2	mpi_core_exp_mod: add unit tests The test cases aim to mirror the legacy function, but needed the some cases to be removed because: - Null representation is not valid in core - There are no negative numbers in core - Bignum core doesn't do parameter checking and there are no promises for even N The _size variant of the test has been removed as bignum core doesn't do parameter checking and there is no promises for inputs that are larger than MBEDTLS_MPI_MAX_SIZE. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-22 21:22:53 +00:00
Janos Follath	59cbd1be27	Make mbedtls_mpi_core_ct_uint_table_lookup static Now that we have a function that calls mbedtls_mpi_core_ct_uint_table_lookup(), the compiler won't complain if we make it static. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-22 21:22:53 +00:00
Valerio Setti	728b142f40	test: psa_pake: port changes from `cd356c3` Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 19:47:24 +01:00
Dave Rodgman	8c18baf8c1	Add test for unaligned buffers Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-11-22 18:15:55 +00:00
Aditya Deshpande	5e3c70e3be	Merge branch 'development' into driver-wrapper-key-agreement	2022-11-22 17:58:52 +00:00
Aditya Deshpande	8cc1470c18	Merge branch 'development' into driver-wrapper-key-agreement	2022-11-22 17:55:53 +00:00
Valerio Setti	e0d41de822	test: psa_pake: add missing initialization in ecjpake_setup() Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 18:52:17 +01:00
Valerio Setti	db4736a4ca	test: psa_pake: remove empty password test Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 18:52:17 +01:00
Valerio Setti	b9ef1c2f03	test: psa_pake: fix error inject macro in ecjpake_do_round() Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 18:52:17 +01:00
Valerio Setti	b697745d14	test: psa_pake: fix erroneously duplicated tests Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 18:52:17 +01:00
Valerio Setti	40323c5d51	test: psa_pake: improved ecjpake_do_round() test function Now it's possible to inject an error in every single step of the key exchange process. Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 18:52:17 +01:00
Valerio Setti	ac3ba95ee4	test: psa_pake: fix data file for ecjpake_setup() Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 18:52:17 +01:00
Valerio Setti	e65a41f278	test: psa_pake: fixes in ecjpake_setup() Both changes concern the ERR_INJECT_UNINITIALIZED_ACCESS case: - removed unnecessary psa_pake_abort() - added psa_pake_get_implicit_key() Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 18:52:17 +01:00
Valerio Setti	e5d7864aa0	test: psa_pake: improved description of macros used in ecjpake_setup() Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 18:52:17 +01:00
Valerio Setti	7bb65ad22f	test: psa_crypto_pake: enhanced ecjpake_setup() - external errors are now checked in the specified point. If the same error happens in another line, then this is not valid and the test fails - fixed some inconsistency in which injected error codes were not taken from the data file. Now all the expected error code are read from the data file - added a couple of defines to shrink the code Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 18:52:17 +01:00
Valerio Setti	024b028ce1	test: split psa_pake function/data from the generic test_suite_psa_crypto Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 18:52:17 +01:00
Valerio Setti	1070aed778	test_suite_psa_crypto: do not re-use PAKE's contexts in case of errors As for ecjpake_setup(), now the test function can handle: - "external" errors, through parameters set by the data file - "internal" ones, through enums which inject ad-hoc failures Similarly also ecjpake_rounds() can handle both type of errors, but right now there's no erroneous case in the associated ".data" file. In both cases, after an error the current test is terminated. Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-22 18:45:03 +01:00
Dave Rodgman	4413b6690f	Add tests for mbedtls_xor Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-11-22 17:32:43 +00:00
Tom Cosgrove	d66d5b2fef	Add unit tests for mbedtls_mpi_core_sub_int(), MPI A - scalar b Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-11-22 15:07:31 +00:00
Bence Szépkúti	a17d038ee1	Merge branch 'development' into pr3431	2022-11-22 15:54:52 +01:00
Gilles Peskine	4f19d86e3f	Merge pull request #6608 from mprse/ecjpake_password_fix Make a copy of the password key in operation object while setting j-pake password	2022-11-22 14:52:12 +01:00
Aditya Deshpande	39e08d4094	Add tests for the key agreement driver wrapper to test_suite_psa_crypto_driver_wrappers Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>	2022-11-21 19:39:35 +00:00
Gilles Peskine	339406daf9	Merge pull request #6609 from gilles-peskine-arm/mpi_sint-min-ub Fix undefined behavior in bignum: NULL+0 and -most-negative-sint	2022-11-21 19:51:58 +01:00
Przemek Stekiel	f82effa982	Optimize pake test code Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>	2022-11-21 15:10:32 +01:00
Przemek Stekiel	cd356c3cdb	Add ec-jpake test to verify if key can be destroyed after set_password_key Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>	2022-11-21 12:25:21 +01:00
Tom Cosgrove	8c0eb9744c	Must call mbedtls_mpi_mod_modulus_init() before anything else in tests Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-11-17 08:48:12 +00:00
Przemek Stekiel	7c7954842b	Adapt ec-jpake_setup test Now when operation holds pointer to dynamically allocated buffer for password key we can't do copy of the operation object in test instead we need to re-initialize operation object after error. Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>	2022-11-16 16:27:55 +01:00
Gilles Peskine	af601f9751	Fix undefined behavior with the most negative mbedtls_mpi_sint When x is the most negative value of a two's complement type, `(unsigned_type)(-x)` has undefined behavior, whereas `-(unsigned_type)x` has well-defined behavior and does what was intended. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-15 23:02:14 +01:00
Gilles Peskine	ca6e8aac58	Support negative zero as MPI test input The bignum module does not officially support "negative zero" (an mbedtls_mpi object with s=-1 and all limbs zero). However, we have a history of bugs where a function that should produce an official zero (with s=1), produces a negative zero in some circumstances. So it's good to check that the bignum functions are robust when passed a negative zero as input. And for that, we need a way to construct a negative zero from test case arguments. There are checks that functions don't produce negative zeros as output in the test suite. Skip those checks if there's a negative zero input: we don't want functions to _create_ negative zeros, but we don't mind if they _propagate_ negative zeros. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-15 20:47:07 +01:00
Gilles Peskine	2909f53740	Merge pull request #6604 from tom-cosgrove-arm/call-mbedtls_mpi_mod_modulus_init-first-cid-381893-381894 Bignum: Must call mbedtls_mpi_mod_modulus_init() before anything else in tests	2022-11-15 12:33:13 +01:00
Manuel Pégourié-Gonnard	edce0b42fb	Merge pull request #6454 from valeriosetti/issue4577 Adding unit test for mbedtls_x509write_csr_set_extension()	2022-11-15 09:39:07 +01:00
Tom Cosgrove	f90111b2b5	Must call mbedtls_mpi_mod_modulus_init() before anything else in tests Fixes (new) Coverity issues 381893 and 381894 Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-11-15 06:15:15 +00:00
Valerio Setti	48e8fc737a	Adding unit test for mbedtls_x509write_csr_set_extension() The already existing "x509_csr_check()" function is extended in order to support/test also CSR's extensions. The test is performed by adding an extended key usage. Signed-off-by: Valerio Setti <vsetti@baylibre.com>	2022-11-14 13:32:07 +01:00
Janos Follath	1b9cb62702	Merge pull request #6573 from tom-cosgrove-arm/convert-mpi_mod_int-test-cases-to-hex Enable mpi_mod_int test case to take full-range MPI integers	2022-11-14 12:04:09 +00:00
Gilles Peskine	07510f5ba3	Allow comments in prototypes of unit test functions Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-11 16:37:16 +01:00
Minos Galanakis	47691fb756	bignum_tests: Refactored mpi_mod_raw_to/fromt_mont_rep This patch migrates the tests to use the `mbedtls_test_read_mpi_core()`. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-11-11 10:55:08 +00:00
Minos Galanakis	df070d660d	bignum_tests: Added test for `mbedtls_mpi_mod_raw_from_mont_rep()` Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-11-11 10:55:08 +00:00
Minos Galanakis	631b491cbf	bignum_tests: Added test for `mbedtls_mpi_mod_raw_to_mont_rep()` Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-11-11 10:55:08 +00:00
Dave Rodgman	ebd0caffdf	Fix test memory allocation Fix error in memory allocation in test code, which was triggering an error in test_memory_buffer_allocator. Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-11-10 15:33:54 +00:00
Tom Cosgrove	163d8952b3	Add additional (would fail) test cases for mpi_mod_int with 0 remainder Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-11-10 12:17:36 +00:00
Tom Cosgrove	9feb19f98d	Use mbedtls_mpi_sint not mbedtls_mpi_uint in mpi_mod_int test Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-11-10 12:05:55 +00:00
Gilles Peskine	b4eb444a5c	Merge pull request #6535 from davidhorstmann-arm/change-test-templating-syntax Change test templating syntax to be valid C	2022-11-10 12:05:55 +01:00
Dave Rodgman	f58172fe43	Merge remote-tracking branch 'origin/development' into pr3431	2022-11-10 09:54:49 +00:00
Gilles Peskine	ed4b34aa7c	Merge pull request #6570 from gilles-peskine-arm/bignum-mbedtls_test_read_mpi_core-nonempty Forbid empty mpi_core in test data	2022-11-09 19:02:24 +01:00
Tom Cosgrove	91e35e3c32	Enable mpi_mod_int test case to take full-range MPI integers Also add commented-out test cases that currently fail Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-11-09 11:45:29 +00:00
Manuel Pégourié-Gonnard	b9581824f7	Merge pull request #6561 from AndrzejKurek/ecjpake-error-injection Improve error injection in EC J-PAKE tests	2022-11-09 11:48:36 +01:00
Gilles Peskine	95b5addcd6	Don't test mbedtls_mpi_core_lt_ct with 0 limbs A core MPI must have at least 1 limb. We can no longer test with 0 limbs, and we don't need to anyway, so don't try. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-09 11:18:38 +01:00
Gilles Peskine	4a480ac5a1	Merge pull request #6265 from Kabbah/x509-info-hwmodulename-hex `x509_info_subject_alt_name`: Render HardwareModuleName as hex	2022-11-08 17:11:07 +01:00
Aditya Deshpande	c4646c08cd	Merge branch 'development' into driver-wrapper-key-agreement	2022-11-08 14:25:20 +00:00
Andrzej Kurek	c018204019	Improve error injection in EC J-PAKE tests Instead of corrupting the public key part of the message, corrupt the proof part. A proof is conceptually similar to a signature, and changing anything in it should make it invalid with a high probability. Also, instead of shifting data, perform a bitflip. Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-11-08 08:12:56 -05:00
Gilles Peskine	42d75f2daf	Merge pull request #6013 from gstrauss/asn1-type-free Shared code to free x509 structs like mbedtls_x509_named_data	2022-11-08 12:20:20 +01:00
Gilles Peskine	433f1f1809	Merge pull request #6456 from gabor-mezei-arm/6237_test_update_cond_assign_swap Update tests to use conditional assign and swap	2022-11-08 12:15:07 +01:00
Glenn Strauss	2a64299648	Update tests/suites/test_suite_asn1parse.function Co-authored-by: Andrzej Kurek <andrzej.kurek@arm.com> Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com>	2022-11-07 20:09:38 -05:00
Glenn Strauss	aa36c2a6f6	Update tests/suites/test_suite_asn1parse.function Co-authored-by: Andrzej Kurek <andrzej.kurek@arm.com> Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com>	2022-11-07 20:08:54 -05:00
Glenn Strauss	82ba274c01	Deprecate mbedtls_asn1_free_named_data() Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com>	2022-11-07 15:42:44 -05:00
Aditya Deshpande	d1b72a7b83	Merge branch 'development' into driver-wrapper-key-agreement	2022-11-07 17:36:23 +00:00
Aditya Deshpande	ec6bb5879a	Disabled tests in test_suite_ssl that won't work without builtin ECDH Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>	2022-11-07 17:11:48 +00:00
Gilles Peskine	faefe62013	Merge pull request #6390 from mpg/fix-ecjpake-psa-format Fix ecjpake PSA format	2022-11-07 17:35:44 +01:00
Gabor Mezei	a8cf998bc9	Let the allocated memory visible for the memory sanitizer Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-11-07 15:14:49 +01:00
Gabor Mezei	7ba7b3aded	Update tests to use mbedtls_test_read_mpi_core In conditional assign and swap tests use the mbedtls_test_read_mpi_core function for reading MPIs. Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-11-07 15:14:49 +01:00
David Horstmann	b85838f2f4	Change test templating syntax to be valid C For the benefit of auto-formatting tools, move from the '$placeholder' templating syntax to a new syntax of the form: __MBEDTLS_TEST_TEMPLATE__PLACEHOLDER This change allows the test code template to be almost entirely valid C. Signed-off-by: David Horstmann <david.horstmann@arm.com>	2022-11-04 19:53:39 +00:00
Dave Rodgman	2364aaefa6	Update tests/suites/test_suite_pkcs7.function Address test dependency issue Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-11-04 11:33:04 +00:00
Nick Child	fc234b7b52	test/pkcs7: Add Windows CRLF EOF to data files Windows tests are failing pkcs7 verification due to differnt line endings. Therefore, add make instuctions for building the data files with Windows EOF instead. As a result, regenerate other data files so that verification works. Add these CRLF EOF files to the exception in check_files to ignore the line endings. Signed-off-by: Nick Child <nick.child@ibm.com>	2022-11-03 09:24:20 -05:00
Janos Follath	c1a81bc998	Remove trailing new lines Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-02 17:33:11 +00:00
Janos Follath	6642cafae3	Fix merge separator position Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-02 17:28:39 +00:00
Janos Follath	be13652296	Use comments for merge separators in .data files We do have a comment syntax for .data files, there is no need for dummy test cases. Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-02 17:28:37 +00:00
Janos Follath	5933f691a2	Add merge slots to Bignum files Legacy Bignum is excluded as it doesn't get regular extensions like new ones. Each slot uses comments of their respective filetype. Since .data files don't have a syntax for comments, dummy test cases are used. (These test cases will never be executed and no noise will be added to tests.) Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-02 17:27:25 +00:00
Gilles Peskine	dd54324765	Increase iterations for some statistical tests I ran into a sequence where the assertion `stats[8] > 0` failed for the range 1..272 with 100 iterations. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-02 16:00:01 +01:00
Gilles Peskine	5980f2bd36	Implement mbedtls_mpi_core_fill_random Turn mpi_fill_random_internal() into mbedtls_mpi_core_fill_random(). It had basically the right code except for how X is passed to the function. Write unit tests. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-11-02 15:59:36 +01:00
Janos Follath	f1ed5815ba	Merge pull request #6512 from yanesca/extract_uint_table_lookup_core Implement mbedtls_mpi_core_ct_uint_table_lookup()	2022-11-02 13:58:19 +00:00
Janos Follath	28f85e6683	Fix const time in mpi_core_ct_uint_table_lookup test Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-11-02 10:20:35 +00:00
Janos Follath	ef67d38bc0	Fix memory leak in mpi_core_ct_uint_table_lookup test Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-10-31 15:11:49 +00:00
Dave Rodgman	55fd0b9fc1	Merge pull request #6121 from daverodgman/pr277 cert_write - add a way to set extended key usages - rebase	2022-10-31 13:27:49 +00:00
Janos Follath	133f4e427b	Test mpi_core_table_lookup for constant timeness Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-10-31 11:32:55 +00:00
Janos Follath	032924f297	Add mbedtls_mpi_core_ct_uint_table_lookup tests Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-10-31 11:32:55 +00:00
Janos Follath	2dc2757cca	Merge pull request #6457 from minosgalanakis/minos/6017_update_modulus_lifecycle Bignum: Updated the modulus lifecyle	2022-10-31 11:28:37 +00:00
Dave Rodgman	1a22bef116	Merge pull request #6190 from daverodgman/invalid-ecdsa-pubkey Improve ECDSA verify validation	2022-10-31 09:37:26 +00:00
Glenn Strauss	a4b4041219	Shared code to free x509 structs Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com>	2022-10-28 12:51:35 -04:00
Dave Rodgman	f00466e2e0	Build fix - remove line of dead code Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-10-28 09:22:28 +01:00
Minos Galanakis	0c61a749b7	test_suite_bignum_mod_raw: Removed parameter for `mbedtls_mpi_mod_modulus_setup()` This patch updates the tests `mpi_mod_raw_cond_swap()` & `mpi_mod_raw_cond_assign()` to use a non-zero modulus when invoking `mbedtls_mpi_mod_modulus_setup()` Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-10-28 00:11:19 +01:00
Dave Rodgman	683850b416	Update tests/suites/test_suite_ecdsa.function Co-authored-by: Gilles Peskine <gilles.peskine@arm.com> Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>	2022-10-27 20:24:46 +01:00
Minos Galanakis	4d4c98b1b9	bignum_mod: `mbedtls_mpi_mod_modulus_setup()` refactoring. This patch addresses more review comments, and fixes a circular depedency in the `mbedtls_mpi_mod_modulus_setup()`. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-10-27 17:47:26 +01:00
Minos Galanakis	771c47055f	bignum_mod: Style changes This patch addresses review comments with regards to style of `mbedtls_mpi_mod_modulus_setup/free()`. It also removes a test check which was triggering a use-after-free. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-10-27 12:36:24 +01:00
Minos Galanakis	dd365a526f	test_suite_bignum: Updated `mpi_mod_setup()` test This patch updates the `mpi_mod_setup()` test suite to check for incosistencies in the montgomery constant data's lifecycle. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-10-27 11:43:54 +01:00
Gilles Peskine	9603daddaa	Merge pull request #6230 from tom-cosgrove-arm/issue-6223-core-add Bignum: extract core_add from the prototype	2022-10-27 11:25:27 +02:00
Ronald Cron	c9176a03a7	Merge pull request #6410 from gilles-peskine-arm/psa-pkparse-pkwrite-3.2 PSA with RSA requires PK_WRITE and PK_PARSE	2022-10-26 14:57:36 +02:00
Gilles Peskine	d4d080b41b	Merge pull request #6407 from minosgalanakis/minos/6017_add_montgomery_constant_squared Bignum: Added pre-calculation of Montgomery constants	2022-10-26 14:28:16 +02:00
Ronald Cron	4f7feca0dc	Merge pull request #6391 from davidhorstmann-arm/fix-x509-get-name-cleanup The Open CI ran successfully thus I think we can ignore the internal CI.	2022-10-26 14:27:54 +02:00
Manuel Pégourié-Gonnard	3e0ea98b7c	Merge pull request #6451 from mpg/fix-can-exercise Fix can_exercise() for RSA and hashes	2022-10-26 10:18:52 +02:00
Tom Cosgrove	93003d87a9	Split out testing of core_add and core_add_if per Janos' request Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-10-25 17:01:19 +01:00
Minos Galanakis	37ca3a9acd	Moved tests from test_suite_bignum to test_suite_bignum_core This patch moves the following tests to test_suite_bignum_core: * `mbedtls_mpi_core_get_mont_r2_unsafe_neg()` * `mbedtls_mpi_core_get_mont_r2_unsafe()` Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-10-25 16:56:08 +01:00
Tom Cosgrove	eee0d6ce6b	Extend the unit tests for mbedtls_mpi_core_add_if() to also test mbedtls_mpi_core_add() Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-10-25 16:29:58 +01:00
Minos Galanakis	a081c51cd3	Renamed mpi_core_get_mont_R2_unsafe_neg -> mpi_core_get_mont_r2_unsafe_neg Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-10-25 15:12:38 +01:00
Minos Galanakis	ae4fb671b4	mbedtls_mpi_core_get_mont_R2_unsafe: Removed NULL input checking Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-10-25 15:12:38 +01:00
Minos Galanakis	e1913a8da8	test_suite_bignum: Updated test cases for mbedtls_mpi_core_get_mont_R2_unsafe This patch adds tests for 192 and 2048 bits inputs. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-10-25 15:12:31 +01:00
Minos Galanakis	b9243ef231	test_suite_bignum: Fixed whitespace issues Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-10-25 15:12:23 +01:00
Minos Galanakis	4f43f61c6a	Renamed mbedtls_mpi_get_montgomery_constant_unsafe to mpi_core_get_mont_R2_unsafe Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-10-25 15:12:23 +01:00
Minos Galanakis	1a1b175554	test_suite_bignum: Added tests for `mpi_get_montgomery_constant_unsafe()` This patch adds the test for the method calculating the RR. The input/expected data are generated manually using the following Python3 snippet: ~~~~~ import math title="mpi_get_montgomery_constant_unsafe" tt = title + " #{}" in_data = [ "0f", ... ] def limb_no(number, bil=64): return int(math.ceil(int.bit_length(number)/(bil * 1.0))) def calc_rr(number, bil=64 ): return '{:x}'.format(pow(pow(2, limb_no(number, bil) * bil), 2, number)) def calc_rr_str(number, prefix=""): rr64 = calc_rr(number) rr32 = calc_rr(number, bil=32) return '{}:"{:x}":"{}":"{}"'.format(prefix,number, rr32, rr64) print("\n\n".join(["{}\n{}".format(tt.format(in_data.index(v)+1), calc_rr_str(int(v,base=16), title)) for v in in_data])) ~~~~~ Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>	2022-10-25 15:12:01 +01:00
Gilles Peskine	383b0bbea0	Merge pull request #6461 from tom-cosgrove-arm/fix-mbedtls_mpi_mod_modulus_init-calls-in-tests mbedtls_mpi_mod_modulus_init() must be called before any 'goto exit' in tests	2022-10-25 13:40:17 +02:00
Gilles Peskine	e5a715e8c0	Merge pull request #6449 from gilles-peskine-arm/bignum-core-shift_r Bignum core: shift_r	2022-10-25 10:40:39 +02:00
Gilles Peskine	af8ea3f738	Merge pull request #6468 from gilles-peskine-arm/bignum-test-suite-names Rename test_suite_bignum for consistency	2022-10-25 10:40:29 +02:00
Ronald Cron	2012361ae6	Merge pull request #6448 from ronald-cron-arm/tls13-kex-build-options TLS 1.3 Introduce and use key exchange mode config options	2022-10-24 15:21:37 +02:00
Ronald Cron	73fe8df922	Introduce and use MBEDTLS_SSL_HANDSHAKE_WITH_PSK_ENABLED Introduce and use MBEDTLS_SSL_HANDSHAKE_WITH_PSK_ENABLED to guard TLS code (both 1.2 and 1.3) specific to handshakes involving PSKs. Signed-off-by: Ronald Cron <ronald.cron@arm.com>	2022-10-22 14:42:04 +02:00
Ronald Cron	e68ab4f55e	Introduce and use MBEDTLS_SSL_HANDSHAKE_WITH_CERT_ENABLED Introduce and use MBEDTLS_SSL_HANDSHAKE_WITH_CERT_ENABLED to guard TLS code (both TLS 1.2 and 1.3) specific to handshakes involving certificates. Signed-off-by: Ronald Cron <ronald.cron@arm.com>	2022-10-22 14:42:04 +02:00
Ronald Cron	928cbd34e7	tls13: Use MBEDTLS_SSL_TLS1_3_KEY_EXCHANGE_MODE_EPHEMERAL_ENABLED Use MBEDTLS_SSL_TLS1_3_KEY_EXCHANGE_MODE_EPHEMERAL_ENABLED instead of MBEDTLS_KEY_EXCHANGE_WITH_CERT_ENABLED to guard code specific to the TLS 1.3 ephemeral key exchange mode. Use it also for the dependencies of TLS 1.3 only tests relying on ephemeral key exchange mode, but for tests in tls13-kex-modes.sh where the change is done later using all MBEDTLS_SSL_TLS1_3_KEY_EXCHANGE_MODE_.*ENABLED macros. Signed-off-by: Ronald Cron <ronald.cron@arm.com>	2022-10-22 14:42:04 +02:00
Andrzej Kurek	ba970be142	Fix test dependencies for cases that are PSA-based These should be using PSA-type macros, not MBEDTLS_XXX_C. Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-21 13:39:00 -04:00
Gilles Peskine	a020d535ad	Avoid having both test_suite_XXX.data and test_suite_XXX.*.data Although our build scripts support that, it's annoying, because it makes "test_suite_XXX" ambiguous between "all the data for test_suite_XXX.function" and "just test_suite_XXX.data". Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-21 19:00:38 +02:00
Gilles Peskine	ce22066211	Rename test_suite_bignum for consistency with bignum.{h,c} Align the name of the bignum test suite with the source module (which was renamed from mpi.c to bignum.c in the PolarSSL 1.x days). This also brings it into line with the test suites for the low-level bignum interfaces. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-21 18:54:43 +02:00
Andrzej Kurek	ed05279e4f	Comment fix Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-21 10:28:55 -04:00
Andrzej Kurek	d066c79d7e	Add missing ECB requirements for PSA cipher aes tests Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-21 10:28:55 -04:00
Andrzej Kurek	8f26c8a0cf	Fix a typo in test_suite_cipher Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-21 10:28:55 -04:00
Ronald Cron	81cd7ab492	tests: ssl: Add missing dependency on MBEDTLS_X509_CRT_PARSE_C Signed-off-by: Ronald Cron <ronald.cron@arm.com>	2022-10-21 14:47:00 +02:00
Ronald Cron	f64cc03b09	tests: ssl: Add missing dependencies on certificate based handshake Signed-off-by: Ronald Cron <ronald.cron@arm.com>	2022-10-21 14:47:00 +02:00
Ronald Cron	457fb7a523	tests: ssl: Fix ciphersuite identifier Signed-off-by: Ronald Cron <ronald.cron@arm.com>	2022-10-21 14:44:45 +02:00
Manuel Pégourié-Gonnard	0e7e47147c	Merge pull request #6447 from mprse/driver-only-hash-gap Fix test gap in driver-only-hashes build	2022-10-21 10:32:43 +02:00
Manuel Pégourié-Gonnard	45c6792faf	Merge pull request #6385 from AndrzejKurek/depends-py-reloaded Unified tests/scripts/depends.py - reloaded	2022-10-21 10:17:58 +02:00
Tom Cosgrove	be17655b57	mbedtls_mpi_mod_modulus_init() must be called before any 'goto exit' in tests Fixes Coverity issues 381527 and 381526. Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-10-20 16:57:10 +01:00
Janos Follath	560805d665	Fix mbedtls_mpi_core_add_if test aliasing Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-10-20 12:04:40 +01:00
Gilles Peskine	b0ee577287	Bignum core: test shift_r Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-20 12:00:57 +02:00
Janos Follath	ba516f7524	mpi_core_add_if test: Remove dependency on old API Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-10-20 10:59:50 +01:00
Janos Follath	e153a715f0	mpi_core_add_if: simplify tests Use the new, limb size aware base class to generate tests for mpi_core_add_if(). Signed-off-by: Janos Follath <janos.follath@arm.com>	2022-10-20 10:40:03 +01:00
David Horstmann	2bb9c8a884	Change brace initialization to memset Signed-off-by: David Horstmann <david.horstmann@arm.com>	2022-10-20 10:18:37 +01:00
David Horstmann	01dd548025	Minor fixes to x509_get_name() test function Signed-off-by: David Horstmann <david.horstmann@arm.com>	2022-10-19 17:13:57 +01:00
Werner Lewis	f1c24f0fbc	Add missing include Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-10-19 16:43:22 +01:00
Werner Lewis	bd3ddafee2	Move tests added in #6289 Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-10-19 15:36:18 +01:00
Werner Lewis	6baf12b18d	Move legacy mod functions back to test_suite_mpi Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-10-19 15:20:01 +01:00
Werner Lewis	ffe4478936	Move mpi_core_bitlen tests to bignum_core files Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-10-19 15:20:01 +01:00
Werner Lewis	0c6ea12145	Move bignum_mod tests into separate files Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-10-19 15:20:01 +01:00
Werner Lewis	c9b6a0aef9	Move bignum_mod_raw tests into separate files Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-10-19 15:20:01 +01:00
Werner Lewis	c6004a2ab3	Move bignum_core tests into separate files Test cases for mpi_core_add_if, mpi_core_mla, mpi_core_sub, mpi_core_montmul are not copied into new files, these are generated in subsequent commits. Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-10-19 15:19:53 +01:00
Gilles Peskine	db2996357c	Merge pull request #6289 from gabor-mezei-arm/6237_Add_conditional_assign_and_swap_for_bignum Bignum: Add safe conditional assign and swap for the new MPI types	2022-10-19 15:51:19 +02:00
Andrzej Kurek	b50754ae86	Switch from x509_CRT_PARSE to KEY_EXCHANGE_WITH_CERT_ENABLED Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:09 -04:00
Andrzej Kurek	a2a9688501	Fix the memory allocation in test_suite_ssl ASSERT_ALLOC calculates the size itself, and the parameter indicates number of elements. ``` mbedtls_calloc( sizeof( *( pointer ) ), ( length ) ); ``` Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:09 -04:00
Andrzej Kurek	658442fe78	Remove unnecessary ECP_C dependencies Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:09 -04:00
Andrzej Kurek	e5a5cc1944	Remove the dependency of tls1_3 key evolution tests on curve25519 Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:09 -04:00
Andrzej Kurek	daf43fbe21	Move the location of MBEDTLS_ECP_C dependencies Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:09 -04:00
Andrzej Kurek	2d637c4cbb	Fix unchecked allocation in test_suite_ssl Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:09 -04:00
Andrzej Kurek	e64bd43495	Add missing ECP and ECDH dependencies in ssl test suites Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:08 -04:00
Andrzej Kurek	8e44139ca0	Add missing CURVE25519 requirements to TLS 1.3 tests Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:08 -04:00
Andrzej Kurek	84f30f2eb0	Add missing SHA256 dependency Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:08 -04:00
Andrzej Kurek	e38b788b79	Add missing key exchange dependencies Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:08 -04:00
Andrzej Kurek	90e8204476	Add missing SHA256 and ECDSA_C dependencies in test_suite_ssl Most of the tests (including those using endpoint_init functions) parse certificates that require MBEDTLS_SHA256_C to be present. Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:08 -04:00
Andrzej Kurek	0abebebe6d	Refactor ssl test suite to use pointers more This way it's easier to track structures that are partially set up. Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:08 -04:00
Andrzej Kurek	f502bcb13e	Fix missing AES dependencies Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:08 -04:00
Andrzej Kurek	e40b92178d	Fix missing padding dependencies Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:08 -04:00
Andrzej Kurek	252283f2aa	Fix missing cipher mode dependencies Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-10-19 08:35:08 -04:00
Przemek Stekiel	8258ea7b7d	test_suite_psa_crypto: adapt dependenies and guards so the test can run in the driver-only build Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>	2022-10-19 13:20:20 +02:00
Manuel Pégourié-Gonnard	deef905a1c	Update is_builtin_calling_md() for PKCS#1 v2.1 Since https://github.com/Mbed-TLS/mbedtls/pull/6141 it can "fall back" to PSA when MD is not available (but will use MD if available, to preserve backwards compatibility). Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>	2022-10-19 11:02:15 +02:00
Manuel Pégourié-Gonnard	98b91d40d6	RSA PKCS#1 v1.5 no longer depends on MD This has been the case since https://github.com/Mbed-TLS/mbedtls/pull/6065 which forgot to update the documentation, and also is_builtin_calling_md(), so update those. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>	2022-10-19 10:59:30 +02:00
Gabor Mezei	4dceede71b	Fix overly replacement in the documentation Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-18 16:44:17 +02:00
Przemek Stekiel	98b1af4e34	test_suite_debug: adapt dependenies so the test can run in the driver-only build Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>	2022-10-18 14:52:41 +02:00
David Horstmann	3cd67584bc	Improve X509 DN test naming Signed-off-by: David Horstmann <david.horstmann@arm.com>	2022-10-17 17:59:10 +01:00
David Horstmann	d0e3d45e96	Add explanatory comments to raw DER test data Break down the DER-encoded ASN.1 test data into its structure in a comment and explain it, to make it easier to understand where the data came from and how it is corrupted. Signed-off-by: David Horstmann <david.horstmann@arm.com>	2022-10-17 17:55:04 +01:00
Gilles Peskine	47da7bfac8	Merge pull request #6434 from gilles-peskine-arm/lmots_import_export_test-memory_leak LMS: Fix memory leak if unit test fails	2022-10-17 17:57:59 +02:00
Gabor Mezei	0c74e084d5	Fix condition Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-17 16:09:58 +02:00
Gilles Peskine	503d09b52d	Fix memory leak if unit test fails Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-17 12:27:43 +02:00
Manuel Pégourié-Gonnard	6c6f04b651	Merge pull request #6419 from mpg/fix-assert-alloc-usage Fix usage of ASSERT_ALLOC()	2022-10-17 12:10:48 +02:00
Gilles Peskine	8874cd570e	Merge pull request #4826 from RcColes/development Add LMS implementation	2022-10-14 18:33:01 +02:00
Gabor Mezei	ffb4aa0ddc	Rename variables to have unambiguous names Use bytes instead of len in the variable names. Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-14 16:39:04 +02:00
Gabor Mezei	8bcd7cca94	Use count instead of bytes in ASSERT_ALLOC argument Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-14 16:18:10 +02:00
Tom Cosgrove	edca207260	MBEDTLS_CIPHER_CHACHA20_POLY1305 is an mbedtls_cipher_type_t not an mbedtls_cipher_mode_t Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-10-14 12:10:40 +01:00
Manuel Pégourié-Gonnard	b3c30907d6	Merge pull request #6383 from mprse/aead_driver_test Enable testing of AEAD drivers with libtestdriver1	2022-10-14 11:11:01 +02:00
Manuel Pégourié-Gonnard	47b8de834d	Fix usage of ASSERT_ALLOC() The second argument is the number of elements of the type the first argument is pointing to, so we shouldn't be using sizeof there. This was resulting in overly large allocations. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>	2022-10-14 09:35:55 +02:00
Gilles Peskine	31c2dcb611	Fix file names in reproduction instructions in test data Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-13 20:48:15 +02:00
Gilles Peskine	2875aa7b01	Fix instructions and test data for pyhsslms interop tests The test data was invalid because it had the extra 4-byte prefix for HSS. Regenerate it (which produces completely new signatures since it is randomized). Rearrange the reproduction instructions for the second test case so that it shows more clearly how to generate a second signature with the same private key. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-13 20:45:05 +02:00
Raef Coles	8bccc999d9	Don't mention error type in LMS test comments Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 17:57:31 +01:00
Raef Coles	6d7d94a821	Use correct export length in LMS export tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 17:55:46 +01:00
Raef Coles	aa9d52bcdc	Rename LMS private key files to match library name Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 17:53:40 +01:00
Raef Coles	f8bfe2783b	Remove bad character from LMS test case Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 17:35:28 +01:00
Raef Coles	d543697092	Fix minor type in LMS test description Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 17:06:42 +01:00
Raef Coles	a2514f622f	Update pyhsslms test instructions with script Due to tool name conflict hampering data reproduction Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 17:04:21 +01:00
Raef Coles	ce18e528ff	Rename LMS private key files And remove now-unnecessary modification to check_files.py Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 16:45:05 +01:00
Raef Coles	e4d96b804c	Update LMS and LMOTS test comments Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 16:45:05 +01:00
Raef Coles	493724e3c2	Check correct output size in LMOTS export test Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 15:43:07 +01:00
Raef Coles	ed0e4591dc	Add output length test for LMS export too-big test Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 15:05:47 +01:00
Raef Coles	33f7d66304	Add output check to export too-big buffer tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:36 +01:00
Raef Coles	1d88ea870f	Remove unneeded NULL pointer checks in LMS tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:35 +01:00
Raef Coles	a21671123a	Remove `sudo pip3` in LM(OT)S tests instructions Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:27 +01:00
Raef Coles	1b43a7448d	Clean up LMS and LMOTS feature dependencies Remove SHA256 dependencies from tests, fix incorrect boolean logic in check_config, and change depends_hashes.pl to disable LMS in one test Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:26 +01:00
Raef Coles	6b2c573b3d	And export buffer too large test to LMS and LMOTS Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:24 +01:00
Raef Coles	534f66f3f0	Fix assert arguments in LMS and LMOTS export tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:23 +01:00
Raef Coles	d1c2a80319	Remove duplicated assert from LMOTS tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:21 +01:00
Raef Coles	20d2e06ca4	Add cleanup frees in LMS and LMOTS tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:20 +01:00
Raef Coles	781f7bedb0	Properly mark LMOTS leak test as failed Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:18 +01:00
Raef Coles	d137c86125	Don't skip LMS tests due to out of memory error Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:17 +01:00
Raef Coles	76563399fd	Fix LMS and LMOTS test dependencies Mark them as depending on PSA_WANT_ALG_SHA256 so that test_depends_hashes_psa doesn't fail Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:15 +01:00
Raef Coles	59eb0d0f2b	Fix LMOTS signature leak test dependencies As it requires MBEDTLS_LMS_PRIVATE Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:12 +01:00
Raef Coles	d0c701237a	Replace TEST_ASSERT with TEST_EQUAL in LMS tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:09 +01:00
Raef Coles	f9b8502865	Add LMS import/export negative tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:06 +01:00
Raef Coles	9fc303a99a	Add extra LMOTS import negative tests And fix failures that are related to the new tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:01 +01:00
Raef Coles	71f554b48f	Use real data for negative LMOTS tests To avoid errors caused by the null public keys and signatures Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:30:00 +01:00
Raef Coles	66edf6a833	Use hsslms data for LMOTS import/export test Also, test that export fails when the buffer is too small. Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:58 +01:00
Raef Coles	8b55ba623e	Source LMOTS data from hsslms So it can be reproduced Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:57 +01:00
Raef Coles	a6b47c0aac	Add LMS hsslms interop tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:55 +01:00
Raef Coles	d6adcb6146	Add negative LMS import/export tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:53 +01:00
Raef Coles	810612e14e	Update LMS and LMOTS to use TEST_EQUAL Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:51 +01:00
Raef Coles	90e13fc3c6	Add repro instructions for LMS test data Add more interop tests, and use real data for the negative tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:49 +01:00
Raef Coles	0dc604ed2b	Change how LMS and LMOTS negative tests work Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:48 +01:00
Raef Coles	7726678b23	Remove debugging code left in LMOTS tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:46 +01:00
Raef Coles	370cc43630	Make LMS public key export part of public key api Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:28 +01:00
Raef Coles	be3bdd8240	Rename LMS and LMOTS init/free functions To match convention Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:18 +01:00
Raef Coles	5127e859d7	Update LMS and LMOTS dependency macros Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:11 +01:00
Raef Coles	98c504373c	Update LMS test description To correct copy-paste error Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:29:02 +01:00
Raef Coles	40158e11fc	Add LMOTS test hook to header Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:28:58 +01:00
Raef Coles	9c9027b1a4	Add extra LMS and LMOTS tests NULL-message and LMOTS signature leak tests Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:28:50 +01:00
Raef Coles	f5919e2997	Update LMS/LMOTS tests Document tests and source of data, use test RNG, pass more parameters into each test Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:28:43 +01:00
Raef Coles	e9479a0264	Update LMS API to support multiple parameter sets Parameterise macros to allow variation of sizes Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:28:36 +01:00
Raef Coles	ab4f87413a	Add MBEDTLS_LMS_PRIVATE define To enable private key operations Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:28:35 +01:00
Raef Coles	01c71a17b3	Update LMS and LMOTS api Fix function names and parameters. Move macros to be more private. Update implementation. Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:28:25 +01:00
Raef Coles	c8f9604d7b	Use PSA hashing for LMS and LMOTS Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:28:23 +01:00
Raef Coles	7dce69a27a	Make LMOTS a private api Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:28:22 +01:00
Raef Coles	8ff6df538c	Add LMS implementation Also an LM-OTS implementation as one is required for LMS. Signed-off-by: Raef Coles <raef.coles@arm.com>	2022-10-13 14:28:15 +01:00
Manuel Pégourié-Gonnard	f155ab9a91	Abort on errors when we should We're not strictly required to abort, but at least to leave the context is an invalid state. For "late" functions like input() and output(), calling abort() is the easiest way to do that. Do it systematically for input() and output() by using a wrapper. psa_pake_get_implicit_key() was already doing it. For "early" function, we can just leave the operation in its current state which is already invalid. Restore previous tests about that. Not adding systematic tests, though, just test the two functions that are the most important, and more likely to return errors. Since we now abort in more cases, we need to make sure we don't invalidate the operation that's going to be re-used later in the test. For that reason, use a copy of the operation for calls to input() and output() that are expected to return errors. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>	2022-10-13 13:20:31 +02:00
Manuel Pégourié-Gonnard	b63a9ef09f	Fix buffer sizes in ecjpake_setup test function Also, the error code changed from INSUFFICIENT_MEMORY to INVALID_DATA. Temporarily remove a test about aborting the operation on error. Auto-abort will be re-introduced in the next commit in a more systematic way. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>	2022-10-13 13:17:20 +02:00
Gilles Peskine	0fe6631486	Merge pull request #6291 from gilles-peskine-arm/platform.h-unconditional-3.2 Include platform.h unconditionally	2022-10-13 10:19:22 +02:00
Gilles Peskine	8fd3254cfc	Merge pull request #6374 from mprse/enc_types Test TLS 1.2 builds with each encryption type	2022-10-12 12:45:50 +02:00
Ronald Cron	78317c832b	Merge pull request #6327 from yuhaoth/pr/tls13-psk-after-session-tickets TLS 1.3: PSK and NewSessionTicket: Add support for sending PSK and Ticket together.	2022-10-12 12:39:51 +02:00
Gilles Peskine	58e5d804ee	test_suite_pk: Add missing dependencies on MBEDTLS_PEM_PARSE_C Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-11 20:57:38 +02:00
Gilles Peskine	d23d8dee24	test_suite_dhm: Add missing dependencies on MBEDTLS_PEM_PARSE_C Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-11 20:57:21 +02:00
Gilles Peskine	9624a5932e	Add mbedtls_dhm_parse_dhmfile test case with DER input dh.optlen.der is the result of converting dh.optlen.pem from PEM to DER. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-11 20:52:34 +02:00
Gilles Peskine	b50e433b66	Test mbedtls_mpi_core_bitlen Copy the test data for mbedtls_mpi_bitlen except for 0-length and negative cases. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-10 23:03:47 +02:00
Gilles Peskine	e943283f2f	More mbedtls_mpi_bitlen test cases * with leading zero limb * with trailing zero limb * negative Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-10 23:03:47 +02:00
Gilles Peskine	24baa81043	Improve mbedtls_mpi_bitlen test descriptions Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-10 23:03:47 +02:00
Gilles Peskine	c5772a194e	mbedtls_test_read_mpi_core: allow odd number of hex digits Test functions must now take a char* argument rather than data_t*. This does not affect existing test data. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-10-10 23:03:47 +02:00
Janos Follath	1b5c85c75b	Merge pull request #6386 from gilles-peskine-arm/bignum-mbedtls_test_read_mpi_core Introduce mbedtls_test_read_mpi_core	2022-10-10 15:14:46 +01:00
Gabor Mezei	44ba2f6db9	Add more test cases Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-10 15:32:12 +02:00
Gabor Mezei	a67a1a3ebc	Remove the 'is_fail' parameter from the test functions Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-10 15:25:59 +02:00
Gabor Mezei	d71eb0c3ac	Use better test macro Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-10 13:09:04 +02:00
Gabor Mezei	d6441da4c5	Remove redundant memory initialization When memory is allocated it is also initialized with 0. Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-10 13:05:16 +02:00
Gabor Mezei	251cb632f1	Remove unused macro definition Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-10 13:02:21 +02:00
Przemek Stekiel	42bb3ff40b	Adapt expected results in ChaCha20-Poly1305 ( invalid tag length) Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>	2022-10-10 07:28:40 +02:00
Jerry Yu	8897c07075	Add server only guards for psk callback Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>	2022-10-07 10:11:05 +08:00
David Horstmann	db73d3b149	Add mbedtls_x509_get_name memory leak unit test Introduce a unit test to test mbedtls_x509_get_name() and add a testcase with a corrupt DER-encoded name that causes mbedtls_x509_get_name() to have to cleanup things it is allocated. If it fails to do this, a memory leak is detected under Asan builds. Signed-off-by: David Horstmann <david.horstmann@arm.com>	2022-10-05 13:09:57 +01:00
Manuel Pégourié-Gonnard	ec7012dbc7	Fix I/O format of PSA EC J-PAKE for compliance The format used by the mbedtls_ecjpake_xxx() APIs and that defined by the PSA Crypto PAKE extension are quite different; the former is tailored to the needs of TLS while the later is quite generic and plain. Previously we only addressed some part of this impedance mismatch: the different number of I/O rounds, but failed to address the part where the legacy API adds some extras (length bytes, ECParameters) that shouldn't be present in the PSA Crypto version. See comments in the code. Add some length testing as well; would have caught the issue. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>	2022-10-05 12:52:48 +02:00
Gilles Peskine	80ca44f33c	Merge pull request #6325 from gabor-mezei-arm/6308_missing_initialization_in_test Add initialization for structures in test	2022-10-05 11:09:35 +02:00
Gabor Mezei	8fcde5bb8e	Remove duplicate test case Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-04 13:53:33 +02:00
Gabor Mezei	02e5d439db	Add more tests for cond_assign/swap functions Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-03 16:45:11 +02:00
Gabor Mezei	6546a6cc03	Rewrite tests for cond_assign/swap The cond_swap and cond_assign test functions now requires the same limb size for the MPI parameters. Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-10-03 14:56:51 +02:00
Glenn Strauss	2ff77119df	mbedtls_ecp_point_read_binary from compressed fmt mbedtls_ecp_point_read_binary from MBEDTLS_ECP_PF_COMPRESSED format Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com>	2022-10-03 05:43:27 -04:00
Gilles Peskine	5bbdfce44c	Streamline mbedtls_mpi_core_lt_ct unit test Use mbedtls_test_read_mpi_core() to read the test data. Among other benefits, X and Y are now allocated to their exact size, so analyzers (Asan, Valgrind, Coverity, ...) have a chance of complaining if the tested function overflows the buffer. Remove TEST_CF_PUBLIC calls which are no longer necessary. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-09-30 18:53:04 +02:00
Gilles Peskine	571576fc5c	Move the definition of data_t to a header file This way it can be used in helper functions. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-09-30 18:51:41 +02:00
Tom Cosgrove	c621a6d38f	Update tests to account for CIPHER_FEATURE_UNAVAILABLE on non-authenticated alg Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-30 17:15:54 +01:00
Gabor Mezei	ec5685f1ee	Use exact-size buffers for inputs and outputs to library functions in tests Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-30 14:48:54 +02:00
Gabor Mezei	f5ca726ce1	Rename variables to match bettr to its purpose The length in bytes is used with the 'len' prefix and the length in limbs is used with the 'limbs' prefix. Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-30 14:35:42 +02:00
Gabor Mezei	8b05e3b148	Add memory freeing Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-30 13:36:41 +02:00
Gabor Mezei	a7584888da	Use exact-size buffers for inputs and outputs to library functions in tests Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-30 13:36:41 +02:00
Gabor Mezei	821d15107b	Check true and false condition in the same test case Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-30 13:36:41 +02:00
Gabor Mezei	3eff425b1a	Use only one limb parameter for assign Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-30 13:36:40 +02:00
Gabor Mezei	027d696434	Remove unused code Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-30 13:36:40 +02:00
Gabor Mezei	b2763ef507	Do not read uninitialized memory Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-30 13:36:40 +02:00
Gabor Mezei	cfc0eb8d22	Remove unused parameter Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-30 13:36:39 +02:00
Gabor Mezei	53e455db7b	Remove return value checking from test functions of assign and swap Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-30 13:36:39 +02:00
Gabor Mezei	b27b1c5db0	Add tests for conditional assign and swap functions Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-30 13:36:30 +02:00
Gilles Peskine	845de0898e	Merge pull request #6083 from tom-cosgrove-arm/issue-6015-montgomery-multiplication Montgomery multiplication from bignum prototype	2022-09-30 10:35:21 +02:00
Victor Barpp Gomes	d0225afcb6	Add a new test with a binary hwSerialNum Signed-off-by: Victor Barpp Gomes <17840319+Kabbah@users.noreply.github.com>	2022-09-29 13:52:55 -03:00
Victor Barpp Gomes	47c7a732d2	Print RFC 4108 hwSerialNum in hex format Signed-off-by: Victor Barpp Gomes <17840319+Kabbah@users.noreply.github.com>	2022-09-29 11:34:23 -03:00
Tom Cosgrove	4386ead662	Correct the aliasing requirements in doc for mbedtls_mpi_core_montmul(), and test them Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-29 14:40:21 +01:00
Przemek Stekiel	a891a091a3	test_suite_cmac.data: fix bug: use cipher type instead cipher id Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>	2022-09-29 09:53:20 +02:00
Manuel Pégourié-Gonnard	f3f9e450b6	Merge pull request #6115 from AndrzejKurek/ecjpake-kdf-tls-1-2 Ad-hoc KDF for EC J-PAKE in TLS 1.2	2022-09-28 09:47:32 +02:00
Gabor Mezei	0bb138241b	Add initialization for structures Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-27 18:48:44 +02:00
Przemek Stekiel	6f29a6c4b4	test_suite_cipher.function: always include aes.h It is done to have MBEDTLS_ERR_AES_INVALID_INPUT_LENGTH macro available (used in tests) Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>	2022-09-27 15:04:14 +02:00
Andrzej Kurek	3539f2c90b	Improve readability in ecjpake tests Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-09-26 10:56:02 -04:00
Gilles Peskine	12a1e85caa	Merge pull request #6138 from Zaya-dyno/validation_remove_change_key_agree Validation remove change key agree	2022-09-23 17:04:20 +02:00
Gilles Peskine	87953f228f	Merge pull request #6091 from Zaya-dyno/validation_remove_change_pk Validation remove change pk	2022-09-23 17:03:30 +02:00
Gabor Mezei	f29c2a5313	Add initialization for structures Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>	2022-09-23 15:25:27 +02:00
Manuel Pégourié-Gonnard	1475ac49a4	Merge pull request #6107 from Zaya-dyno/validation_remove_change_hash Validation remove change hash	2022-09-22 09:24:44 +02:00
Manuel Pégourié-Gonnard	d5c82fb821	Merge pull request #6085 from Zaya-dyno/validation_remove_change_cipher Validation remove and change in files related to cipher in library	2022-09-22 09:10:13 +02:00
Tom Cosgrove	c573882674	Merge remote-tracking branch 'upstream/development' into issue-6015-montgomery-multiplication	2022-09-21 12:08:43 +01:00
Manuel Pégourié-Gonnard	d433cd7d07	Merge pull request #6283 from mpg/driver-only-hashes-wrap-up Driver only hashes wrap-up	2022-09-21 08:29:46 +02:00
Dave Rodgman	36e1d9ef1d	Merge pull request #6203 from wernerlewis/ecp_group_test Add test for ECP group metadata	2022-09-20 17:35:53 +01:00
Tom Cosgrove	b0b77e1b13	Document and test aliasing of the bignums given to mbedtls_mpi_core_mla() Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-20 13:33:40 +01:00
Tom Cosgrove	ea45c1d2d4	Document and test aliasing of output for mbedtls_mpi_core_montmul() Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-20 13:17:51 +01:00
Werner Lewis	05feee1841	Restore vbuf value after modification Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-09-20 12:05:58 +01:00
Werner Lewis	ccae25b4bf	Add explicit mbedtls_ecp_tls_read_group_id call Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-09-20 10:00:07 +01:00
Werner Lewis	7403d93f8a	Add leading zeros to group metadata Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-09-20 09:41:05 +01:00
Werner Lewis	57807308d5	Fix typo in MBEDTLS_ECP_DP_BP512R1 Signed-off-by: Werner Lewis <werner.lewis@arm.com>	2022-09-20 09:16:11 +01:00
Tom Cosgrove	f2b3818a69	Test when all three inputs to mbedtls_mpi_core_sub() are aliased Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-20 09:08:31 +01:00
Manuel Pégourié-Gonnard	1367f40d38	Fix memory corruption in an SSL test function Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>	2022-09-19 11:00:23 +02:00
Andrzej Kurek	2be1689504	Add capacity testing to EC J-PAKE to PMS tests Let the caller restrict the capacity but limit it to 32 bytes. Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-09-16 07:14:04 -04:00
Andrzej Kurek	d37850404a	Add derivation step testing to EC J-PAKE to PMS tests Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-09-16 06:45:44 -04:00
Manuel Pégourié-Gonnard	07018f97d2	Make legacy_or_psa.h public. As a public header, it should no longer include common.h, just use build_info.h which is what we actually need anyway. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>	2022-09-16 12:02:48 +02:00
Gilles Peskine	a844b4b370	No need to use MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED in tests Initializing return status variables to CORRUPTION_DETECTED is a second line of defense in library code in case there's a code path where we forget to assign to the variable. This isn't useful in test code. In any case, here, we might as well define the variable at the point of use. This fixes a build error in configurations with MBEDTLS_ERROR_C and MBEDTLS_PSA_CRYPTO_C both disabled, because then mbedtls/error.h isn't included so MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED isn't defined. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-09-15 21:05:04 +02:00
Gilles Peskine	945b23c46f	Include platform.h unconditionally: automatic part We used to include platform.h only when MBEDTLS_PLATFORM_C was enabled, and to define ad hoc replacements for mbedtls_xxx functions on a case-by-case basis when MBEDTLS_PLATFORM_C was disabled. The only reason for this complication was to allow building individual source modules without copying platform.h. This is not something we support or recommend anymore, so get rid of the complication: include platform.h unconditionally. There should be no change in behavior since just including the header should not change the behavior of a program. This commit replaces most occurrences of conditional inclusion of platform.h, using the following code: ``` perl -i -0777 -pe 's!#if.\n#include "mbedtls/platform.h"\n(#else.\n(#define (mbedtls\|MBEDTLS)_.\n\|#include <(stdarg\|stddef\|stdio\|stdlib\|string\|time)\.h>\n))?#endif.*!#include "mbedtls/platform.h"!mg' $(git grep -l '#include "mbedtls/platform.h"') ``` Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>	2022-09-15 20:33:07 +02:00
Tom Cosgrove	c71ca0cb3c	Remove some unnecessary whitespace (two spaces after commas) Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-15 15:38:17 +01:00
Tom Cosgrove	dbc156172c	Don't bother to test b + a after testing a + b if a == b Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-15 15:36:23 +01:00
Tom Cosgrove	17f1fdca0f	Update comments in mpi_core_add_if() test Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-15 15:23:56 +01:00
Tom Cosgrove	b7438d1f62	Update name of mbedtls_mpi_montg_init() Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-15 15:05:59 +01:00
Tom Cosgrove	359feb0d2f	Better wording for the reason why we use an input MPI for a scalar value Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-15 14:52:34 +01:00
Tom Cosgrove	e2159f2083	Use the MAX() macro Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-15 14:40:10 +01:00
Tom Cosgrove	be7209db1f	Remove unnecessary casts Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-15 14:32:38 +01:00
Tom Cosgrove	50c477bd6b	Use S and sum (rather than X/expected) in mpi_core_add_if() Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-15 14:28:30 +01:00
Tom Cosgrove	1feb5ac1b7	Switch to using TEST_LE_S() and TEST_LE_U() in tests Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-15 14:22:35 +01:00
Tom Cosgrove	2b177926ad	Use ASSERT_ALLOC() in tests Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-15 14:07:18 +01:00
Manuel Pégourié-Gonnard	18dff1f226	Merge pull request #5871 from superna9999/4153-psa-expose-ec-j-pake Expose ECJPAKE through the PSA Crypto API	2022-09-15 09:25:55 +02:00
Nick Child	8ce1b1afc8	pkcs7: Correct various syntatical mistakes Resond to feedback from the following comments: - use correct spacing [1-7] - remove unnecessary parenthesis [8] - fixup comments [9-11] - remove unnecessary init work [12] - use var instead of type for sizeof [13] [1] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953655691 [2] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953661514 [3] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953689929 [4] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953696384 [5] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953697558 [6] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953697793 [7] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953697951 [8] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953699102 [9] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r971223775 [10] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r967133905 [11] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r967135932 [12] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r967151430 [13] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r967154159 Signed-off-by: Nick Child <nick.child@ibm.com>	2022-09-14 15:13:52 -05:00
Nick Child	34d5e931cf	pkcs7: Use better return code for unimplemented specifications In response to feedback [1] [2], use MBEDTLS_ERR_PKCS7_FEATURE_UNAVAILABLE instead of MBEDTLS_ERR_PKCS7_INVALID_FORMAT for errors due to the pkcs7 implemntation being incomplete. [1] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953649079 [2] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953658276 Signed-off-by: Nick Child <nick.child@ibm.com>	2022-09-14 14:44:03 -05:00
Nick Child	8a94de40c7	test/pkcs7: Reduce number of test functions In response to feedback[1], we can reuse much of the functions in similar test cases by specifying some additional parameters. Specifically, test cases which probe the functionality of `mbedtls_pkcs7_parse_der` have all been merged into one test function. Additionally, all test cases which examine the `mbedtls_pkcs7_signed_data_verify` and `mbedtls_pkcs7_signed_hash_verify` functions have been merged into two test functions (one for single and one for multiple signers). [1] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953686780 Signed-off-by: Nick Child <nick.child@ibm.com>	2022-09-14 11:27:29 -05:00
Andrzej Kurek	d8705bc7b7	Add tests for the newly created ad-hoc EC J-PAKE KDF Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-09-14 08:39:41 -04:00
Przemek Stekiel	40afdd2791	Make use of MBEDTLS_MAX_HASH_SIZE macro Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>	2022-09-06 14:18:45 +02:00
Neil Armstrong	2a73f21878	Fixup expected status handling in ecjpake_setup() and add more coverage for psa_pake_set_password_key() Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>	2022-09-06 11:34:54 +02:00
Neil Armstrong	78c4e8e9cb	Make ecjpake_do_round() return void and use TEST_ASSERT with a descriptive text instead of returning a value Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>	2022-09-05 18:08:13 +02:00
Neil Armstrong	51009d7297	Add comment in ecjpake_do_round() explaining input errors can be detected any time in the input sequence Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>	2022-09-05 17:59:54 +02:00
Andrzej Kurek	c502210291	Adjust pkparse test dependencies Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-09-02 15:33:20 -04:00
Tom Cosgrove	1135b20064	Add mbedtls_mpi_core_add_if() tests for when inputs are aliased Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-02 11:46:18 +01:00
Tom Cosgrove	42dfac6ae8	Rename variables and update comments in mpi_core_mla test Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-02 11:27:39 +01:00
Tom Cosgrove	a043aeb95c	Rename variables and update comments in mpi_core_sub test Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-02 11:27:39 +01:00
Tom Cosgrove	eceb4ccfc3	Rename variables and update comments in mpi_core_add_if test Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-02 11:27:31 +01:00
Tom Cosgrove	1b2947a614	Remove mbedtls_ prefix from bignum test cases Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-02 10:24:55 +01:00
Andrzej Kurek	7a32072038	Setup / deinitialize PSA in pk tests only if no MD is used Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-09-02 04:07:15 -04:00
Andrzej Kurek	26909f348f	Add PSA initialization and teardown to tests using pkcs5 If PSA is defined and there is no MD - an initialization is required. Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-09-02 04:05:37 -04:00
Andrzej Kurek	ed98e95c81	Adjust pkcs5 test dependencies Hashing via PSA is now supported Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-09-02 04:03:25 -04:00
Andrzej Kurek	dd36c76f09	Provide a version of pkcs5_pbkdf2_hmac without MD usage Use the new implementation locally Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-09-02 04:03:25 -04:00
Manuel Pégourié-Gonnard	97fc247d6a	Merge pull request #6232 from AndrzejKurek/pkcs12-no-md Remove MD dependency from pkcs12 module	2022-09-02 09:43:13 +02:00
Nick Child	62b2d7e7d4	pkcs7: Support verification of hash with multiple signers Make `mbedtls_pkcs7_signed_hash_verify` loop over all signatures in the PKCS7 structure and return success if any of them verify successfully. Signed-off-by: Nick Child <nick.child@ibm.com>	2022-09-01 19:45:41 -05:00
Daniel Axtens	3538479faa	pkcs7: support multiple signers Rather than only parsing/verifying one SignerInfo in the SignerInfos field of the PKCS7 stucture, allow the ability to parse and verify more than one signature. Verification will return success if any of the signatures produce a match. Signed-off-by: Daniel Axtens <dja@axtens.net> Signed-off-by: Nick Child <nick.child@ibm.com>	2022-09-01 19:45:41 -05:00
Nick Child	8a10f66692	test/pkcs7: Add init for PSA tests Initialize the PSA subsystem in the test functions. Signed-off-by: Nick Child <nick.child@ibm.com>	2022-09-01 19:45:41 -05:00
Nick Child	45525d3768	pkcs7: Fix dependencies for pkcs7 tests Fixes include removing PEM dependency for greater coverage when PEM config is not set and defining test dependencies at the appropriate level. Signed-off-by: Nick Child <nick.child@ibm.com>	2022-09-01 19:45:41 -05:00
Nick Child	6671841d91	pkcs7.c: Do not ignore return value of mbedlts_md CI was failing due to the return value of mbedtls_md being ignored. If this function does fail, return early and propogate the md error. Signed-off-by: Nick Child <nick.child@ibm.com>	2022-09-01 19:45:41 -05:00
Manuel Pégourié-Gonnard	600bd30427	Avoid unwanted eol conversion of test data Also, text files don't need to be generated by the Makefile. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>	2022-09-01 19:45:41 -05:00
Nayna Jain	673a226698	pkcs7: add support for signed data OpenSSL provides APIs to generate only the signted data format PKCS7 i.e. without content type OID. This patch adds support to parse the data correctly even if formatted only as signed data Signed-off-by: Nayna Jain <nayna@linux.ibm.com>	2022-09-01 19:45:41 -05:00
Nayna Jain	c9deb184b0	mbedtls: add support for pkcs7 PKCS7 signing format is used by OpenPOWER Key Management, which is using mbedtls as its crypto library. This patch adds the limited support of pkcs7 parser and verification to the mbedtls. The limitations are: * Only signed data is supported. * CRLs are not currently handled. * Single signer is supported. Signed-off-by: Daniel Axtens <dja@axtens.net> Signed-off-by: Eric Richter <erichte@linux.ibm.com> Signed-off-by: Nayna Jain <nayna@linux.ibm.com>	2022-09-01 19:45:33 -05:00
Tuvshinzaya Erdenekhuu	7714368667	Remove unused variable Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-09-01 17:11:14 +01:00
Tuvshinzaya Erdenekhuu	08b223443f	Add new tests Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-09-01 16:18:00 +01:00
Tuvshinzaya Erdenekhuu	fe7524de03	Make minor style change Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-09-01 16:07:18 +01:00
Tom Cosgrove	b0fb17a829	Use ASSERT_COMPARE() instead of memcmp() in new tests Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-01 15:04:43 +01:00
Andrzej Kurek	7bd12c5d5e	Remove MD dependency from pkcs12 module Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>	2022-09-01 08:57:41 -04:00
Tom Cosgrove	9339f05a81	Swap arguments of TEST_EQUAL() where it improves readability Especially for a sequence of similar lines of test code, or where the result of an expression is being compared to a short integer (especially 0 or 1). Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>	2022-09-01 13:02:53 +01:00
Manuel Pégourié-Gonnard	0777ec1625	Merge pull request #6109 from superna9999/6100-crash-in-test-suite-x509write Crash in test suite x509write config full no seedfile	2022-09-01 11:18:30 +02:00
Tuvshinzaya Erdenekhuu	7e2e2a9762	Add new checks in rsa_invalid_param test This new checks covers previous commits Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:15:59 +01:00
Tuvshinzaya Erdenekhuu	61f1372b8c	Remove unused variables from shax.function Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:15:25 +01:00
Tuvshinzaya Erdenekhuu	ca6fde2e1f	Enable invalid param test in sha512 Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:15:25 +01:00
Tuvshinzaya Erdenekhuu	1db192bc5a	Enable invalid param test in sha256 Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:15:25 +01:00
Tuvshinzaya Erdenekhuu	d5ebedffd0	Removed unused variable in cipher test Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:14:57 +01:00
Tuvshinzaya Erdenekhuu	104eb7f4a8	Enabled invalid param test for gcm Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:14:57 +01:00
Tuvshinzaya Erdenekhuu	6c68927948	Enabled invalid param test for cipher Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:14:57 +01:00
Tuvshinzaya Erdenekhuu	c7d7220814	Enabled invalid param test in camellia Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:14:57 +01:00
Tuvshinzaya Erdenekhuu	c855bf5285	Enabled invalid param test for aes Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:14:57 +01:00
Tuvshinzaya Erdenekhuu	0050b918f0	Added new tests in pk_invalid_param Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:14:25 +01:00
Tuvshinzaya Erdenekhuu	ed99ed34f3	Add spaces to comply with coding style Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:14:25 +01:00
Tuvshinzaya Erdenekhuu	c388af63e4	Remove extra spacings Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:14:25 +01:00
Tuvshinzaya Erdenekhuu	79bf51a109	Add new test for invalid param in pk.c Signed-off-by: Tuvshinzaya Erdenekhuu <tuvshinzaya.erdenekhuu@arm.com>	2022-08-31 10:14:25 +01:00
Neil Armstrong	e5fdf20a79	Make ecjpake_rounds test depends on PSA_WANT_ALG_TLS12_PSK_TO_MS Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>	2022-08-31 10:49:18 +02:00
Neil Armstrong	eae1dfcc46	Change to more efficient error injection in ecjpake_do_round() Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>	2022-08-31 10:49:18 +02:00
Neil Armstrong	db5b960a7e	Permit any psa_pake_input() step to fail when error injected in input Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>	2022-08-31 10:49:18 +02:00
Neil Armstrong	75673abef5	Only build ecjpake_do_round() is PSA_WANT_ALG_JPAKE is defined Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>	2022-08-31 10:49:18 +02:00
Neil Armstrong	8c2e8a6cda	Add ecjpake_rounds_inject tests to exercise error injection Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>	2022-08-31 10:49:18 +02:00

... 7 8 9 10 11 ...

5035 commits