yuzu-emu/mbedtls
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
22008 commits 1 branch 0 tags 94 MiB
Commit graph

22008 commits

This branch
This branch
All branches
Author SHA1 Message Date
Aditya Deshpande
bd2bfa92bd Add Changelog entry 
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
 2022-11-10 15:30:12 +00:00
ihsinme
d21ecd71c0 dh_genprime: Fix issue where the error code returned by mbedtls_mpi_write_file() is incorrectly reported on failure 
In 'dh_genprime.c', the following condition can be found inside an 'if' statement:

ret = mbedtls_mpi_write_file( "P = ", &P, 16, fout ) != 0

As the '!=' operator binds closer than the assignment operator ('='), the value assigned to 'ret' will be the boolean result of the comparison (0 or 1) instead of the status code returned by 'mbedtls_mpi_write_file'. This means that the above statement is actually equivalent to:

ret = ( mbedtls_mpi_write_file( "P = ", &P, 16, fout ) != 0 )

What we want instead is for the the status code to be assigned to 'ret'. If the value assigned is non-zero, it will be 'truthy' and the 'if' branch will be taken.

( ret = mbedtls_mpi_write_file( "P = ", &P, 16, fout ) )  != 0

This PR fixes the issue by explicitly specifying the precedence of operations with parentheses.

Signed-off-by: ihsinme <ihsinme@gmail.com>
 2022-11-10 12:58:15 +03:00
Gilles Peskine
42d75f2daf
Merge pull request #6013 from gstrauss/asn1-type-free 
Shared code to free x509 structs like mbedtls_x509_named_data
 2022-11-08 12:20:20 +01:00
Gilles Peskine
433f1f1809
Merge pull request #6456 from gabor-mezei-arm/6237_test_update_cond_assign_swap 
Update tests to use conditional assign and swap
 2022-11-08 12:15:07 +01:00
Dave Rodgman
ae2635df6f
Merge pull request #6306 from tom-cosgrove-arm/issue-6305-fix 
Return an error from mbedtls_ssl_handshake_step() if neither client nor server
 2022-11-08 10:54:17 +00:00
Glenn Strauss
2a64299648
Update tests/suites/test_suite_asn1parse.function 
Co-authored-by: Andrzej Kurek <andrzej.kurek@arm.com>
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com>
 2022-11-07 20:09:38 -05:00
Glenn Strauss
aa36c2a6f6
Update tests/suites/test_suite_asn1parse.function 
Co-authored-by: Andrzej Kurek <andrzej.kurek@arm.com>
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com>
 2022-11-07 20:08:54 -05:00
Glenn Strauss
82ba274c01 Deprecate mbedtls_asn1_free_named_data() 
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com>
 2022-11-07 15:42:44 -05:00
Gilles Peskine
faefe62013
Merge pull request #6390 from mpg/fix-ecjpake-psa-format 
Fix ecjpake PSA format
 2022-11-07 17:35:44 +01:00
Gilles Peskine
bf249accc7
Merge pull request #6498 from yuhaoth/pr/fix-session-resumption-fail-when-hostname-is-not-localhost 
BUG: Fix session resumption fail when hostname is not localhost
 2022-11-07 17:33:38 +01:00
Gilles Peskine
34c09469f3
Merge pull request #5396 from SiliconLabs/codegen_1.1 
Driver dispatch Codegen 1.1
 2022-11-07 15:27:41 +01:00
Gabor Mezei
a8cf998bc9
Let the allocated memory visible for the memory sanitizer 
Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2022-11-07 15:14:49 +01:00
Gabor Mezei
7ba7b3aded
Update tests to use mbedtls_test_read_mpi_core 
In conditional assign and swap tests use the mbedtls_test_read_mpi_core
function for reading MPIs.

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>
 2022-11-07 15:14:49 +01:00
Janos Follath
49e9fbd6bc
Merge pull request #6532 from yanesca/bignum_common_merge_slots 
Add merge slots to bignum_common.py
 2022-11-04 08:37:07 +00:00
Janos Follath
f8b3b72910 Add merge slots to bignum_common.py 
Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-03 14:46:18 +00:00
Janos Follath
4feb94a965
Merge pull request #6530 from yanesca/bignum_merge_scaffolding 
Bignum merge scaffolding
 2022-11-03 11:29:32 +00:00
Asfandyar Orakzai
9b656d3c80 removed stray whitespaces from change logs 
Signed-off-by: Asfandyar Orakzai <asfandyar.orakzai@silabs.com>
 2022-11-03 11:39:36 +01:00
Asfandyar Orakzai
65cd8a4a23 fixed formating issues in psa_crypto_code_gen_1_1.txt 
Signed-off-by: Asfandyar Orakzai <asfandyar.orakzai@silabs.com>
 2022-11-03 11:16:40 +01:00
Asfandyar Orakzai
4f63ac4358 fixed changelog formating 
Signed-off-by: Asfandyar Orakzai <asfandyar.orakzai@silabs.com>
 2022-11-03 10:18:05 +01:00
Janos Follath
d820ca5d07
Fix bignum test generator class names 
Co-authored-by: minosgalanakis <30719586+minosgalanakis@users.noreply.github.com>
Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-03 08:42:54 +00:00
Asfandyar Orakzai
ee2b637d03 Fixed change log issue 
Signed-off-by: Asfandyar Orakzai <asfandyar.orakzai@silabs.com>
 2022-11-02 21:50:27 +01:00
Janos Follath
c1a81bc998 Remove trailing new lines 
Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-02 17:33:11 +00:00
Janos Follath
9cf14cd6b0 Make pylint happy 
Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-02 17:28:39 +00:00
Janos Follath
6642cafae3 Fix merge separator position 
Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-02 17:28:39 +00:00
Janos Follath
be13652296 Use comments for merge separators in .data files 
We do have a comment syntax for .data files, there is no need for dummy
test cases.

Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-02 17:28:37 +00:00
Janos Follath
1be322a795 Add merge slots to raw and mod_raw test generation 
Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-02 17:27:36 +00:00
Janos Follath
b99b056f0a Add script for generating mod test cases 
This commit only adds the boilerplate, no actual tests are added.

Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-02 17:27:36 +00:00
Janos Follath
df8239b846 Add script for generating mod_raw test cases 
This commit only adds the boilerplate, no actual tests are added.

Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-02 17:27:36 +00:00
Janos Follath
5933f691a2 Add merge slots to Bignum files 
Legacy Bignum is excluded as it doesn't get regular extensions like new
ones.

Each slot uses comments of their respective filetype. Since .data files
don't have a syntax for comments, dummy test cases are used. (These test
cases will never be executed and no noise will be added to tests.)

Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-02 17:27:25 +00:00
Janos Follath
2a8bcf8c6f Add bignum merge scaffolding 
Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-02 17:25:48 +00:00
Janos Follath
7b96f52b39
Merge pull request #6450 from gilles-peskine-arm/bignum-core-fill_random 
Bignum core: fill_random
 2022-11-02 17:23:31 +00:00
Asfandyar Orakzai
9bd28dc1e1 Update changed log 
Signed-off-by: Asfandyar Orakzai <asfandyar.orakzai@silabs.com>
 2022-11-02 16:36:14 +01:00
Gilles Peskine
22cdd0ccd3 Update some internal comments 
The refactoring of fill_random had left some obsolete bits in comments.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-11-02 16:00:01 +01:00
Gilles Peskine
dd54324765 Increase iterations for some statistical tests 
I ran into a sequence where the assertion `stats[8] > 0` failed for the
range 1..272 with 100 iterations.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-11-02 16:00:01 +01:00
Gilles Peskine
009d195a56 Move mbedtls_mpi_core_fill_random to the proper .c file 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-11-02 16:00:01 +01:00
Gilles Peskine
5980f2bd36 Implement mbedtls_mpi_core_fill_random 
Turn mpi_fill_random_internal() into mbedtls_mpi_core_fill_random(). It
had basically the right code except for how X is passed to the function.

Write unit tests.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-11-02 15:59:36 +01:00
Gilles Peskine
909e03c52f Bignum core: fill_random: prototype 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-11-02 15:59:16 +01:00
Janos Follath
f1ed5815ba
Merge pull request #6512 from yanesca/extract_uint_table_lookup_core 
Implement mbedtls_mpi_core_ct_uint_table_lookup()
 2022-11-02 13:58:19 +00:00
Dave Rodgman
90c6836271
Merge pull request #6524 from daverodgman/fix-duplicate-header 
Remove duplicate function prototype
 2022-11-02 13:06:08 +00:00
Dave Rodgman
ea63f69303
Merge pull request #6514 from daverodgman/update_pr_template 
Update PR template
 2022-11-02 13:05:09 +00:00
Janos Follath
28f85e6683 Fix const time in mpi_core_ct_uint_table_lookup test 
Signed-off-by: Janos Follath <janos.follath@arm.com>
 2022-11-02 10:20:35 +00:00
Dave Rodgman
340846ec7e
Merge pull request #6515 from daverodgman/psalinks 
Update PSA links in README.md
 2022-11-02 10:02:19 +00:00
Dave Rodgman
0877dc8f55 Improve documentation for psa_crypto_cipher.h 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-11-02 09:29:50 +00:00
Dave Rodgman
1630447eed Move declaration of mbedtls_cipher_info_from_psa into psa_crypto_cipher.h 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-11-02 09:25:38 +00:00
Dave Rodgman
5f8dfb5393
Merge pull request #6521 from daverodgman/fix_ssl_zeroize 
Fix zeroization at NULL pointer
 2022-11-01 20:50:38 +00:00
Dave Rodgman
b256640d72 Improve list formatting 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-11-01 20:40:48 +00:00
Dave Rodgman
f3928fb3e0 Reinstate note about all PRs receiving review 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-11-01 20:39:04 +00:00
Dave Rodgman
ba864848e7 Remove duplicate function prototype 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-11-01 16:41:09 +00:00
Dave Rodgman
5875f5f96b Add Changelog 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-11-01 16:28:03 +00:00
Dave Rodgman
29b9b2b699 Fix zeroization at NULL pointer 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-11-01 16:08:14 +00:00