yuzu-emu/mbedtls
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
22910 commits 1 branch 0 tags 94 MiB
Commit graph

22910 commits

This branch
This branch
All branches
Author SHA1 Message Date
Manuel Pégourié-Gonnard
cc6e0a650f Fix missing initialisation of PSA Crypto 
This fixes the two failures in test_suite_x509parse when both
ECP_RESTARTABLE and USE_PSA_CRYPTO are enabled.

The failure happened because the operation is dispatched to PSA when
restart is disabled (max_ops == 0).

Previously it was correct for this test function not to initialize PSA,
because it depends on ECP_RESTARTABLE which used to conflict with
USE_PSA_CRYPTO, but that's no longer the case.

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2022-12-09 10:09:32 +01:00
Manuel Pégourié-Gonnard
79ae7eb4d1 Use deterministic ECDSA in PSA when we do in legacy 
This fixes the two failing cases in test_suite_pk when ECP_RESTARTABLE
and USE_PSA_CRYPTO are both enabled. The two failing cases where

    ECDSA restartable sign/verify: ECDSA, max_ops=0 (disabled)
    ECDSA restartable sign/verify: ECKEY, max_ops=0 (disabled)

associated with test function pk_sign_verify_restart(). The failure was
caused by the interaction of several things that are each reasonable on
their own:

1. The test function relies on ECDSA restartable, which is reasonable as it
allows making sure that the generated signature is correct with a simple
memcmp().
2. The implementation of pk_sign_restartable() has a shortcut to
dispatch to the sign function (as opposed to sign_restartable) when
restart is disabled (max_ops == 0).
3. When USE_PSA is enabled, the sign function dispatches to PSA, which
so far always used ECDSA (non-deterministic) even when the non-PSA
version would use deterministic ECDSA.

This could be fixed by changing any of those. I chose (3) because I
think it makes sense that when PK dispatches to PSA instead of legacy
this should not change which version of ECDSA is selected.

OTOH, I think it makes sense to keep (2), because that means more
opportunities to dispatch to PSA.

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2022-12-09 10:07:19 +01:00
Manuel Pégourié-Gonnard
1a100b69a4
Merge pull request #6705 from davidhorstmann-arm/code-style-script-non-corrected 
Add code style correction script
 2022-12-09 09:41:14 +01:00
Gilles Peskine
0ab6c8acb7 Remove obsolete target covtest 
This target dates back from before basic-build-test.sh existed. Refer to
that script instead.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-12-08 22:18:31 +01:00
Valerio Setti
eb3f788b03 tls: pake: do not destroy password key in TLS 
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
 2022-12-08 18:42:58 +01:00
David Horstmann
c6b604e842 Reindent line continuations for pylint 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 17:38:27 +00:00
David Horstmann
ae93a3f984 Fixup: Config file name in code style script 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 17:03:01 +00:00
Valerio Setti
2a3ffb4203 test: pake: add test for opaque password key 
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
 2022-12-08 16:27:46 +01:00
David Horstmann
0ebc12ea41 Add spaces around '+' 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 15:05:53 +00:00
David Horstmann
d021032d51 Remove legacy comments from config 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 15:05:53 +00:00
David Horstmann
be88e80e3d Improvements to the top of the code style config 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 15:05:53 +00:00
David Horstmann
0e648f041c Rename Uncrustify configuration 
Make it more obvious that this is an Uncrustify configuration file.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 15:05:53 +00:00
David Horstmann
190041d2b1 Explain that the script is only for the future 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 15:05:53 +00:00
David Horstmann
b488ca3497 Remove ChangeLog entry, style is not yet official 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 15:05:53 +00:00
David Horstmann
2cf779ceff Use constant for supported Uncrustify version 
Define and report the supported Uncrustify version (and remove extra
newlines from version output).

Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 15:05:53 +00:00
David Horstmann
9711f4eeb4 Fix typo in code style script 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 15:05:53 +00:00
David Horstmann
ca13c4f59f Use helper function for error printing 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 15:05:53 +00:00
David Horstmann
b7dab41315 Miscellaneous improvements to code style script 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-08 15:05:53 +00:00
Dave Rodgman
69591e9207 Assemble changelog 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-12-08 14:59:54 +00:00
Dave Rodgman
48223bc19e Bump version to 3.3.0. No changes to .so versions. 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-12-08 14:43:19 +00:00
Dave Rodgman
a5b2c52885 Merge remote-tracking branch 'restricted/development-restricted' into mbedtls-3.3.0rc0-pr 2022-12-08 14:10:59 +00:00
Dave Rodgman
a6ca882943
Merge pull request #6752 from daverodgman/arm-build-changelog 
Add Changelog for Arm compile fix
 2022-12-08 14:09:47 +00:00
Dave Rodgman
b74aa5a224 Add Changelog for Arm compile fix 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-12-08 13:43:08 +00:00
Zachary Fleckenstein
73defe4da0 Fix typo in library/entropy.c 
Signed-off-by: Zachary Fleckenstein <ZachFleck42@Gmail.com>
 2022-12-08 07:28:29 -05:00
Tom Cosgrove
6129268fee Bignum: Implement mbedtls_mpi_mod_raw_inv_prime() and tests 
Fixes #6023.

Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
 2022-12-08 09:44:10 +00:00
Tom Cosgrove
a7f0d7b029 mbedtls_mpi_core_exp_mod() ouuput may alias input A 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
 2022-12-08 08:46:28 +00:00
Gilles Peskine
3e5d56e7d4 Remove duplicated test cases 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-12-07 22:57:54 +01:00
Valerio Setti
ae7fe7ee53 tls: pake: avoid useless psa_pake_abort in setting opaque password 
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
 2022-12-07 17:36:59 +01:00
Valerio Setti
70d1fa538a tls: pake: fix missing return values check 
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
 2022-12-07 16:20:27 +01:00
Valerio Setti
f11e05a413 test: psa: minor improvements to test 
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
 2022-12-07 16:02:45 +01:00
Valerio Setti
d5fa0bfb85 test: pake: check psa key validity before destroying it 
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
 2022-12-07 16:02:42 +01:00
Valerio Setti
c689ed8633 tls: pake: minor adjustments 
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
 2022-12-07 14:40:38 +01:00
Dave Rodgman
90af1a10ab
Merge pull request #6734 from daverodgman/fix_test_dep_spelling 
Fix spelling of test dependency
 2022-12-07 09:06:29 +00:00
Ronald Cron
fbba0e9d75
Merge pull request #6537 from yuhaoth/pr/tls13-refactor-early-data-configuration-interface 
TLS 1.3: Refactor early data configuration interface.
 2022-12-07 09:42:12 +01:00
Janos Follath
d45924d862
Merge pull request #6733 from tom-cosgrove-arm/issue-6293-mod_exp-memory 
Have mbedtls_mpi_core_exp_mod() take a temporary instead of allocating memory
 2022-12-07 08:32:31 +00:00
Janos Follath
1d26d976e8
Merge pull request #6731 from tom-cosgrove-arm/issue-6293-mod_exp 
Require input to mbedtls_mpi_core_exp_mod() to already be in Montgomery form
 2022-12-07 08:31:49 +00:00
Gilles Peskine
8781dd0e61 Fix overly large allocations of MPIs 
The second argument of ASSERT_ALLOC is a number of array elements, not a
number of bytes.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-12-06 23:05:06 +01:00
Gilles Peskine
de09ddd64e Move tests of random-in-range functions to their own suite 
The random-in-nrange test code has auxiliary functions that are common to all
the interfaces (core, mod_raw (upcoming), mod (upcoming), legacy), and does
some differential testing to check that all the layers consume the RNG in
the saame way. Test them all in the same test suite.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2022-12-06 22:50:11 +01:00
Dave Rodgman
1fe45295d7
Merge pull request #6685 from gilles-peskine-arm/valgrind-cf-skip-tests 
Rationalize Valgrind tests
 2022-12-06 18:39:32 +00:00
David Horstmann
92b5ac1a47 Add all.sh component to test with code style 
Run the main test suites after running code style correction to check
that code style correction does not break these tests.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-06 17:44:30 +00:00
Dave Rodgman
556e8a3219 Fix additional mis-spelling 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-12-06 16:31:25 +00:00
David Horstmann
6e5bc03311 Add ChangeLog entry for code style script 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-06 16:09:17 +00:00
David Horstmann
1b84781184 Disable code style correction in check_config.h 
Code style correction currently messes up check_names.py

Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-06 16:09:17 +00:00
David Horstmann
fa928f1c44 Add script to run Uncrustify 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-06 15:04:37 +00:00
Dave Rodgman
92011eef34
Merge pull request #6717 from tom-cosgrove-arm/fix-typos-2212 
Fix typos prior to release
 2022-12-06 15:00:34 +00:00
David Horstmann
e6cb118d56 Add configuration file for Uncrustify 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
 2022-12-06 14:46:29 +00:00
Dave Rodgman
614688711d Fix spelling of test dependency 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
 2022-12-06 14:44:08 +00:00
Tom Cosgrove
0a0ddedfb7 Have mbedtls_mpi_core_exp_mod() take a temporary instead of allocating memory 
Last PR needed for #6293

Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
 2022-12-06 14:37:18 +00:00
Dave Rodgman
98be95563d
Merge pull request #6689 from gilles-peskine-arm/changelog-20221129-pre-3.3 
Changelog improvements for 3.3
 2022-12-06 13:37:24 +00:00
Tom Cosgrove
21d459d26a Add type annotations 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
 2022-12-06 12:36:00 +00:00