suyu
/
suyu
153
183
Fork 26
Code Issues 76 Pull Requests 4 Actions 6 Packages Projects Releases 2 Wiki Activity

Comment out unimplemented check #96

Closed
Exverge wants to merge 1 commits from textureimage-void into dev
pull from: textureimage-void
merge into: suyu:dev
Conversation 1 Commits 1 Files Changed 1 +10 -4
Exverge commented 2024-03-31 00:41:43 +01:00
Member
Copy Link

In my testing on macOS, MK8 sometimes crashed at this function, giving a void type instead of u32.
I've temporarily commented this out until (if) this is implemented and added a check for if it is implemented

In my testing on macOS, MK8 sometimes crashed at this function, giving a void type instead of u32. I've temporarily commented this out until (if) this is implemented and added a check for if it is implemented
Exverge added the
bug
 label 2024-03-31 00:41:43 +01:00
Exverge added 1 commit 2024-03-31 00:41:43 +01:00
codespell / Check for spelling errors (push) Successful in 9s Details
codespell / Check for spelling errors (pull_request) Successful in 10s Details
suyu-ci / Check REUSE Specification (pull_request) Successful in 9s Details
suyu verify / Verify Format (pull_request) Failing after 2m19s Details
suyu verify / test build (linux-fresh, clang) (pull_request) Has been skipped Details
suyu verify / test build (linux-fresh, linux) (pull_request) Has been skipped Details
suyu verify / android (pull_request) Has been skipped Details
62f7da6c5d
Comment out unimplemented check 
In my testing on macOS, MK8 sometimes crashed at this function, giving a void type instead of u32.
I've temporarily commented this out until (if) this is implemented and added a check for if it is implemented
Exverge requested review from AMA25 2024-03-31 00:42:03 +01:00
Exverge force-pushed textureimage-void from 62f7da6c5d to b39539ad4a 2024-03-31 00:48:09 +01:00 Compare
Exverge commented 2024-03-31 00:59:30 +01:00
Author
Member
Copy Link

giving a void type instead of u32.

Whatever's causing this I believe may be the same issue with color attachment type-mismatching

> giving a void type instead of u32. Whatever's causing this I believe may be the same issue with color attachment type-mismatching
Exverge changed title from Comment out unimplemented check to WIP: Comment out unimplemented check 2024-03-31 01:01:56 +01:00
Exverge force-pushed textureimage-void from b39539ad4a to 5979bc15b2 2024-03-31 01:04:28 +01:00 Compare
Exverge changed title from WIP: Comment out unimplemented check to Comment out unimplemented check 2024-03-31 01:04:32 +01:00
Exverge added the
Needs Rebase
Needs Approvals
 labels 2024-04-01 01:27:51 +02:00
Exverge force-pushed textureimage-void from 5979bc15b2 to 9f5709d73a 2024-04-01 01:48:05 +02:00 Compare
Exverge removed the
Needs Rebase
 label 2024-04-01 01:48:20 +02:00
Cedr0u approved these changes 2024-04-01 19:27:40 +02:00
Exverge force-pushed textureimage-void from 9f5709d73a to 89468f90a2 2024-04-02 02:55:48 +02:00 Compare
Exverge closed this pull request 2024-04-10 01:31:23 +02:00
All checks were successful
codespell / Check for spelling errors (push) Successful in 11s
Details
codespell / Check for spelling errors (pull_request) Successful in 10s
Details
suyu-ci / Check REUSE Specification (pull_request) Successful in 10s
Details
suyu verify / Verify Format (pull_request) Successful in 2m23s
Details
suyu verify / test build (linux-fresh, clang) (pull_request) Successful in 10m19s
Details
suyu verify / android (pull_request) Successful in 16m59s
Details
suyu verify / test build (linux-fresh, linux) (pull_request) Successful in 18m56s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
AMA25
Cedr0u
Labels
Clear labels   
CI

   
Low Priority

   
Needs Approvals

   
Needs Rebase

   
android

Relating to the android build

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
translations

Relating to strings for different langauges

  
wontfix

This won't be fixed

No Label
CI
Low Priority
Needs Approvals
Needs Rebase
android
bug
duplicate
enhancement
help wanted
invalid
question
translations
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: suyu/suyu#96
No description provided.
Delete Branch "textureimage-void"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?