suyu
/
suyu
153
183
Fork 26
Code Issues 76 Pull Requests 6 Actions Packages Projects Releases 2 Wiki Activity

Revert the changes done by Paulo Alfaiate (palfiaiate) #65

Merged
TheDoctor merged 10 commits from BoomMicrophone/undo-deletions:dev into dev 2024-04-10 19:56:34 +02:00
Conversation 6 Commits 10 Files Changed 5 +269 -4
BoomMicrophone commented 2024-03-25 21:22:50 +01:00
Contributor
Copy Link

This has been done at the request of a member of the team. This restores the RomFS dumping buttons.

Please make sure it works before merging. I still have to get the nix shell and flake up so I can actually do the testing myself

The merge also includes making the README more up to date.

This has been done at the request of a member of the team. This restores the RomFS dumping buttons. **Please make sure it works before merging. I still have to get the nix shell and flake up so I can actually do the testing myself** The merge also includes making the README more up to date.
BoomMicrophone added 2 commits 2024-03-25 21:22:51 +01:00
suyu verify / Verify Format (pull_request) Failing after 8s Details
codespell / Check for spelling errors (pull_request) Successful in 11s Details
suyu verify / test build (linux-fresh, clang) (pull_request) Has been skipped Details
suyu verify / test build (linux-fresh, linux) (pull_request) Has been skipped Details
suyu verify / android (pull_request) Has been skipped Details
suyu-ci / Check REUSE Specification (pull_request) Successful in 10s Details
eba28b0df3
All relevant changes in commit 51862e862d have been
BoomMicrophone commented 2024-03-25 21:24:52 +01:00
Author
Contributor
Copy Link

Still in progress? Add WIP: prefix

Why wasn't it before I uploaded the PR? Now the title is unnecessarily long

> Still in progress? Add WIP: prefix Why wasn't it before I uploaded the PR? Now the title is unnecessarily long
BoomMicrophone added 1 commit 2024-03-26 15:57:42 +01:00
codespell / Check for spelling errors (pull_request) Successful in 11s Details
suyu-ci / Check REUSE Specification (pull_request) Successful in 23s Details
suyu verify / Verify Format (pull_request) Failing after 1m32s Details
suyu verify / test build (linux-fresh, clang) (pull_request) Has been skipped Details
suyu verify / test build (linux-fresh, linux) (pull_request) Has been skipped Details
suyu verify / android (pull_request) Has been skipped Details
caa1fb094c nullglob globstar gobble up those nuts 
shoutout to gpg for not working

Signed-off-by: BoomMicrophone <boommicrophone@noreply.localhost>
BoomMicrophone added 1 commit 2024-03-26 16:10:36 +01:00
codespell / Check for spelling errors (pull_request) Successful in 11s Details
suyu-ci / Check REUSE Specification (pull_request) Successful in 11s Details
suyu verify / Verify Format (pull_request) Successful in 2m49s Details
suyu verify / test build (linux-fresh, clang) (pull_request) Failing after 6m44s Details
suyu verify / test build (linux-fresh, linux) (pull_request) Failing after 27m46s Details
suyu verify / android (pull_request) Successful in 32m24s Details
b59aaf14e9 Woah guys this is so compliant! 
Signed-off-by: BoomMicrophone <boommicrophone@noreply.localhost>
BoomMicrophone added 1 commit 2024-03-26 16:34:25 +01:00
codespell / Check for spelling errors (pull_request) Successful in 12s Details
suyu-ci / Check REUSE Specification (pull_request) Successful in 10s Details
suyu verify / Verify Format (pull_request) Successful in 4m15s Details
suyu verify / test build (linux-fresh, linux) (pull_request) Successful in 17m15s Details
suyu verify / test build (linux-fresh, clang) (pull_request) Successful in 28m21s Details
suyu verify / android (pull_request) Successful in 33m7s Details
affee8c522 fix epic fail 
(I am relying on actions to do the compiling for me until i get nix)
BoomMicrophone changed title from WIP <- (Don't want to accidentally have this merged without unit testing) Revert the changes done by Paulo Alfaiate (palfiaiate) to Revert the changes done by Paulo Alfaiate (palfiaiate) 2024-03-26 18:13:02 +01:00
BoomMicrophone added 1 commit 2024-03-28 22:43:22 +01:00
codespell / Check for spelling errors (pull_request) Successful in 13s Details
suyu-ci / Check REUSE Specification (pull_request) Successful in 12s Details
suyu verify / Verify Format (pull_request) Successful in 2m16s Details
suyu verify / android (pull_request) Successful in 17m36s Details
suyu verify / test build (linux-fresh, clang) (pull_request) Successful in 18m2s Details
suyu verify / test build (linux-fresh, linux) (pull_request) Successful in 30m4s Details
9c2f3bff3f Merge branch 'dev' into dev
BoomMicrophone commented 2024-03-28 22:43:40 +01:00
Author
Contributor
Copy Link

uhh guys can you like help?

uhh guys can you like help?
Exverge requested changes 2024-03-28 23:03:27 +01:00
src/common/settings.h Outdated
@ -2,6 +2,7 @@
// SPDX-License-Identifier: GPL-2.0-or-later
// Modified by palfaiate on <2024/03/07>
// Reverted palfaiate's changes on <2024/03/25> -Nine-Ball
Exverge commented 2024-03-28 22:56:48 +01:00
Member
Copy Link

Just remove the comment on all the files, these type of comments haven't been used by anyone else anyway

Just remove the comment on all the files, these type of comments haven't been used by anyone else anyway
BoomMicrophone marked this conversation as resolved
src/suyu/main.cpp
@ -58,0 +62,4 @@
return vfs->CreateDirectory(path, mode);
}
// Overloaded function, also removed by palafiate
Exverge commented 2024-03-28 23:02:51 +01:00
Member
Copy Link

Same here

Same here
BoomMicrophone commented 2024-03-31 17:52:04 +02:00
Author
Contributor
Copy Link

On it, will also remove palafiate's comments

On it, will also remove palafiate's comments
👍 1
Exverge marked this conversation as resolved
Exverge commented 2024-03-29 23:02:26 +01:00
Member
Copy Link

The merge also includes making the README more up to date.

I've cherry-picked this change so as to disassociate an otherwise unrelated change with this merge.

> The merge also includes making the README more up to date. I've cherry-picked this change so as to disassociate an otherwise unrelated change with this merge.
BoomMicrophone added 1 commit 2024-03-31 17:55:41 +02:00
codespell / Check for spelling errors (pull_request) Successful in 11s Details
suyu-ci / Check REUSE Specification (pull_request) Successful in 10s Details
suyu verify / Verify Format (pull_request) Successful in 1m26s Details
suyu verify / test build (linux-fresh, clang) (pull_request) Successful in 11m20s Details
suyu verify / android (pull_request) Successful in 28m27s Details
suyu verify / test build (linux-fresh, linux) (pull_request) Successful in 31m44s Details
dcd2890af6 Merge branch 'dev' into dev
BoomMicrophone added 1 commit 2024-03-31 21:41:45 +02:00
codespell / Check for spelling errors (pull_request) Successful in 11s Details
suyu-ci / Check REUSE Specification (pull_request) Successful in 10s Details
suyu verify / Verify Format (pull_request) Successful in 2m30s Details
suyu verify / test build (linux-fresh, clang) (pull_request) Successful in 14m44s Details
suyu verify / test build (linux-fresh, linux) (pull_request) Successful in 19m55s Details
suyu verify / android (pull_request) Successful in 34m39s Details
db9035cc35 remove comment 
gpg timeout so i gotta coooooommit :D
BoomMicrophone added 1 commit 2024-03-31 21:42:14 +02:00
suyu-ci / Check REUSE Specification (pull_request) Successful in 10s Details
codespell / Check for spelling errors (pull_request) Successful in 18s Details
suyu verify / Verify Format (pull_request) Successful in 1m24s Details
suyu verify / test build (linux-fresh, clang) (pull_request) Successful in 17m26s Details
suyu verify / test build (linux-fresh, linux) (pull_request) Successful in 38m20s Details
suyu verify / android (pull_request) Successful in 42m29s Details
d09ab05c1b remove comment 
gotta coooooommit :D
BoomMicrophone commented 2024-03-31 21:42:27 +02:00
Author
Contributor
Copy Link

Done, gpg sperged out again

Done, gpg sperged out again
BoomMicrophone added 1 commit 2024-04-01 15:10:00 +02:00
codespell / Check for spelling errors (pull_request) Successful in 12s Details
suyu-ci / Check REUSE Specification (pull_request) Successful in 11s Details
suyu verify / Verify Format (pull_request) Successful in 2m37s Details
suyu verify / android (pull_request) Successful in 15m57s Details
suyu verify / test build (linux-fresh, clang) (pull_request) Successful in 17m47s Details
suyu verify / test build (linux-fresh, linux) (pull_request) Successful in 28m42s Details
5a92429b8c Merge branch 'dev' into dev
BoomMicrophone commented 2024-04-01 15:10:22 +02:00
Author
Contributor
Copy Link

hey guys can you pr when you can after the tests are done

hey guys can you pr when you can after the tests are done
Exverge requested changes 2024-04-01 23:40:18 +02:00
Exverge left a comment
Member
Copy Link

Other than the comments looks good

Other than the comments looks good
src/suyu/game_list.cpp
@ -2,6 +2,7 @@
// SPDX-License-Identifier: GPL-2.0-or-later
// Modified by palfaiate on <2024/03/07>
// Reverted palfaiate's changes on <2024/03/25> -Nine-Ball
Exverge commented 2024-04-01 23:38:19 +02:00
Member
Copy Link

Remove both comments

Remove both comments
Exverge marked this conversation as resolved
src/suyu/game_list.h
@ -2,6 +2,7 @@
// SPDX-License-Identifier: GPL-2.0-or-later
// Modified by palfaiate on <2024/03/07>
// Reverted palfaiate's changes on <2024/03/25> -Nine-Ball
Exverge commented 2024-04-01 23:38:29 +02:00
Member
Copy Link

same here

same here
Exverge marked this conversation as resolved
src/suyu/main.cpp
@ -58,0 +59,4 @@
return vfs->CreateDirectory(path, mode);
}
// Overloaded function, also removed by palafiate
Exverge commented 2024-04-01 23:39:44 +02:00
Member
Copy Link

and here

and here
Exverge marked this conversation as resolved
Exverge requested review from Crimson-Hawk 2024-04-02 03:46:10 +02:00
Exverge requested review from TheDoctor 2024-04-09 02:37:04 +02:00
Exverge requested review from nullequal 2024-04-09 02:37:04 +02:00
Ghost commented 2024-04-09 10:53:02 +02:00
First-time contributor
Copy Link

LGTM.

LGTM.
Ryzendew approved these changes 2024-04-09 17:38:48 +02:00
Ryzendew left a comment
First-time contributor
Copy Link

Looks good and works good

Looks good and works good
TheDoctor merged commit 0de49070e4 into dev 2024-04-10 19:56:34 +02:00
TheDoctor referenced this issue from a commit 2024-04-10 19:56:35 +02:00
Merge
Sign in to join this conversation.
Reviewers
No reviewers
Exverge
Crimson-Hawk
TheDoctor
nullequal
Ryzendew
Labels
Clear labels   
CI

   
Low Priority

   
Needs Approvals

   
Needs Rebase

   
android

Relating to the android build

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
translations

Relating to strings for different langauges

  
wontfix

This won't be fixed

No Label
CI
Low Priority
Needs Approvals
Needs Rebase
android
bug
duplicate
enhancement
help wanted
invalid
question
translations
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: suyu/suyu#65
No description provided.
Delete Branch "BoomMicrophone/undo-deletions:dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?