suyu
/
suyu
153
183
Fork 26
Code Issues 76 Pull Requests 4 Actions 6 Packages Projects Releases 2 Wiki Activity

Using reserve() for optimization inserts, marked unused pair items and minor code refactor #142

Open
GermanAizek wants to merge 1 commits from GermanAizek/suyu:reserve-refactor into dev
pull from: GermanAizek/suyu:reserve-refactor
merge into: suyu:dev
Conversation 1 Commits 1 Files Changed 27 +43 -32
GermanAizek commented 2024-04-12 16:30:31 +02:00
First-time contributor
Copy Link

@administrator,
I think it will be useful for better optimization by compiler. Compilers like strict definitions and keywords.

@administrator, I think it will be useful for better optimization by compiler. Compilers like strict definitions and keywords.
GermanAizek added 1 commit 2024-04-12 16:30:32 +02:00
suyu verify / Verify Format (pull_request) Successful in 1m29s Details
suyu verify / test build (linux-fresh, linux) (pull_request) Successful in 18m19s Details
codespell / Check for spelling errors (pull_request) Has been cancelled Details
suyu-ci / Check REUSE Specification (pull_request) Has been cancelled Details
suyu verify / test build (linux-fresh, clang) (pull_request) Has been cancelled Details
suyu verify / android (pull_request) Has been cancelled Details
8fb20ebbae Using reserve() for optimization inserts, marked unused pair items and minor code refactor
chaphidoesstuff requested review from Crimson-Hawk 2024-04-18 19:05:48 +02:00
chaphidoesstuff added the
Needs Approvals
 label 2024-04-18 19:05:59 +02:00
servantofTestator commented 2024-04-18 22:35:17 +02:00
First-time contributor
Copy Link

I tested this branch and it compiles under linux with qt6 and qt5 using clang and gcc. I haven't noticed a huge performance difference. Making all those unique names into a user defined literal should indeed help the compiler. Makes it a little harder to read for someone with no familiarity with the codebase though.

I tested this branch and it compiles under linux with qt6 and qt5 using clang and gcc. I haven't noticed a huge performance difference. Making all those unique names into a user defined literal should indeed help the compiler. Makes it a little harder to read for someone with no familiarity with the codebase though.
Crimson-Hawk force-pushed reserve-refactor from 8fb20ebbae to a29e338273 2024-04-19 03:33:05 +02:00 Compare
Some checks failed
suyu-ci / Check REUSE Specification (pull_request) Successful in 13s
Details
codespell / Check for spelling errors (pull_request) Successful in 16s
Details
suyu verify / Verify Format (pull_request) Successful in 1m43s
Details
suyu verify / test build (linux-fresh, clang) (pull_request) Failing after 9m59s
Details
suyu verify / android (pull_request) Failing after 12m28s
Details
suyu verify / test build (linux-mingw, windows) (pull_request) Successful in 14m3s
Details
suyu verify / test build (linux-fresh, linux) (pull_request) Successful in 19m27s
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
Crimson-Hawk
Labels
Clear labels   
CI

   
Low Priority

   
Needs Approvals

   
Needs Rebase

   
android

Relating to the android build

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
translations

Relating to strings for different langauges

  
wontfix

This won't be fixed

No Label
CI
Low Priority
Needs Approvals
Needs Rebase
android
bug
duplicate
enhancement
help wanted
invalid
question
translations
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: suyu/suyu#142
No description provided.
Delete Branch "GermanAizek/suyu:reserve-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?