suyu/dynarmic
28
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity

asimd_three_same: Ignore Q=1 for VPADD (floating-point)

Browse source
This commit is contained in:
MerryMage 2020-06-27 22:30:26 +01:00
parent 896cb46c89
commit 3eed024caf
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/frontend/A32/translate/impl/asimd_three_regs.cpp
View file

@ -710,9 +710,11 @@ bool ArmTranslatorVisitor::asimd_VSUB_float(bool D, bool sz, size_t Vn, size_t V
}
bool ArmTranslatorVisitor::asimd_VPADD_float(bool D, bool sz, size_t Vn, size_t Vd, bool N, bool Q, bool M, size_t Vm) {
return FloatingPointInstruction(*this, D, sz, Vn, Vd, N, Q, M, Vm, [this, Q](const auto&, const auto& reg_n, const auto& reg_m) {
return Q ? ir.FPVectorPairedAdd(32, reg_n, reg_m, false)
: ir.FPVectorPairedAddLower(32, reg_n, reg_m, false);
if (Q) {
return UndefinedInstruction();
}
return FloatingPointInstruction(*this, D, sz, Vn, Vd, N, Q, M, Vm, [this](const auto&, const auto& reg_n, const auto& reg_m) {
return ir.FPVectorPairedAddLower(32, reg_n, reg_m, false);
});
}

2
tests/A32/fuzz_arm.cpp
View file

@ -115,8 +115,6 @@ u32 GenRandomInst(u32 pc, bool is_last_inst) {
"arm_UDF",
// FPSCR is inaccurate
"vfp_VMRS",
// Unimplemented in Unicorn
"asimd_VPADD_float",
// Incorrect Unicorn implementations
"asimd_VRECPS", // Unicorn does not fuse the multiply and subtraction, resulting in being off by 1ULP.
"asimd_VRSQRTS", // Unicorn does not fuse the multiply and subtraction, resulting in being off by 1ULP.