suyu/breakpad
26
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Mac dump_syms: delete unused WriteSymbolFile

Browse source 
Bug: None
Change-Id: I5aec8c07a01ee180c817fa79db39f9c2eb933e37
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4004598
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Leonard Grey 2022-11-03 15:51:29 -04:00
parent 387a002c89
commit 6b7e8a80ba
2 changed files with 3 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/common/mac/dump_syms.cc
View file

@ -678,18 +678,6 @@ bool DumpSymbols::ReadSymbolData(Module** out_module) {
return true;
}
bool DumpSymbols::WriteSymbolFile(std::ostream& stream) {
Module* module = NULL;
if (ReadSymbolData(&module) && module) {
bool res = module->Write(stream, symbol_data_);
delete module;
return res;
}
return false;
}
// Read the selected object file's debugging information, and write out the
// header only to |stream|. Return true on success; if an error occurs, report
// it and return false.

11
src/common/mac/dump_syms.h
View file

@ -117,19 +117,14 @@ class DumpSymbols {
return NULL;
}
// Read the selected object file's debugging information, and write it out to
// |stream|. Return true on success; if an error occurs, report it and
// return false.
bool WriteSymbolFile(std::ostream& stream);
// Read the selected object file's debugging information, and write out the
// header only to |stream|. Return true on success; if an error occurs, report
// it and return false.
bool WriteSymbolFileHeader(std::ostream& stream);
// As above, but simply return the debugging information in module
// instead of writing it to a stream. The caller owns the resulting
// module object and must delete it when finished.
// Read the selected object file's debugging information and store it in
// `module`. The caller owns the resulting module object and must delete
// it when finished.
bool ReadSymbolData(Module** module);
// Return an identifier string for the file this DumpSymbols is dumping.