From 6b7e8a80ba8bb38f3522f5017d9226d5566f67ed Mon Sep 17 00:00:00 2001 From: Leonard Grey Date: Thu, 3 Nov 2022 15:51:29 -0400 Subject: [PATCH] Mac dump_syms: delete unused WriteSymbolFile Bug: None Change-Id: I5aec8c07a01ee180c817fa79db39f9c2eb933e37 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4004598 Reviewed-by: Mark Mentovai --- src/common/mac/dump_syms.cc | 12 ------------ src/common/mac/dump_syms.h | 11 +++-------- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/src/common/mac/dump_syms.cc b/src/common/mac/dump_syms.cc index 1f830312..661cc89c 100644 --- a/src/common/mac/dump_syms.cc +++ b/src/common/mac/dump_syms.cc @@ -678,18 +678,6 @@ bool DumpSymbols::ReadSymbolData(Module** out_module) { return true; } -bool DumpSymbols::WriteSymbolFile(std::ostream& stream) { - Module* module = NULL; - - if (ReadSymbolData(&module) && module) { - bool res = module->Write(stream, symbol_data_); - delete module; - return res; - } - - return false; -} - // Read the selected object file's debugging information, and write out the // header only to |stream|. Return true on success; if an error occurs, report // it and return false. diff --git a/src/common/mac/dump_syms.h b/src/common/mac/dump_syms.h index 97632ce0..c2e1b40b 100644 --- a/src/common/mac/dump_syms.h +++ b/src/common/mac/dump_syms.h @@ -117,19 +117,14 @@ class DumpSymbols { return NULL; } - // Read the selected object file's debugging information, and write it out to - // |stream|. Return true on success; if an error occurs, report it and - // return false. - bool WriteSymbolFile(std::ostream& stream); - // Read the selected object file's debugging information, and write out the // header only to |stream|. Return true on success; if an error occurs, report // it and return false. bool WriteSymbolFileHeader(std::ostream& stream); - // As above, but simply return the debugging information in module - // instead of writing it to a stream. The caller owns the resulting - // module object and must delete it when finished. + // Read the selected object file's debugging information and store it in + // `module`. The caller owns the resulting module object and must delete + // it when finished. bool ReadSymbolData(Module** module); // Return an identifier string for the file this DumpSymbols is dumping.