Gilles Peskine
27a046058a
Unify the grammar of descriptions
...
Use "program: does this and then does that" throughout.
2018-08-06 20:09:16 +02:00
Mohammad Azim Khan
58e9c1833b
Fix Wformat-overflow warning in ssl_mail_client.c
...
sprintf( (char *) buf, "%s\r\n", base );
Above code generates Wformat-overflow warning since both buf and base
are of same size. buf should be sizeof( base ) + characters added in
the format. In this case format 2 bytes for "\r\n".
2018-08-06 12:02:02 +01:00
Mohammad Azim Khan
5cb7017077
Less obscure test suites template
2018-08-06 11:42:56 +01:00
Mohammad Azim Khan
d2d0112ca8
Style fixes
2018-08-06 11:42:56 +01:00
Mohammad Azim Khan
440d8737c6
Fix macro validation regex
2018-08-06 11:42:56 +01:00
Mohammad Azim Khan
ee6529eb83
Add generate_test_code.py unit tests in all.sh
2018-08-06 11:42:56 +01:00
Mohammad Azim Khan
21798105f6
Pylint tests in all.sh
2018-08-06 11:42:56 +01:00
Mohammad Azim Khan
539aa06f64
Fix Python 2 & 3 compatibility in test_generate_test_code.py
2018-08-06 11:42:56 +01:00
Mohammad Azim Khan
32cbcdac8f
Fix Pylint errors in Python scripts
2018-08-06 11:42:56 +01:00
Azim Khan
630281349e
Replaced escaped_split() logic with regex
2018-08-06 11:42:56 +01:00
Azim Khan
fcdf685302
Make test function parsing robust
...
This commit enhances parsing of the test function in generate_test_code.py for
cases where return type and function name are on separate lines.
2018-08-06 11:42:56 +01:00
Azim Khan
4084ec7ae5
Fixed unit tests in test_generate_test_code.py
2018-08-06 11:42:56 +01:00
Azim Khan
8d686bfdb1
Incorporated code revoew comments.
2018-08-06 11:42:56 +01:00
Azim Khan
b31aa44e16
Fix style errors reported by pylint
2018-08-06 11:42:56 +01:00
Azim Khan
aee05bbe70
Add test suite framework summary
2018-08-06 11:42:56 +01:00
Azim Khan
63ab501aa7
Fix generate_test_code.py argument --helpers-file in CMakeLists.txt
2018-08-06 11:42:56 +01:00
Azim Khan
27a35e7712
Wildcard possible targets and document
...
Test application names and function file names can be constructed
based on the followed naming convention. This commit documents the
naming convention and removes explicit listing of the test
executables and the lookup table for finding .function file.
2018-08-06 11:42:56 +01:00
Azim Khan
5fcca46a3a
Rename HexParam_t -> data_t for consistent coding style
2018-08-06 11:42:06 +01:00
Azim Khan
62a5d7d65a
Document status/error codes in helper.function
2018-08-06 11:42:06 +01:00
Azim Khan
951a2c8898
Improve documentation in mbedtls_test.py
2018-08-06 11:42:06 +01:00
Azim Khan
e3b26af7c0
Improve documentation in generate_test_code.py
2018-08-06 11:42:06 +01:00
Azim Khan
b98e6eec58
Replace asserts with exceptions in mbedtls_test.py
2018-08-06 11:42:06 +01:00
Azim Khan
040b6a2281
Wrap code to 79 character limit
2018-08-06 11:42:06 +01:00
Azim Khan
936ea9302a
Strip whitespaces added by decode() function
2018-08-06 11:42:06 +01:00
Mohammad Azim Khan
00c4b090c1
Change intermediate data file extension to .datax
2018-08-06 11:42:06 +01:00
Mohammad Azim Khan
ff560f2239
Rename makefile target gen-embedded-test - generate-target-tests
2018-08-06 11:42:06 +01:00
Mohammad Azim Khan
cfd834274b
Use integer instead of string as test result
2018-08-06 11:42:06 +01:00
Mohammad Azim Khan
53faf5c964
Widen the test app columns
2018-08-06 11:42:06 +01:00
Mohammad Azim Khan
8a3628fc86
Set PYTHON using ?= syntax
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
8f6e8cfcc7
Print line number with data file error
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
3b06f226e9
Replace asserts with exceptions in generate_test_code.py
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
c3521dfdd6
Fix generate_test_code.py unit tests
2018-08-06 11:40:58 +01:00
Azim Khan
0fa3504a77
Add missing MSVC typedefs
2018-08-06 11:40:58 +01:00
Gilles Peskine
667f7f8369
Fix generation of #line directives in Python 2
...
When using Python 2 (which is done in the Makefile), all #line
directives from the test code were generated with the line number 1.
This traces back to the change in the method name for generators in
Python 2 (next) vs Python 3 (__next__). Override both methods so that
the script remains compatible with both Python 2 and Python 3.
2018-08-06 11:40:58 +01:00
Gilles Peskine
7776141a16
Don't generate lines with only whitespace
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
9b06f37601
Give execute permissions to Python scripts
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
b73159d639
Remove white spaces caught by check-files.py
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
ddde34c698
Remove git conflict marker from test_suite_timing.function
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
76135345c8
Fix gcc-7 -Wformat-truncation warning
...
Function test_snprintf() is called by run_test_snprintf() with constant test
data. It gets inlined and is subjected to snprintf format truncation checks
introduced by -Wformat-truncation in gcc-7. -Wformat-truncation is turned
On by -Wall and other similar options. It results in error with -Werror.
-Wformat-truncation makes tests performed by run_test_snprintf() redundant
on gcc. But they are still relevant for other compilers. This commit prevents
inlining of test_snprintf() to avoid gcc compile time checks.
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
1ec7e6f3d9
Python3 compatible generate_test_code.py
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
78befd9019
Rename generate_code.py -> generate_test_code.py
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
7eb55687c4
Set OS specific python executable name
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
b522929666
Add support for per test suite helper functions
2018-08-06 11:40:58 +01:00
Azim Khan
05d83fa406
Put parentheses around macro arguments
2018-08-06 11:40:58 +01:00
Azim Khan
36e5fac0fb
Rephrase confusing function description
2018-08-06 11:40:58 +01:00
Azim Khan
317efe85e1
Adapt new test gcm_bad_parameters() to on target testing changes
2018-08-06 11:40:58 +01:00
Azim Khan
f0e42fbd1f
Add missing documentation and fix file doc strings
2018-08-06 11:40:58 +01:00
Mohammad Azim Khan
9540261a76
Incorporated code review comments
2018-08-06 11:40:58 +01:00
Azim Khan
d61b837fac
Update unit tests for change in test suites code generator
...
Code generator has been modified to generate case statements for dependency checks and expression checks.
This commit updates the unit tests accordingly.
2018-08-06 11:40:58 +01:00
Azim Khan
b1c2d0f946
Use switch instead if if-else for dependency and expression checks.
2018-08-06 11:40:58 +01:00