yuzu-emu/mbedtls
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
15550 commits 1 branch 0 tags 94 MiB
Commit graph

15550 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ronald Cron
2a0278734b
Merge pull request #4148 from stevew817/add_missing_non_12b_gcm_test_skip 
Add missing test skip for ALT-implemented GCM (#4010 fix-up)
 2021-03-02 09:18:41 +01:00
Paul Elliott
0544d49330 Fix Non CF access to table in base64 decrypt 
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
 2021-03-01 19:15:43 +00:00
Paul Elliott
6e152fa362 Optimise unneccesary cf table accesses away 
Also fix missed bare access of base_64_dec_map

Signed-off-by: Paul Elliott <paul.elliott@arm.com>
 2021-03-01 18:33:09 +00:00
Paul Elliott
717ba77e52 Fix incorrect assumptions about the size of size_t 
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
 2021-03-01 17:49:42 +00:00
Steven Cooreman
d788fab4ff Clarify usage of psa_key_policy_permits 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:09:24 +01:00
Steven Cooreman
16a05f5881 Add metadata tests intertwining truncated and at-least-length algos 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:09:24 +01:00
Steven Cooreman
947bb0b06f Code readability improvements 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:09:24 +01:00
Steven Cooreman
a1d8322f74 Fix typos & copy-paste errors 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:09:24 +01:00
Steven Cooreman
fb9cb92055 Move wildcard-to-exercisable conversion to exercise_key in test suite 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:09:24 +01:00
Steven Cooreman
7e39f05929 Using a wildcard as a specific algorithm now reports invalid argument 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:03:40 +01:00
Steven Cooreman
ae3f13bf5e Add more test cases and fix AT_LEAST_THIS_LENGTH against base algorithm 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:03:40 +01:00
Steven Cooreman
a96e2410e7 Test _AT_LEAST_THIS_LENGTH macros in the PSA Crypto metadata test suite 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:03:40 +01:00
Steven Cooreman
2c2efa488b Fix dependency-setting script and test dependencies for new tests 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:03:39 +01:00
Steven Cooreman
d927ed7901 Rename _MINIMUM_LENGTH flags to _AT_LEAST_THIS_LENGTH 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:03:39 +01:00
Steven Cooreman
4400c3a44a Add _AT_LEAST_THIS_LENGTH_ macros to PSA constants test 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:03:39 +01:00
Steven Cooreman
7de9e2db1f Language / verbiage fixes 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:03:39 +01:00
Steven Cooreman
aaec341c9b Exercise CCM with the right amount of IV bytes in test 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:03:39 +01:00
Steven Cooreman
5d81481a1c Rename AEAD WITH_MINIMUM_LENGTH to AT_LEAST_THIS_LENGTH 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>

# Conflicts:
#	include/psa/crypto_values.h
#	tests/suites/test_suite_psa_crypto.data
 2021-03-01 16:00:31 +01:00
Steven Cooreman
caad49316b rename MAC_WITH_MINIMUM_LENGTH_TAG to AT_LEAST_THIS_LENGTH_MAC 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:00:31 +01:00
Steven Cooreman
37389c768d Update validity domain of min_tag_length / min_mac_length 
Review indicated explicit validity domain should be [1, max_alg_length]

Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>

# Conflicts:
#	include/psa/crypto_values.h
 2021-03-01 16:00:31 +01:00
Steven Cooreman
0348802247 Remove generic wildcard checks after review feedback 
Applied specific wildcard checks instead.

Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>

# Conflicts:
#	library/psa_crypto.c
 2021-03-01 16:00:31 +01:00
Steven Cooreman
ee18b1f5a4 Style and language updates after review 
Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
 2021-03-01 16:00:31 +01:00
Steven Cooreman
b3ce8156ce Add support for minimum-tag-length AEAD and MAC policies 
Includes tests.

Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>

# Conflicts:
#	include/psa/crypto_values.h
#	tests/suites/test_suite_psa_crypto.function
 2021-03-01 16:00:31 +01:00
gabor-mezei-arm
c6f2480854
Fix documentation 
Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>
 2021-03-01 13:57:21 +01:00
gabor-mezei-arm
ceface2247
Add test for ouput buffer size macros 
Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>
 2021-03-01 13:57:21 +01:00
Gilles Peskine
34045c1d6a
Merge pull request #4145 from stevew817/fix_return_code 
Return NOT_SUPPORTED according to the API contract for psa_key_derivation_setup
 2021-03-01 13:20:50 +01:00
Gilles Peskine
574cf7b59f Clarify how a file descriptor could still be more than the limit 
It can happen if the file descriptor was opened before lowering the limit.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-03-01 11:43:56 +01:00
Gilles Peskine
97c57fe439 Fix sloppiness around stricly less-than vs less or equal 
Fix sloppy wording around stricly less-than vs less or equal in
comments. Also fix an off-by-one error in a comparison which led to
calling setrlimit if the limit was exactly the minimum required for
the test, which was unnecessary but harmless.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-03-01 11:40:56 +01:00
Gilles Peskine
c8dab5b41e Fix sloppy wording around stricly less-than vs less or equal 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-03-01 11:39:21 +01:00
Gilles Peskine
e28f236b6b Document FD_SETSIZE limitation for mbedtls_net_{poll,recv_timeout} 
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-02-25 15:56:48 +01:00
Gilles Peskine
ddf4374879 Fix stack buffer overflow in net functions with large file descriptor 
Fix a stack buffer overflow with mbedtls_net_poll() and
mbedtls_net_recv_timeout() when given a file descriptor that is beyond
FD_SETSIZE. The bug was due to not checking that the file descriptor
is within the range of an fd_set object.

Fix #4169

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-02-25 15:56:48 +01:00
Gilles Peskine
6667a78c9b Add test for mbedtls_net_poll beyond FD_SETSIZE 
mbedtls_net_poll() and mbedtls_net_recv_timeout() rely on select(),
which represents sets of file descriptors through the fd_set type.
This type cannot hold file descriptors larger than FD_SETSIZE. Make
sure that these functions identify this failure code.

Without a proper range check of the file descriptor in the
mbedtls_net_xxx function, this test fails when running with UBSan:
```
net_poll beyond FD_SETSIZE ........................................ source/library/net_sockets.c:482:9: runtime error: index 16 out of bounds for type '__fd_mask [16]'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior source/library/net_sockets.c:482:9 in
```
This is a non-regression test for
https://github.com/ARMmbed/mbedtls/issues/4169 .

The implementation of this test is specific to Unix-like platforms.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-02-25 15:56:48 +01:00
Paul Elliott
3e7908189a Fixes for MSVC warnings 
Also added a couple of missing comment blocks.

Signed-off-by: Paul Elliott <paul.elliott@arm.com>
 2021-02-25 12:28:49 +00:00
Manuel Pégourié-Gonnard
80c02af03c Add cross-doc links, avoid redundancies 
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2021-02-25 12:50:43 +01:00
Manuel Pégourié-Gonnard
b6aa958f87 Update the issue template 
- reference recently-created document
- try to improve general readability

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2021-02-25 12:50:42 +01:00
Manuel Pégourié-Gonnard
1b2e06124e Add SUPPORT.md 
This name is also recognized by github:
https://docs.github.com/en/github/building-a-strong-community/adding-support-resources-to-your-project

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2021-02-25 12:50:42 +01:00
Manuel Pégourié-Gonnard
a21abf249c Add SECURITY.md 
There was no mention of our security email address, nor of our security
process, in the repo, which made them hard to discover for contributors.

Also, this filename is recognized by github:
https://docs.github.com/en/github/managing-security-vulnerabilities/adding-a-security-policy-to-your-repository

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2021-02-25 12:50:42 +01:00
Manuel Pégourié-Gonnard
e699739f28 Add BRANCHES.md 
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
 2021-02-25 12:50:42 +01:00
gabor-mezei-arm
e86bdcaa11
Fix size macros and its documentation 
Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>
 2021-02-25 12:28:32 +01:00
gabor-mezei-arm
fbd9f1e683
Add and update macros for output buffer sizes 
Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>
 2021-02-25 12:28:32 +01:00
gabor-mezei-arm
ee6bb560a6
Remove out of scope macros 
Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>
 2021-02-25 11:51:46 +01:00
gabor-mezei-arm
8809fb64eb
Add and update size macros for ciphers and keys 
Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>
 2021-02-25 11:51:46 +01:00
gabor-mezei-arm
0687b2b236
Add macros for output buffer sizes 
Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>
 2021-02-25 11:51:46 +01:00
gabor-mezei-arm
a200ee6098
Move AEAD macros next to each other 
Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>
 2021-02-25 11:51:36 +01:00
Paul Elliott
b4e4bfdd00 Add Changelog entry 
Signed-off-by: Paul Elliott <paul.elliott@arm.com>
 2021-02-25 10:47:56 +00:00
Gilles Peskine
1c0e48a2ce New test suite: net 
A place to put tests for the net_sockets module (MBEDTLS_NET_C feature).

Start with a context smoke test.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
 2021-02-24 18:37:46 +01:00
Gilles Peskine
7f3d10de02
Merge pull request #4159 from d3zd3z/header-list 
Add missing header to cpp_dummy_build.cpp test
 2021-02-24 18:36:41 +01:00
Paul Elliott
448d54610c First pass at constant flow tests for base64 
This contains working CF tests for encode, however I have not yet got
decode to pass the tests.

Signed-off-by: Paul Elliott <paul.elliott@arm.com>
 2021-02-24 15:32:42 +00:00
Gilles Peskine
2ac5f8c04b
Merge pull request #4133 from gilles-peskine-arm/psa-conditional-inclusion-c-curves 
PSA conditional inclusion: add rationale about ECC curves and FFDH groups
 2021-02-24 11:18:05 +01:00
Manuel Pégourié-Gonnard
78fd3b7761
Merge pull request #4141 from gilles-peskine-arm/psa-test-functions-lift 
Lift some PSA test functions to a separate module
 2021-02-24 10:57:02 +01:00