yuzu-emu/mbedtls
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
16907 commits 1 branch 0 tags 94 MiB
Commit graph

5553 commits

Author SHA1 Message Date
Yuto Takano
3590691bad Fix issues raised by Pylint 2.4.4 on CI 
Locally they were unreported by Pylint 2.9.2.

Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-17 11:05:43 +01:00
Yuto Takano
4b7d23dfa6 Separate make clean and make lib in check_names 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-17 10:48:22 +01:00
Yuto Takano
704b0f77e1 Use .span() for positions, and separate line_no argument in Match 
This reverts a previous change where line_no was removed and put into
a triple tuple. It was discovered that re.Match.span() conveniently
returns (start, end), so separating line_no again makes the code cleaner.
The legibility of the code heavily outweighs the issues pointed out by
Pylint (hence disabled).

Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-17 10:41:23 +01:00
Yuto Takano
b1417b4554 Use Enums for the enum-parsing state machine 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-17 10:30:20 +01:00
Yuto Takano
5473be2914 Use a class variable for quiet instead of passing it around 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-17 10:14:24 +01:00
Yuto Takano
6adb287960 Move duplicated behaviour in get_files to own function 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-16 11:38:34 +01:00
Yuto Takano
90bc026913 Exclusively use re.search() to avoid confusion with .match() 
Also fix newline being removed when lines were concatenated

Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-16 11:34:10 +01:00
Yuto Takano
9d9c6dc46e Align the item counts in check_names for ease of reading 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-16 10:43:45 +01:00
Yuto Takano
165700c914 Remove unnecessary try/catch in list_internal_identifiers 
The try/catch was used to catch Exceptions and exit with code 1,
a legacy from check_names.py which uses the pattern to exit with
code 2. But code 1 is the default for the Python runtime anyway,
so it is redundant and can be removed.

Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-16 10:39:24 +01:00
Yuto Takano
8246eb8fb6 Fix English typos in comments of check_names and list-identifiers 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-16 10:37:24 +01:00
Yuto Takano
fb86ac70f5 Comment Match.__str__ and use format() to simplify calculation 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-16 10:32:40 +01:00
Yuto Takano
d73cec1e09 Add newline at end of list-identifiers.sh 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-10 15:45:28 +01:00
Yuto Takano
ac72fac465 Put back list-identifiers.sh as a thin wrapper around the python script 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-10 15:09:16 +01:00
Yuto Takano
206b022ad0 Fix off-by-one error in string formatting in Python 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-10 11:30:43 +01:00
Yuto Takano
7bfac1d7fe Fix incorrect reference to NameCheck in script docstring 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-09 15:49:25 +01:00
Yuto Takano
55c6c87d95 Separate code parsing and name checking in two classes 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-09 15:35:19 +01:00
Yuto Takano
50953433a4 Bring back logging of number of files 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-09 14:54:36 +01:00
Yuto Takano
8e9a219310 Improve ease of specifying which files to look in (check_names) 
- Instead of os.path.join, use glob patterns (supports Windows too)
- Instead of creating the lists beforehand (which adds messiness), pass glob
  expessions to functions and let them memoise it.
- Add support for excluding based on glob patterns, which isn't used now but
  could come in handy.

Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-09 14:48:53 +01:00
Yuto Takano
f005c3369a Change variable name argparser to parser 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-09 13:56:36 +01:00
Yuto Takano
d70d446d69 Improve code style consistency in check_names.py 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-09 12:45:51 +01:00
Yuto Takano
68d241211b Create list_internal_identifiers.py 
This is the equivalent of `list-identifiers.sh --internal`, which is
useful for generating an exclusion file for ABI/API checking.

Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-09 12:10:31 +01:00
Yuto Takano
977e07f5c8 Use glob in get_files(), call setup_logger on init 
glob is more flexible and simplifies the function arguments drastically.
It is also much more intuitive to extend in the future when the filepaths
need to be extended or changed.

setup_logger had to be called as the first thing after instantiation, so
this commit simplify makes it automatic.

Several clarification comments are added too.

Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-09 11:56:15 +01:00
Yuto Takano
51efcb143d Rename check-names.py to check_names.py 
This is necessary to import check_names from other scripts, which
will inevitably happen in the next few commits to implement the equivalent
of `list-identifiers.sh --internal`.

Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-09 11:54:12 +01:00
Yuto Takano
6fececf192 Comment why is used 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-07 17:28:23 +01:00
Yuto Takano
fc54dfb0d6 Move check_repo_path into NameCheck as staticmethod 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-07 17:18:28 +01:00
Yuto Takano
55614b51f1 Use --quiet to hide explanations and show only minimal necessary info 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-07 01:00:18 +01:00
Yuto Takano
b47b504418 Improve comments in parse_mbed_words() 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-07 00:42:54 +01:00
Yuto Takano
12a7ecda5a Fix further pylint issues picked up by Travis CI 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-07 00:40:29 +01:00
Yuto Takano
a083d15edd Specify file open encoding as utf-8 in check-names 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-07 00:25:59 +01:00
Yuto Takano
381fda8550 Print line number next to problem in check-names 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 23:37:20 +01:00
Yuto Takano
bcc3d99cc1 Fix compatibiliy with Python 3.5 on the CI 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 23:14:58 +01:00
Yuto Takano
d93fa37aa6 Address all pylint issues to follow style 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 23:05:55 +01:00
Yuto Takano
9e0e0e9980 Fix Pylint-detected function argument syntax error 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 22:01:37 +01:00
Yuto Takano
25eeb7b935 Output subprocess stdout if it errored 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:27:59 +01:00
Yuto Takano
cfc9e4a275 Change identifier regex to better support multiline declarations 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
8f457cf222 Use enumerate() to get line numbers 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
a4e751257a Output line number, line, and position of error 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
159255ab7b Document dependency on nm 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
13ecd996fc Improve regex to adapt to flexible spaces 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
5c1acf2735 Match macros with spaces between # and define 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
d24e037dd1 Warn user if files are excluded from search 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
5939a2a4de Check environment by verifying other dirs' existence 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
201f9e85ca Make use of -v to log some debug information 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
81528c058a Add documentation, fix identifier parsing 
- Add documentation to all classes and functions that were
  not self-explanatory.
- Fix the parsing of identifiers, so it now behaves identically
  to the original shell script. Detects the same amount of identifiers.
- Fix macro parsing so MBEDTLS_PSA_ACCEL didn't error out
- Reformat output to be comprehensible

Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
6f38ab3bca Fix legacy troublesome regex 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
fe02684049 Python port of f6643ccd90 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
0fd48f7939 Python port of 7cc4c68eb6 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
17220988dc Parse identifiers from library headers: Python port of d9eee3b417 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
56e3a5caa6 Add test driver symbols: Python port of 7f13fa2454 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00
Yuto Takano
e77f699ed5 Exclude FStar and Hacl: Python port of 9b33e7d7d7 
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
 2021-08-06 21:07:39 +01:00