yuzu-emu/mbedtls
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Improve return code

Browse source 
CORRUPTION_DETECTED should be reserved for cases that are impossible,
short of physical corruption during execution or a major bug in the
code. We shouldn't use this for the kind of mistakes that can happen
during configuration or integration, such as calling a driver on a key
type that it doesn't support.

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
This commit is contained in:
Manuel Pégourié-Gonnard 2023-09-20 09:22:29 +02:00
parent 4f119b8f21
commit fbea9d2e7d
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
3rdparty/p256-m/p256-m_driver_entrypoints.c vendored
View file

@ -130,7 +130,7 @@ psa_status_t p256_transparent_export_public_key(const psa_key_attributes_t *attr
/* Validate sizes, as p256-m expects fixed-size buffers */ /* Validate sizes, as p256-m expects fixed-size buffers */
if (key_buffer_size != PRIVKEY_SIZE) { if (key_buffer_size != PRIVKEY_SIZE) {
return PSA_ERROR_CORRUPTION_DETECTED; return PSA_ERROR_INVALID_ARGUMENT;
} }
if (data_size < PSA_PUBKEY_SIZE) { if (data_size < PSA_PUBKEY_SIZE) {
return PSA_ERROR_BUFFER_TOO_SMALL; return PSA_ERROR_BUFFER_TOO_SMALL;
@ -231,7 +231,7 @@ psa_status_t p256_transparent_sign_hash(
/* Validate sizes, as p256-m expects fixed-size buffers */ /* Validate sizes, as p256-m expects fixed-size buffers */
if (key_buffer_size != PRIVKEY_SIZE) { if (key_buffer_size != PRIVKEY_SIZE) {
return PSA_ERROR_CORRUPTION_DETECTED; return PSA_ERROR_INVALID_ARGUMENT;
} }
if (signature_size < SIGNATURE_SIZE) { if (signature_size < SIGNATURE_SIZE) {
return PSA_ERROR_BUFFER_TOO_SMALL; return PSA_ERROR_BUFFER_TOO_SMALL;
@ -257,7 +257,7 @@ static psa_status_t p256_verify_hash_with_public_key(
{ {
/* Validate sizes, as p256-m expects fixed-size buffers */ /* Validate sizes, as p256-m expects fixed-size buffers */
if (key_buffer_size != PSA_PUBKEY_SIZE || *key_buffer != PSA_PUBKEY_HEADER_BYTE) { if (key_buffer_size != PSA_PUBKEY_SIZE || *key_buffer != PSA_PUBKEY_HEADER_BYTE) {
return PSA_ERROR_CORRUPTION_DETECTED; return PSA_ERROR_INVALID_ARGUMENT;
} }
if (signature_length != SIGNATURE_SIZE) { if (signature_length != SIGNATURE_SIZE) {
return PSA_ERROR_INVALID_SIGNATURE; return PSA_ERROR_INVALID_SIGNATURE;