Move MPI initialization to start of function
This prevents a call to mbedtls_mpi_free() on uninitialized data when USE_PSA_INIT() fails. Signed-off-by: David Horstmann <david.horstmann@arm.com>
This commit is contained in:
parent
0f60c673f0
commit
e04a97a1eb
1 changed files with 5 additions and 3 deletions
|
@ -665,13 +665,15 @@ void x509_set_serial_check()
|
|||
mbedtls_x509write_cert ctx;
|
||||
uint8_t invalid_serial[MBEDTLS_X509_RFC5280_MAX_SERIAL_LEN + 1];
|
||||
|
||||
#if defined(MBEDTLS_TEST_DEPRECATED) && defined(MBEDTLS_BIGNUM_C)
|
||||
mbedtls_mpi serial_mpi;
|
||||
mbedtls_mpi_init(&serial_mpi);
|
||||
#endif
|
||||
|
||||
USE_PSA_INIT();
|
||||
memset(invalid_serial, 0x01, sizeof(invalid_serial));
|
||||
|
||||
#if defined(MBEDTLS_TEST_DEPRECATED) && defined(MBEDTLS_BIGNUM_C)
|
||||
mbedtls_mpi serial_mpi;
|
||||
|
||||
mbedtls_mpi_init(&serial_mpi);
|
||||
TEST_EQUAL(mbedtls_mpi_read_binary(&serial_mpi, invalid_serial,
|
||||
sizeof(invalid_serial)), 0);
|
||||
TEST_EQUAL(mbedtls_x509write_crt_set_serial(&ctx, &serial_mpi),
|
||||
|
|
Loading…
Reference in a new issue