- Changed ARC4 to use seperate input/output buffer

This commit is contained in:
Paul Bakker 2010-03-21 15:42:15 +00:00
parent f3ccc68100
commit baad6504d4
6 changed files with 30 additions and 21 deletions

View file

@ -1,6 +1,6 @@
PolarSSL ChangeLog PolarSSL ChangeLog
= Version 0.12.2 released on XXXXXXXX = Version 0.13.0 released on XXXXXXXX
Features Features
* Added option parsing for host and port selection to * Added option parsing for host and port selection to
ssl_client2 ssl_client2
@ -15,6 +15,7 @@ Changes
in a function to allow easy future expansion in a function to allow easy future expansion
* Changed symmetric cipher functions to * Changed symmetric cipher functions to
identical interface (returning int result values) identical interface (returning int result values)
* Changed ARC4 to use seperate input/output buffer
Bug fixes Bug fixes
* Fixed bug resulting in failure to send the last * Fixed bug resulting in failure to send the last

View file

@ -51,12 +51,14 @@ void arc4_setup( arc4_context *ctx, const unsigned char *key, int keylen );
* \brief ARC4 cipher function * \brief ARC4 cipher function
* *
* \param ctx ARC4 context * \param ctx ARC4 context
* \param buf buffer to be processed * \param length length of the input data
* \param buflen amount of data in buf * \param input buffer holding the input data
* \param output buffer for the output data
* *
* \return 0 * \return 0
*/ */
int arc4_crypt( arc4_context *ctx, unsigned char *buf, int buflen ); int arc4_crypt( arc4_context *ctx, int length, const unsigned char *input,
unsigned char *output );
/* /*
* \brief Checkup routine * \brief Checkup routine

View file

@ -63,7 +63,8 @@ void arc4_setup( arc4_context *ctx, const unsigned char *key, int keylen )
/* /*
* ARC4 cipher function * ARC4 cipher function
*/ */
int arc4_crypt( arc4_context *ctx, unsigned char *buf, int buflen ) int arc4_crypt( arc4_context *ctx, int length, const unsigned char *input,
unsigned char *output )
{ {
int i, x, y, a, b; int i, x, y, a, b;
unsigned char *m; unsigned char *m;
@ -72,7 +73,7 @@ int arc4_crypt( arc4_context *ctx, unsigned char *buf, int buflen )
y = ctx->y; y = ctx->y;
m = ctx->m; m = ctx->m;
for( i = 0; i < buflen; i++ ) for( i = 0; i < length; i++ )
{ {
x = ( x + 1 ) & 0xFF; a = m[x]; x = ( x + 1 ) & 0xFF; a = m[x];
y = ( y + a ) & 0xFF; b = m[y]; y = ( y + a ) & 0xFF; b = m[y];
@ -80,8 +81,8 @@ int arc4_crypt( arc4_context *ctx, unsigned char *buf, int buflen )
m[x] = (unsigned char) b; m[x] = (unsigned char) b;
m[y] = (unsigned char) a; m[y] = (unsigned char) a;
buf[i] = (unsigned char) output[i] = (unsigned char)
( buf[i] ^ m[(unsigned char)( a + b )] ); ( input[i] ^ m[(unsigned char)( a + b )] );
} }
ctx->x = x; ctx->x = x;
@ -127,7 +128,8 @@ static const unsigned char arc4_test_ct[3][8] =
int arc4_self_test( int verbose ) int arc4_self_test( int verbose )
{ {
int i; int i;
unsigned char buf[8]; unsigned char ibuf[8];
unsigned char obuf[8];
arc4_context ctx; arc4_context ctx;
for( i = 0; i < 3; i++ ) for( i = 0; i < 3; i++ )
@ -135,12 +137,12 @@ int arc4_self_test( int verbose )
if( verbose != 0 ) if( verbose != 0 )
printf( " ARC4 test #%d: ", i + 1 ); printf( " ARC4 test #%d: ", i + 1 );
memcpy( buf, arc4_test_pt[i], 8 ); memcpy( ibuf, arc4_test_pt[i], 8 );
arc4_setup( &ctx, (unsigned char *) arc4_test_key[i], 8 ); arc4_setup( &ctx, (unsigned char *) arc4_test_key[i], 8 );
arc4_crypt( &ctx, buf, 8 ); arc4_crypt( &ctx, 8, ibuf, obuf );
if( memcmp( buf, arc4_test_ct[i], 8 ) != 0 ) if( memcmp( obuf, arc4_test_ct[i], 8 ) != 0 )
{ {
if( verbose != 0 ) if( verbose != 0 )
printf( "failed\n" ); printf( "failed\n" );

View file

@ -531,7 +531,8 @@ static int ssl_encrypt_buf( ssl_context *ssl )
ssl->out_msg, ssl->out_msglen ); ssl->out_msg, ssl->out_msglen );
arc4_crypt( (arc4_context *) ssl->ctx_enc, arc4_crypt( (arc4_context *) ssl->ctx_enc,
ssl->out_msg, ssl->out_msglen ); ssl->out_msglen, ssl->out_msg,
ssl->out_msg );
#else #else
return( POLARSSL_ERR_SSL_FEATURE_UNAVAILABLE ); return( POLARSSL_ERR_SSL_FEATURE_UNAVAILABLE );
#endif #endif
@ -618,7 +619,8 @@ static int ssl_decrypt_buf( ssl_context *ssl )
#if defined(POLARSSL_ARC4_C) #if defined(POLARSSL_ARC4_C)
padlen = 0; padlen = 0;
arc4_crypt( (arc4_context *) ssl->ctx_dec, arc4_crypt( (arc4_context *) ssl->ctx_dec,
ssl->in_msg, ssl->in_msglen ); ssl->in_msglen, ssl->in_msg,
ssl->in_msg );
#else #else
return( POLARSSL_ERR_SSL_FEATURE_UNAVAILABLE ); return( POLARSSL_ERR_SSL_FEATURE_UNAVAILABLE );
#endif #endif

View file

@ -169,11 +169,11 @@ int main( void )
set_alarm( 1 ); set_alarm( 1 );
for( i = 1; ! alarmed; i++ ) for( i = 1; ! alarmed; i++ )
arc4_crypt( &arc4, buf, BUFSIZE ); arc4_crypt( &arc4, BUFSIZE, buf, buf );
tsc = hardclock(); tsc = hardclock();
for( j = 0; j < 1024; j++ ) for( j = 0; j < 1024; j++ )
arc4_crypt( &arc4, buf, BUFSIZE ); arc4_crypt( &arc4, BUFSIZE, buf, buf );
printf( "%9lu Kb/s, %9lu cycles/byte\n", i * BUFSIZE / 1024, printf( "%9lu Kb/s, %9lu cycles/byte\n", i * BUFSIZE / 1024,
( hardclock() - tsc ) / ( j * BUFSIZE ) ); ( hardclock() - tsc ) / ( j * BUFSIZE ) );

View file

@ -7,22 +7,24 @@ arc4_crypt:hex_src_string:hex_key_string:hex_dst_string
{ {
unsigned char src_str[1000]; unsigned char src_str[1000];
unsigned char key_str[1000]; unsigned char key_str[1000];
unsigned char dst_str[2000]; unsigned char dst_str[1000];
unsigned char dst_hexstr[2000];
int src_len, key_len; int src_len, key_len;
arc4_context ctx; arc4_context ctx;
memset(src_str, 0x00, 1000); memset(src_str, 0x00, 1000);
memset(key_str, 0x00, 1000); memset(key_str, 0x00, 1000);
memset(dst_str, 0x00, 2000); memset(dst_str, 0x00, 1000);
memset(dst_hexstr, 0x00, 2000);
src_len = unhexify( src_str, {hex_src_string} ); src_len = unhexify( src_str, {hex_src_string} );
key_len = unhexify( key_str, {hex_key_string} ); key_len = unhexify( key_str, {hex_key_string} );
arc4_setup(&ctx, key_str, key_len); arc4_setup(&ctx, key_str, key_len);
TEST_ASSERT( arc4_crypt(&ctx, src_str, src_len) == 0 ); TEST_ASSERT( arc4_crypt(&ctx, src_len, src_str, dst_str ) == 0 );
hexify( dst_str, src_str, src_len ); hexify( dst_hexstr, dst_str, src_len );
TEST_ASSERT( strcmp( (char *) dst_str, {hex_dst_string} ) == 0 ); TEST_ASSERT( strcmp( (char *) dst_hexstr, {hex_dst_string} ) == 0 );
} }
END_CASE END_CASE