yuzu-emu/mbedtls
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #2840 from k-stachowiak/check-bounds-of-test-intex-in-suites

Browse source 
Add lower bound check to function index lookup
This commit is contained in:
Gilles Peskine 2020-04-20 15:19:55 +02:00 committed by GitHub
commit b72df54f9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/suites/host_test.function
View file

@ -504,7 +504,7 @@ int execute_tests( int argc , const char ** argv )
const char **test_files = NULL; const char **test_files = NULL;
size_t testfile_count = 0; size_t testfile_count = 0;
int option_verbose = 0; int option_verbose = 0;
int function_id = 0; size_t function_id = 0;
/* Other Local variables */ /* Other Local variables */
int arg_index = 1; int arg_index = 1;
@ -695,7 +695,7 @@ int execute_tests( int argc , const char ** argv )
} }
#endif /* __unix__ || __APPLE__ __MACH__ */ #endif /* __unix__ || __APPLE__ __MACH__ */
function_id = strtol( params[0], NULL, 10 ); function_id = strtoul( params[0], NULL, 10 );
if ( (ret = check_test( function_id )) == DISPATCH_TEST_SUCCESS ) if ( (ret = check_test( function_id )) == DISPATCH_TEST_SUCCESS )
{ {
ret = convert_params( cnt - 1, params + 1, int_params ); ret = convert_params( cnt - 1, params + 1, int_params );

4
tests/suites/main_test.function
View file

@ -186,7 +186,7 @@ void execute_function_ptr(TestWrapper_t fp, void **params)
* DISPATCH_TEST_FN_NOT_FOUND if not found * DISPATCH_TEST_FN_NOT_FOUND if not found
* DISPATCH_UNSUPPORTED_SUITE if not compile time enabled. * DISPATCH_UNSUPPORTED_SUITE if not compile time enabled.
*/ */
int dispatch_test( int func_idx, void ** params ) int dispatch_test( size_t func_idx, void ** params )
{ {
int ret = DISPATCH_TEST_SUCCESS; int ret = DISPATCH_TEST_SUCCESS;
TestWrapper_t fp = NULL; TestWrapper_t fp = NULL;
@ -217,7 +217,7 @@ int dispatch_test( int func_idx, void ** params )
* DISPATCH_TEST_FN_NOT_FOUND if not found * DISPATCH_TEST_FN_NOT_FOUND if not found
* DISPATCH_UNSUPPORTED_SUITE if not compile time enabled. * DISPATCH_UNSUPPORTED_SUITE if not compile time enabled.
*/ */
int check_test( int func_idx ) int check_test( size_t func_idx )
{ {
int ret = DISPATCH_TEST_SUCCESS; int ret = DISPATCH_TEST_SUCCESS;
TestWrapper_t fp = NULL; TestWrapper_t fp = NULL;