Rework TestGenerator to add file targets

BaseTarget-derived targets are now added to TestGenerator.targets in
initialization. This reduces repeated code in generate_xxx_tests.py
scripts which use this framework.

Signed-off-by: Werner Lewis <werner.lewis@arm.com>

scripts/mbedtls_dev/test_generation.py

@@ -133,6 +133,11 @@ class TestGenerator:
     """Generate test data."""
     def __init__(self, options) -> None:
         self.test_suite_directory = getattr(options, 'directory')
+        # Add file Targets which have been declared in other modules
+        self.targets.update({
+            subclass.target_basename: subclass.generate_tests
+            for subclass in BaseTarget.__subclasses__()
+        })
 
     def filename_for(self, basename: str) -> str:
         """The location of the data file with the specified base name."""
@@ -149,7 +154,7 @@ class TestGenerator:
 
     # Note that targets whose names contain 'test_format' have their content
     # validated by `abi_check.py`.
-    TARGETS = {} # type: Dict[str, Callable[..., Iterable[test_case.TestCase]]]
+    targets = {} # type: Dict[str, Callable[..., Iterable[test_case.TestCase]]]
 
     def generate_target(self, name: str, *target_args) -> None:
         """Generate cases and write to data file for a target.
@@ -157,7 +162,7 @@ class TestGenerator:
         For target callables which require arguments, override this function
         and pass these arguments using super() (see PSATestGenerator).
         """
-        test_cases = self.TARGETS[name](*target_args)
+        test_cases = self.targets[name](*target_args)
         self.write_test_data_file(name, test_cases)
 
 def main(args, generator_class: Type[TestGenerator] = TestGenerator):
@@ -170,25 +175,27 @@ def main(args, generator_class: Type[TestGenerator] = TestGenerator):
     parser.add_argument('--directory', default="tests/suites", metavar='DIR',
                         help='Output directory (default: tests/suites)')
     parser.add_argument('targets', nargs='*', metavar='TARGET',
-                        default=sorted(generator_class.TARGETS),
                         help='Target file to generate (default: all; "-": none)')
     options = parser.parse_args(args)
     build_tree.chdir_to_root()
     generator = generator_class(options)
     if options.list:
-        for name in sorted(generator.TARGETS):
+        for name in sorted(generator.targets):
             print(generator.filename_for(name))
         return
     # List in a cmake list format (i.e. ';'-separated)
     if options.list_for_cmake:
         print(';'.join(generator.filename_for(name)
-                       for name in sorted(generator.TARGETS)), end='')
+                       for name in sorted(generator.targets)), end='')
         return
-    # Allow "-" as a special case so you can run
-    # ``generate_xxx_tests.py - $targets`` and it works uniformly whether
-    # ``$targets`` is empty or not.
-    options.targets = [os.path.basename(re.sub(r'\.data\Z', r'', target))
-                       for target in options.targets
-                       if target != '-']
+    if options.targets:
+        # Allow "-" as a special case so you can run
+        # ``generate_xxx_tests.py - $targets`` and it works uniformly whether
+        # ``$targets`` is empty or not.
+        options.targets = [os.path.basename(re.sub(r'\.data\Z', r'', target))
+                            for target in options.targets
+                            if target != '-']
+    else:
+        options.targets = sorted(generator.targets)
     for target in options.targets:
         generator.generate_target(target)

tests/scripts/generate_bignum_tests.py

@@ -231,12 +231,5 @@ class BignumAdd(BignumOperation):
         return quote_str(hex(self.int_l + self.int_r).replace("0x", "", 1))
 
 
-class BignumTestGenerator(test_generation.TestGenerator):
-    """Test generator subclass, for bignum file Targets."""
-    TARGETS = {
-        subclass.target_basename: subclass.generate_tests for subclass in
-        test_generation.BaseTarget.__subclasses__()
-    } # type: Dict[str, Callable[[], Iterable[test_case.TestCase]]]
-
 if __name__ == '__main__':
-    test_generation.main(sys.argv[1:], BignumTestGenerator)
+    test_generation.main(sys.argv[1:])

tests/scripts/generate_psa_tests.py

@@ -896,7 +896,7 @@ class PSATestGenerator(test_generation.TestGenerator):
     """Test generator subclass including PSA targets and info."""
     # Note that targets whose names contain 'test_format' have their content
     # validated by `abi_check.py`.
-    TARGETS = {
+    targets = {
         'test_suite_psa_crypto_generate_key.generated':
         lambda info: KeyGenerate(info).test_cases_for_key_generation(),
         'test_suite_psa_crypto_not_supported.generated':