Merge pull request #5469 from Unity-Technologies/windows-arm64-workaround

Don't inline mbedtls_mpi_safe_cond_assign on MSVC/ARM64 to avoid a compiler bug
This commit is contained in:
Manuel Pégourié-Gonnard 2022-02-01 09:21:27 +01:00 committed by GitHub
commit 9cb7b8d263
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -533,6 +533,13 @@ cleanup:
* about whether the assignment was made or not.
* (Leaking information about the respective sizes of X and Y is ok however.)
*/
#if defined(_MSC_VER) && defined(_M_ARM64) && (_MSC_FULL_VER < 193131103)
/*
* MSVC miscompiles this function if it's inlined prior to Visual Studio 2022 version 17.1. See:
* https://developercommunity.visualstudio.com/t/c-compiler-miscompiles-part-of-mbedtls-library-on/1646989
*/
__declspec(noinline)
#endif
int mbedtls_mpi_safe_cond_assign( mbedtls_mpi *X,
const mbedtls_mpi *Y,
unsigned char assign )