yuzu-emu/mbedtls
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

code_size_compare: generate text,data as comparison result

Browse source 
Previously we used dec(total) as comparison result of code size
measurement. However, it's not accurate because dec(total) is
the sum of text, data and bss. Now we show text,data instead
since those are sections we care about in code size perspective
specifically for TF-M.

Signed-off-by: Yanray Wang <yanray.wang@arm.com>
This commit is contained in:
Yanray Wang 2023-07-17 17:59:53 +08:00
parent 802af160b4
commit 9b174e90d3
1 changed files with 34 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
scripts/code_size_compare.py
View file

@ -300,7 +300,7 @@ class CodeSizeGeneratorWithSize(CodeSizeGenerator):
def __init__(self) -> None: def __init__(self) -> None:
""" Variable code_size is used to store size info for any revisions. """ Variable code_size is used to store size info for any revisions.
code_size: (data format) code_size: (data format)
{revision: {module: {file_name: SizeEntry, {revision: {module: {file_name: [text, data, bss, dec],
etc ... etc ...
}, },
etc ... etc ...
@ -318,7 +318,8 @@ class CodeSizeGeneratorWithSize(CodeSizeGenerator):
size_record = {} size_record = {}
for line in size_text.splitlines()[1:]: for line in size_text.splitlines()[1:]:
data = line.split() data = line.split()
size_record[data[5]] = CodeSizeGeneratorWithSize.SizeEntry(\ # file_name: SizeEntry(text, data, bss, dec)
size_record[data[5]] = CodeSizeGeneratorWithSize.SizeEntry(
data[0], data[1], data[2], data[3]) data[0], data[1], data[2], data[3])
if revision in self.code_size: if revision in self.code_size:
self.code_size[revision].update({mod: size_record}) self.code_size[revision].update({mod: size_record})
@ -341,8 +342,8 @@ class CodeSizeGeneratorWithSize(CodeSizeGenerator):
continue continue
if mod: if mod:
size_record[data[0]] = \ # file_name: SizeEntry(text, data, bss, dec)
CodeSizeGeneratorWithSize.SizeEntry(\ size_record[data[0]] = CodeSizeGeneratorWithSize.SizeEntry(
data[1], data[2], data[3], data[4]) data[1], data[2], data[3], data[4])
# check if we hit record for the end of a module # check if we hit record for the end of a module
@ -390,24 +391,43 @@ class CodeSizeGeneratorWithSize(CodeSizeGenerator):
) -> None: ) -> None:
"""Write comparison result into a file. """Write comparison result into a file.
Writing Format: file_name current(total) old(total) change(Byte) change_pct(%) Writing Format: file_name current(text,data) old(text,data)\
change(text,data) change_pct%(text,data)
""" """
output.write("{:<30} {:>7} {:>7} {:>7} {:>7}\n"
.format("filename", "current", "old", "change", "change%")) def cal_size_section_variation(mod, fname, size_entry, attr):
for mod, fname, size_entry in self._size_reader_helper(new_rev, output): new_size = int(size_entry.__dict__[attr])
new_size = int(size_entry.total)
# check if we have the file in old revision # check if we have the file in old revision
if fname in self.code_size[old_rev][mod]: if fname in self.code_size[old_rev][mod]:
old_size = int(self.code_size[old_rev][mod][fname].total) old_size = int(self.code_size[old_rev][mod][fname].__dict__[attr])
change = new_size - old_size change = new_size - old_size
if old_size != 0: if old_size != 0:
change_pct = change / old_size change_pct = change / old_size
else: else:
change_pct = 0 change_pct = 0
output.write("{:<30} {:>7} {:>7} {:>7} {:>7.2%}\n" return [new_size, old_size, change, change_pct]
.format(fname, new_size, old_size, change, change_pct))
else: else:
output.write("{} {}\n".format(fname, new_size)) return [new_size]
output.write("{:<30} {:<18} {:<14} {:<17} {:<18}\n"
.format("filename", "current(text,data)", "old(text,data)",\
"change(text,data)", "change%(text,data)"))
for mod, fname, size_entry in self._size_reader_helper(new_rev, output):
text_vari = cal_size_section_variation(mod, fname, size_entry, 'text')
data_vari = cal_size_section_variation(mod, fname, size_entry, 'data')
if len(text_vari) != 1:
output.write("{:<30} {:<18} {:<14} {:<17} {:<18}\n"
.format(fname,\
str(text_vari[0]) + "," + str(data_vari[0]),\
str(text_vari[1]) + "," + str(data_vari[1]),\
str(text_vari[2]) + "," + str(data_vari[2]),\
"{:.2%}".format(text_vari[3]) + "," +\
"{:.2%}".format(data_vari[3])))
else:
output.write("{:<30} {:<18}\n"
.format(fname,\
str(text_vari[0]) + "," + str(data_vari[0])))
def size_generator_write_record( def size_generator_write_record(
self, self,