yuzu-emu/mbedtls
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #7303 from daverodgman/msan_bzero_testcase

Browse source 
Add tests that cover msan explicit_bzero issue
This commit is contained in:
Dave Rodgman 2023-03-16 17:55:19 +00:00 committed by GitHub
commit 4a060ffa59
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 44 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
tests/suites/test_suite_platform_util.data
View file

@ -21,3 +21,27 @@ mbedtls_platform_zeroize:127:0
Zeroize len 128
mbedtls_platform_zeroize:128:0
Zeroize uninitialised 1 0
mbedtls_platform_zeroize_uninitialised:1:0
Zeroize uninitialised 16 0
mbedtls_platform_zeroize_uninitialised:16:0
Zeroize uninitialised 16 1
mbedtls_platform_zeroize_uninitialised:16:1
Zeroize uninitialised 16 10
mbedtls_platform_zeroize_uninitialised:16:10
Zeroize uninitialised 16 15
mbedtls_platform_zeroize_uninitialised:16:15
Zeroize uninitialised 128 0
mbedtls_platform_zeroize_uninitialised:128:0
Zeroize uninitialised 128 64
mbedtls_platform_zeroize_uninitialised:128:64
Zeroize uninitialised 128 127
mbedtls_platform_zeroize_uninitialised:128:127

20
tests/suites/test_suite_platform_util.function
View file

@ -39,3 +39,23 @@ void mbedtls_platform_zeroize(int len, int null)
TEST_EQUAL(buf[len + 1], 2);
}
/* END_CASE */
/* BEGIN_CASE */
void mbedtls_platform_zeroize_uninitialised(int len, int p)
{
/*
* As per #7301: on some platforms, including modern Linux, Clang with Msan
* does not recognize that explicit_bzero() writes well-defined content to
* its output buffer. For us, this causes CMAC operations to fail in Msan
* builds when mbedtls_platform_zeroize() is implemented over
* explicit_bzero().
*
* This test ensures we have a simple/obvious MSan test rather than
* spurious errors in crypto code that are hard to track down.
*/
char buf[128];
mbedtls_platform_zeroize(buf, len);
TEST_EQUAL(buf[p], 0);
}
/* END_CASE */