Don't promise that passing NULL input to Blowfish works

It seems to work, but we don't test it currently,
so we shouldn't promise it.
This commit is contained in:
Hanno Becker 2018-12-18 17:47:39 +00:00
parent 3d9a3490f8
commit 20376d631d

View file

@ -116,8 +116,10 @@ int mbedtls_blowfish_setkey( mbedtls_blowfish_context *ctx, const unsigned char
* \param mode The mode of operation. Possible values are * \param mode The mode of operation. Possible values are
* #MBEDTLS_BLOWFISH_ENCRYPT for encryption, or * #MBEDTLS_BLOWFISH_ENCRYPT for encryption, or
* #MBEDTLS_BLOWFISH_DECRYPT for decryption. * #MBEDTLS_BLOWFISH_DECRYPT for decryption.
* \param input The input block. This must be a readable buffer of size 8 Bytes. * \param input The input block. This must be a readable buffer
* \param input The output block. This must be a writable buffer of size 8 Bytes. * of size \c 8 Bytes.
* \param output The output block. This must be a writable buffer
* of size \c 8 Bytes.
* *
* \return \c 0 if successful. * \return \c 0 if successful.
* \return A negative error code on failure. * \return A negative error code on failure.
@ -149,9 +151,9 @@ int mbedtls_blowfish_crypt_ecb( mbedtls_blowfish_context *ctx,
* \param iv The initialization vector. This must be a read/write buffer * \param iv The initialization vector. This must be a read/write buffer
* of length \c 8 Bytes. It is updated by this function. * of length \c 8 Bytes. It is updated by this function.
* \param input The input data. This must be a readable buffer of length * \param input The input data. This must be a readable buffer of length
* \p length Bytes. If \p length if \c 0, it may be \c NULL. * \p length Bytes.
* \param output The output data. This must be a writable buffer of length * \param output The output data. This must be a writable buffer of length
* \p length Bytes. If \p length if \c 0, it may be \c NULL. * \p length Bytes.
* *
* \return \c 0 if successful. * \return \c 0 if successful.
* \return A negative error code on failure. * \return A negative error code on failure.
@ -186,12 +188,12 @@ int mbedtls_blowfish_crypt_cbc( mbedtls_blowfish_context *ctx,
* The value pointed to must be smaller than \c 8 Bytes. * The value pointed to must be smaller than \c 8 Bytes.
* It is updated by this function to support the aforementioned * It is updated by this function to support the aforementioned
* streaming usage. * streaming usage.
* \param iv The initialization vector. This must be a read/write buffer of * \param iv The initialization vector. This must be a read/write buffer
* size \c 8 Bytes. It is updated after use. * of size \c 8 Bytes. It is updated after use.
* \param input The input data. This must be a readable buffer of length * \param input The input data. This must be a readable buffer of length
* \p length Bytes. If \p length if \c 0, it may be \c NULL. * \p length Bytes.
* \param output The output data. This must be a writable buffer of length * \param output The output data. This must be a writable buffer of length
* \p length Bytes. If \p length if \c 0, it may be \c NULL. * \p length Bytes.
* *
* \return \c 0 if successful. * \return \c 0 if successful.
* \return A negative error code on failure. * \return A negative error code on failure.
@ -261,10 +263,10 @@ int mbedtls_blowfish_crypt_cfb64( mbedtls_blowfish_context *ctx,
* read/write buffer of length \c 8 Bytes. * read/write buffer of length \c 8 Bytes.
* \param stream_block The saved stream-block for resuming. This must point to * \param stream_block The saved stream-block for resuming. This must point to
* a read/write buffer of length \c 8 Bytes. * a read/write buffer of length \c 8 Bytes.
* \param input The input data. This must be a readable buffer of length * \param input The input data. This must be a readable buffer of
* \p length Bytes. If \p length is \c 0, it may be \c NULL. * length \p length Bytes.
* \param output The output data. This must be a writable buffer of length * \param output The output data. This must be a writable buffer of
* \p length Bytes. If \p length is \c 0, it may be \c NULL. * length \p length Bytes.
* *
* \return \c 0 if successful. * \return \c 0 if successful.
* \return A negative error code on failure. * \return A negative error code on failure.