Update after Simon's comment
Update the comment with Simon's comments
This commit is contained in:
parent
4b53513db5
commit
05b9498d94
2 changed files with 10 additions and 9 deletions
11
.github/issue_template.md
vendored
11
.github/issue_template.md
vendored
|
@ -8,16 +8,17 @@ Note: This is just a template, so feel free to use/remove the unnecessary things
|
||||||
## Bug
|
## Bug
|
||||||
|
|
||||||
**OS**
|
**OS**
|
||||||
linux|windows|??
|
mbed-OS|linux|windows|
|
||||||
|
|
||||||
**mbed TLS build:**
|
**mbed TLS build:**
|
||||||
Version: x.x.x or git commit id
|
Version: x.x.x or git commit id
|
||||||
Configuration: please attach config.h file
|
OS version: x.x.x
|
||||||
|
Configuration: please attach config.h file where possible
|
||||||
Compiler and options (if you used a pre-built binary, please indicate how you obtained it):
|
Compiler and options (if you used a pre-built binary, please indicate how you obtained it):
|
||||||
Additional environment information:
|
Additional environment information:
|
||||||
|
|
||||||
**peer device TLS stack and version**
|
**peer device TLS stack and version**
|
||||||
openSSL | GnuTls | other
|
openSSL|GnuTls|Chrome|NSS(Firefox)|SEcureChannel (IIS/Internet Explorer/Edge)|Other
|
||||||
version:
|
version:
|
||||||
|
|
||||||
**Expected behavior**
|
**Expected behavior**
|
||||||
|
@ -29,7 +30,7 @@ version:
|
||||||
----------------------------------------------------------------
|
----------------------------------------------------------------
|
||||||
## Enhancement\Feature Request
|
## Enhancement\Feature Request
|
||||||
|
|
||||||
**Incentive for change**
|
**Justification - why does the library need this feature?**
|
||||||
|
|
||||||
**Suggested enhancement**
|
**Suggested enhancement**
|
||||||
|
|
||||||
|
@ -37,4 +38,4 @@ version:
|
||||||
|
|
||||||
## Question
|
## Question
|
||||||
|
|
||||||
**Please first check for answers in the [mbed TLS knowledge Base](https://tls.mbed.org/kb), and preferebly file an issue in the [mbed TLS support forum](https://tls.mbed.org/discussions)**
|
**Please first check for answers in the [mbed TLS knowledge Base](https://tls.mbed.org/kb), and preferebly file an issue in the [mbed TLS support forum](https://tls.mbed.org/discussions)**
|
||||||
|
|
8
.github/pull_request_template.md
vendored
8
.github/pull_request_template.md
vendored
|
@ -1,7 +1,7 @@
|
||||||
Notes:
|
Notes:
|
||||||
* Pull requests will not be accepted until:
|
* Pull requests cannot be accepted until:
|
||||||
- The submitter has [accepted the online agreement here with a click through](https://developer.mbed.org/contributor_agreement/)
|
- The submitter has [accepted the online agreement here with a click through](https://developer.mbed.org/contributor_agreement/)
|
||||||
or those that do not wish to create an mbed account, a slightly different agreement can be found [here](https://www.mbed.com/en/about-mbed/contributor-license-agreements/)
|
or for companies or those that do not wish to create an mbed account, a slightly different agreement can be found [here](https://www.mbed.com/en/about-mbed/contributor-license-agreements/)
|
||||||
- The PR follows the [mbed TLS coding standards](https://tls.mbed.org/kb/development/mbedtls-coding-standards)
|
- The PR follows the [mbed TLS coding standards](https://tls.mbed.org/kb/development/mbedtls-coding-standards)
|
||||||
* This is just a template, so feel free to use/remove the unnecessary things
|
* This is just a template, so feel free to use/remove the unnecessary things
|
||||||
## Description
|
## Description
|
||||||
|
@ -18,7 +18,7 @@ legacy supported branches will not be backported if:
|
||||||
- This PR contains changes in the API. If this is true, and there is a need for the fix to be backported, the fix should be handled differently in the legacy branch
|
- This PR contains changes in the API. If this is true, and there is a need for the fix to be backported, the fix should be handled differently in the legacy branch
|
||||||
|
|
||||||
Yes | NO
|
Yes | NO
|
||||||
What branch?
|
Which branch?
|
||||||
|
|
||||||
## Migrations
|
## Migrations
|
||||||
If there is any API change, what's the incentive and logic for it.
|
If there is any API change, what's the incentive and logic for it.
|
||||||
|
@ -36,4 +36,4 @@ Any additional information that could be of interest
|
||||||
|
|
||||||
|
|
||||||
## Steps to test or reproduce
|
## Steps to test or reproduce
|
||||||
Outline the steps to test or reproduce the PR here.
|
Outline the steps to test or reproduce the PR here.
|
||||||
|
|
Loading…
Reference in a new issue