update to newer googletest

This matches the version used in Chromium.

Change-Id: I1b697c7f79a4e628cecf96f6abc3e5dacac0888a
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2605357
Reviewed-by: Mark Mentovai <mark@chromium.org>

DEPS

@@ -36,7 +36,7 @@ deps = {
   # Testing libraries and utilities.
   "src/src/testing":
     "https://github.com/google/googletest.git" +
-      "@5ec7f0c4a113e2f18ac2c6cc7df51ad6afc24081",
+      "@4fe018038f87675c083d0cfb6a6b57c274fb1753",
 
   # Protobuf.
   "src/src/third_party/protobuf/protobuf":

default.xml

@@ -27,7 +27,7 @@
 
   <project path='src/src/testing'
            name='google/googletest.git'
-           revision='5ec7f0c4a113e2f18ac2c6cc7df51ad6afc24081'
+           revision='4fe018038f87675c083d0cfb6a6b57c274fb1753'
            remote='github' />
 
   <project path='src/src/third_party/lss'

src/common/dwarf/dwarf2reader_die_unittest.cc

@@ -204,7 +204,7 @@ TEST_P(DwarfHeader, Header) {
   EXPECT_EQ(parser.Start(), info_contents.size());
 }
 
-INSTANTIATE_TEST_CASE_P(
+INSTANTIATE_TEST_SUITE_P(
     HeaderVariants, DwarfHeader,
     ::testing::Values(DwarfHeaderParams(kLittleEndian, 4, 2, 4),
                       DwarfHeaderParams(kLittleEndian, 4, 2, 8),
@@ -494,7 +494,7 @@ TEST_P(DwarfForms, implicit_const) {
 
 // Tests for the other attribute forms could go here.
 
-INSTANTIATE_TEST_CASE_P(
+INSTANTIATE_TEST_SUITE_P(
     HeaderVariants, DwarfForms,
     ::testing::Values(DwarfHeaderParams(kLittleEndian, 4, 2, 4),
                       DwarfHeaderParams(kLittleEndian, 4, 2, 8),

src/common/dwarf_cu_to_module_unittest.cc

@@ -55,6 +55,7 @@ using google_breakpad::Module;
 
 using ::testing::_;
 using ::testing::AtMost;
+using ::testing::DoAll;
 using ::testing::Invoke;
 using ::testing::Return;
 using ::testing::Test;
@@ -857,7 +858,7 @@ Situation situations[] = {
 class FuncLinePairing: public CUFixtureBase,
                        public TestWithParam<Situation> { };
 
-INSTANTIATE_TEST_CASE_P(AllSituations, FuncLinePairing,
+INSTANTIATE_TEST_SUITE_P(AllSituations, FuncLinePairing,
                          ValuesIn(situations));
 
 TEST_P(FuncLinePairing, Pairing) {
@@ -1043,7 +1044,7 @@ TEST_F(FuncLinePairing, WarnOnceLine) {
 class CXXQualifiedNames: public CUFixtureBase,
                          public TestWithParam<DwarfTag> { };
 
-INSTANTIATE_TEST_CASE_P(VersusEnclosures, CXXQualifiedNames,
+INSTANTIATE_TEST_SUITE_P(VersusEnclosures, CXXQualifiedNames,
                          Values(dwarf2reader::DW_TAG_class_type,
                                 dwarf2reader::DW_TAG_structure_type,
                                 dwarf2reader::DW_TAG_union_type,
@@ -1145,7 +1146,7 @@ class QualifiedForLanguage
     : public CUFixtureBase,
       public TestWithParam<LanguageAndQualifiedName> { };
 
-INSTANTIATE_TEST_CASE_P(LanguageAndQualifiedName, QualifiedForLanguage,
+INSTANTIATE_TEST_SUITE_P(LanguageAndQualifiedName, QualifiedForLanguage,
                          ValuesIn(LanguageAndQualifiedNameCases));
 
 TEST_P(QualifiedForLanguage, MemberFunction) {

src/common/linux/elf_symbols_to_module_unittest.cc

@@ -248,7 +248,7 @@ TEST_P(ELFSymbolsToModuleTest32, SkipStuff) {
 }
 
 // Run all the 32-bit tests with both endianness
-INSTANTIATE_TEST_CASE_P(Endian,
+INSTANTIATE_TEST_SUITE_P(Endian,
                          ELFSymbolsToModuleTest32,
                          ::testing::Values(kLittleEndian, kBigEndian));
 
@@ -365,6 +365,6 @@ TEST_P(ELFSymbolsToModuleTest64, SkipStuff) {
 }
 
 // Run all the 64-bit tests with both endianness
-INSTANTIATE_TEST_CASE_P(Endian,
+INSTANTIATE_TEST_SUITE_P(Endian,
                          ELFSymbolsToModuleTest64,
                          ::testing::Values(kLittleEndian, kBigEndian));

src/processor/stackwalker_address_list_unittest.cc

@@ -56,6 +56,7 @@ using google_breakpad::StackwalkerAddressList;
 using std::vector;
 using testing::_;
 using testing::AnyNumber;
+using testing::DoAll;
 using testing::Return;
 using testing::SetArgumentPointee;
 

src/processor/stackwalker_mips64_unittest.cc

@@ -65,6 +65,7 @@ using google_breakpad::test_assembler::Section;
 using std::vector;
 using testing::_;
 using testing::AnyNumber;
+using testing::DoAll;
 using testing::Return;
 using testing::SetArgumentPointee;
 using testing::Test;

src/processor/stackwalker_mips_unittest.cc

@@ -64,6 +64,7 @@ using google_breakpad::test_assembler::Section;
 using std::vector;
 using testing::_;
 using testing::AnyNumber;
+using testing::DoAll;
 using testing::Return;
 using testing::SetArgumentPointee;
 using testing::Test;

src/tools/windows/dump_syms/dump_syms_unittest.cc

@@ -215,7 +215,7 @@ TEST_P(DumpSymsRegressionTest, EnsureDumpedSymbolsMatch) {
   EXPECT_EQ(expected_symbols, symbols);
 }
 
-INSTANTIATE_TEST_CASE_P(DumpSyms, DumpSymsRegressionTest,
+INSTANTIATE_TEST_SUITE_P(DumpSyms, DumpSymsRegressionTest,
   testing::ValuesIn(kRootNames));
 
 TEST_P(DumpSymsPEOnlyRegressionTest, EnsurePEOnlyDumpedSymbolsMatch) {
@@ -235,7 +235,7 @@ TEST_P(DumpSymsPEOnlyRegressionTest, EnsurePEOnlyDumpedSymbolsMatch) {
   EXPECT_EQ(expected_symbols, symbols);
 }
 
-INSTANTIATE_TEST_CASE_P(PEOnlyDumpSyms, DumpSymsPEOnlyRegressionTest,
+INSTANTIATE_TEST_SUITE_P(PEOnlyDumpSyms, DumpSymsPEOnlyRegressionTest,
   testing::ValuesIn(kPEOnlyRootNames));