yuzu-emu/breakpad
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

stackwalker_mips64_unittest: default-init MIPS context

Browse source 
This test's constructor fails to fully initialize this raw context. As a
result, we have at least one use of uninitialized memory in CFI.At4004.
This causes said test to fail under ASAN.

Bug: b:235999011
Change-Id: I3279da8ac3414eb8c90f3949a1db47a03e750a94
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3756749
Reviewed-by: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
George Burgess IV 2022-07-11 21:02:22 -07:00 committed by George Burgess
parent 0b1ffaa153
commit e9057e2d5e
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/processor/stackwalker_mips64_unittest.cc
View file

@ -645,8 +645,10 @@ struct CFIFixture: public StackwalkerMIPSFixture {
EXPECT_EQ(0x00405000U, frame1->function_base); EXPECT_EQ(0x00405000U, frame1->function_base);
} }
// The values we expect to find for the caller's registers. // The values we expect to find for the caller's registers. Forcibly
MDRawContextMIPS expected; // default-init it, since it's POD and not all bits are always overwritten by
// the constructor.
MDRawContextMIPS expected{};
// The validity mask for expected. // The validity mask for expected.
int expected_validity; int expected_validity;