Updating BreakpadController to allow start and stop being nop.
When BreakpadController is already started or stopped, trying to restart it or restopping it will now be no-op instead of asserting. Review URL: https://breakpad.appspot.com/505002 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1092 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
parent
6aab1f92bb
commit
bdd7220794
1 changed files with 5 additions and 4 deletions
|
@ -129,6 +129,9 @@ NSString* GetPlatform() {
|
|||
#pragma mark -
|
||||
|
||||
- (void)start:(BOOL)onCurrentThread {
|
||||
if (started)
|
||||
return;
|
||||
started_ = YES;
|
||||
void(^startBlock)() = ^{
|
||||
assert(!breakpadRef_);
|
||||
breakpadRef_ = BreakpadCreate(configuration_);
|
||||
|
@ -136,8 +139,6 @@ NSString* GetPlatform() {
|
|||
BreakpadAddUploadParameter(breakpadRef_, @"platform", GetPlatform());
|
||||
}
|
||||
};
|
||||
NSAssert(!started_, @"Start cannot be called more than once.");
|
||||
started_ = YES;
|
||||
if (onCurrentThread)
|
||||
startBlock();
|
||||
else
|
||||
|
@ -145,8 +146,8 @@ NSString* GetPlatform() {
|
|||
}
|
||||
|
||||
- (void)stop {
|
||||
NSAssert(started_,
|
||||
@"The controller must be started before it can be stopped");
|
||||
if (!started)
|
||||
return;
|
||||
started_ = NO;
|
||||
dispatch_sync(queue_, ^{
|
||||
if (breakpadRef_) {
|
||||
|
|
Loading…
Reference in a new issue