yuzu-emu/breakpad
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

file_id_unittest: avoid system()

Browse source 
We have API's for copying files & changing file modes, so there's
no sense in using system() to run programs to do that.

For the strip call, do the minimal spawn+wait dance.  This avoids
weird quoting string issues at least.

Change-Id: Ibda117f243e886c0c7fcf8076fb8602b8d3ba42d
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2396558
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Mike Frysinger 2020-09-07 17:30:21 -04:00
parent 5640e57f1f
commit bdac77a801
1 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/common/linux/file_id_unittest.cc
View file

@ -30,7 +30,10 @@
// Unit tests for FileID // Unit tests for FileID
#include <elf.h> #include <elf.h>
#include <spawn.h>
#include <stdlib.h> #include <stdlib.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <string> #include <string>
#include <vector> #include <vector>
@ -42,6 +45,7 @@
#include "common/linux/synth_elf.h" #include "common/linux/synth_elf.h"
#include "common/test_assembler.h" #include "common/test_assembler.h"
#include "common/tests/auto_tempdir.h" #include "common/tests/auto_tempdir.h"
#include "common/tests/file_utils.h"
#include "common/using_std_string.h" #include "common/using_std_string.h"
#include "breakpad_googletest_includes.h" #include "breakpad_googletest_includes.h"
@ -80,13 +84,18 @@ TEST(FileIDStripTest, StripSelf) {
// copy our binary to a temp file, and strip it // copy our binary to a temp file, and strip it
AutoTempDir temp_dir; AutoTempDir temp_dir;
string templ = temp_dir.path() + "/file-id-unittest"; string templ = temp_dir.path() + "/file-id-unittest";
char cmdline[4096]; ASSERT_TRUE(CopyFile(exe_name, templ));
sprintf(cmdline, "cp \"%s\" \"%s\"", exe_name, templ.c_str()); pid_t pid;
ASSERT_EQ(0, system(cmdline)) << "Failed to execute: " << cmdline; char* argv[] = {
sprintf(cmdline, "chmod u+w \"%s\"", templ.c_str()); const_cast<char*>("strip"),
ASSERT_EQ(0, system(cmdline)) << "Failed to execute: " << cmdline; const_cast<char*>(templ.c_str()),
sprintf(cmdline, "strip \"%s\"", templ.c_str()); nullptr,
ASSERT_EQ(0, system(cmdline)) << "Failed to execute: " << cmdline; };
ASSERT_EQ(0, posix_spawnp(&pid, argv[0], nullptr, nullptr, argv, nullptr));
int status;
ASSERT_EQ(pid, waitpid(pid, &status, 0));
ASSERT_TRUE(WIFEXITED(status));
ASSERT_EQ(0, WEXITSTATUS(status));
PageAllocator allocator; PageAllocator allocator;
id_vector identifier1(&allocator, kDefaultBuildIdSize); id_vector identifier1(&allocator, kDefaultBuildIdSize);