Modify SimpleSymbolSupplier for easier sublcassing (#75).
Patch by Ted Mielczarek <ted.mielczarek>. r=me http://groups.google.com/group/airbag-dev/browse_thread/thread/34690777576ccf7e git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@67 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
parent
9e586c173e
commit
7573d1dd44
2 changed files with 9 additions and 3 deletions
|
@ -39,7 +39,8 @@
|
||||||
|
|
||||||
namespace google_airbag {
|
namespace google_airbag {
|
||||||
|
|
||||||
string SimpleSymbolSupplier::GetSymbolFile(MinidumpModule *module) {
|
string SimpleSymbolSupplier::GetSymbolFileAtPath(MinidumpModule *module,
|
||||||
|
const string &root_path) {
|
||||||
// For now, only support modules that have GUIDs - which means
|
// For now, only support modules that have GUIDs - which means
|
||||||
// MDCVInfoPDB70.
|
// MDCVInfoPDB70.
|
||||||
|
|
||||||
|
@ -55,7 +56,7 @@ string SimpleSymbolSupplier::GetSymbolFile(MinidumpModule *module) {
|
||||||
return "";
|
return "";
|
||||||
|
|
||||||
// Start with the base path.
|
// Start with the base path.
|
||||||
string path = path_;
|
string path = root_path;
|
||||||
|
|
||||||
// Append the pdb file name as a directory name.
|
// Append the pdb file name as a directory name.
|
||||||
path.append("/");
|
path.append("/");
|
||||||
|
|
|
@ -88,7 +88,12 @@ class SimpleSymbolSupplier : public SymbolSupplier {
|
||||||
|
|
||||||
// Returns the path to the symbol file for the given module. See the
|
// Returns the path to the symbol file for the given module. See the
|
||||||
// description above.
|
// description above.
|
||||||
virtual string GetSymbolFile(MinidumpModule *module);
|
virtual string GetSymbolFile(MinidumpModule *module) {
|
||||||
|
return GetSymbolFileAtPath(module, path_);
|
||||||
|
}
|
||||||
|
|
||||||
|
protected:
|
||||||
|
string GetSymbolFileAtPath(MinidumpModule *module, const string &root_path);
|
||||||
|
|
||||||
private:
|
private:
|
||||||
string path_;
|
string path_;
|
||||||
|
|
Loading…
Reference in a new issue