From 5bba75bfd6ec386b8e3af0b91332388a378135bf Mon Sep 17 00:00:00 2001 From: Michael Forney Date: Wed, 18 Mar 2020 17:23:10 -0700 Subject: [PATCH] Remove true/false defines in convert_UTF.cc These are left over from when this file was written in C. In C++, true and false are keywords, so this is no longer necessary. In fact, redefining a keyword is not actually permitted in ISO C++ (https://eel.is/c++draft/macro.names#2), and is rejected by MSVC. Change-Id: I2f4a6eae7f8dd4d91b8ee6588c7ae5e8f20bd0d0 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2105831 Reviewed-by: Mike Frysinger --- src/common/convert_UTF.cc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/common/convert_UTF.cc b/src/common/convert_UTF.cc index fe0e1556..4a5df1eb 100644 --- a/src/common/convert_UTF.cc +++ b/src/common/convert_UTF.cc @@ -78,13 +78,6 @@ const UTF32 halfMask = 0x3FFUL; #define UNI_SUR_LOW_START (UTF32)0xDC00 #define UNI_SUR_LOW_END (UTF32)0xDFFF -#ifndef false -#define false 0 -#endif -#ifndef true -#define true 1 -#endif - /* --------------------------------------------------------------------- */ ConversionResult ConvertUTF32toUTF16 (const UTF32** sourceStart, const UTF32* sourceEnd,