yuzu-emu/breakpad
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix some Coverity defects.

Browse source 
Fix a few issues Coverity detected in exploitability_linux.cc:

CID 277681, 277682, 277683

Change-Id: I8ad0581f075da7346b9be8100b3690555a358b16
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3872234
Reviewed-by: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
Lei Zhang 2022-09-06 08:00:52 -07:00
parent 5d6d250150
commit 30c7f3cfc1
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/processor/exploitability_linux.cc
View file

@ -518,18 +518,17 @@ bool ExploitabilityLinux::DisassembleBytes(const string& architecture,
raw_bytes_tmpfile); raw_bytes_tmpfile);
FILE* objdump_fp = popen(cmd, "r"); FILE* objdump_fp = popen(cmd, "r");
if (!objdump_fp) { if (!objdump_fp) {
fclose(objdump_fp);
unlink(raw_bytes_tmpfile); unlink(raw_bytes_tmpfile);
BPLOG(ERROR) << "Failed to call objdump."; BPLOG(ERROR) << "Failed to call objdump.";
return false; return false;
} }
if (fread(objdump_output_buffer, 1, buffer_len, objdump_fp) <= 0) { if (fread(objdump_output_buffer, 1, buffer_len, objdump_fp) != buffer_len) {
fclose(objdump_fp); pclose(objdump_fp);
unlink(raw_bytes_tmpfile); unlink(raw_bytes_tmpfile);
BPLOG(ERROR) << "Failed to read objdump output."; BPLOG(ERROR) << "Failed to read objdump output.";
return false; return false;
} }
fclose(objdump_fp); pclose(objdump_fp);
unlink(raw_bytes_tmpfile); unlink(raw_bytes_tmpfile);
return true; return true;
} }