yuzu-emu/breakpad
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

processor: subtract 1 from return pointers while scanning

Browse source 
Each stackwalker subtracts the size of an instruction
from a frame's instruction pointer to determine which
instruction it was executing. This should also be done
for pointers examined while scanning for likely return
addresses to ensure that those pointers don't point
past the end of functions.

Bug: b/118634446
Change-Id: I043e3f1e51a2c0a3d99ed14bf18ea64dc98add44
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2356649
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Joshua Peraza 2020-08-14 10:25:39 -07:00
parent 014e84252c
commit 087795c851
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/google_breakpad/processor/stackwalker.h
View file

@ -176,8 +176,12 @@ class Stackwalker {
if (!memory_->GetMemoryAtAddress(location, &ip))
break;
if (modules_ && modules_->GetModuleForAddress(ip) &&
InstructionAddressSeemsValid(ip)) {
// The return address points to the instruction after a call. If the
// caller was a no return function, this might point past the end of the
// function. Subtract one from the instruction pointer so it points into
// the call instruction instead.
if (modules_ && modules_->GetModuleForAddress(ip - 1) &&
InstructionAddressSeemsValid(ip - 1)) {
*ip_found = ip;
*location_found = location;
return true;