Merge branch 'dev' into ddutchie/uitweaks

This reverts commit 8e08fc1ab9.

.ci/scripts/linux/docker.sh

@@ -12,8 +12,6 @@ mkdir build || true && cd build
 cmake .. \
       -DBoost_USE_STATIC_LIBS=ON \
       -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-			-DSUYU_USE_PRECOMPILED_HEADERS=OFF \
-			-DDYNARMIC_USE_PRECOMPILED_HEADERS=OFF \
       -DCMAKE_CXX_FLAGS="-march=x86-64-v2" \
       -DCMAKE_CXX_COMPILER=/usr/lib/ccache/g++ \
       -DCMAKE_C_COMPILER=/usr/lib/ccache/gcc \
@@ -26,7 +24,6 @@ cmake .. \
       -DSUYU_USE_BUNDLED_FFMPEG=ON \
       -DSUYU_ENABLE_LTO=ON \
       -DSUYU_CRASH_DUMPS=ON \
-      -DSUYU_USE_FASTER_LD=ON \
       -GNinja
 
 ninja

.gitlab-ci.yml

@@ -1,22 +1,6 @@
 stages:
   - format
   - build
-
-variables:
-  # https://docs.gitlab.com/ee/ci/runners/configure_runners.html
-  TRANSFER_METER_FREQUENCY: "2s"
-  ARTIFACT_COMPRESSION_LEVEL: "fast"
-  CACHE_COMPRESSION_LEVEL: "fastest"
-  CACHE_REQUEST_TIMEOUT: 5
-  # Use FASTZIP for faster compression in cache and artifacts (boolean)
-  # https://docs.gitlab.com/runner/configuration/feature-flags.html#available-feature-flags
-  FF_USE_FASTZIP: 1
-  
-  # Our Variables
-  CACHE_DIR: "$CI_PROJECT_DIR/ccache"
-  CCACHE_DIR: $CACHE_DIR
-
-
 #CLANG FORMAT - CHECKS CODE FOR FORMATTING ISSUES
 clang-format:
   stage: format
@@ -32,20 +16,11 @@ clang-format:
   #  - Windows
     - Parallelized
     - Format
-
 #LINUX BUILD - BUILDS LINUX APPIMAGE
 build-linux:
   stage: build
   image: suyuemu/cibuild:linux-x64
   resource_group: linux-ci
-  cache:
-    key: "$CI_COMMIT_REF_NAME-ccache"
-    paths:
-      - $CACHE_DIR
-  before_script:
-    - mkdir -p $CACHE_DIR
-    - chmod -R 777 $CACHE_DIR
-    - ls -la $CACHE_DIR
   variables:
     GIT_SUBMODULE_STRATEGY: recursive
     GIT_SUBMODULE_DEPTH: 1
@@ -59,7 +34,6 @@ build-linux:
   tags:
     - Linux
     - Parallelized
-
 #ANDROID BUILD - BUILDS APK
 android:
   stage: build
@@ -80,4 +54,3 @@ android:
   tags:
     - Android
     - Parallelized
-

CMakeLists.txt

@@ -71,7 +71,7 @@ option(SUYU_ENABLE_PORTABLE "Allow suyu to enable portable mode if a user folder
 
 CMAKE_DEPENDENT_OPTION(SUYU_USE_FASTER_LD "Check if a faster linker is available" ON "NOT WIN32" OFF)
 
-CMAKE_DEPENDENT_OPTION(USE_SYSTEM_MOLTENVK "Use the system MoltenVK lib (instead of the bundled one)" OFF "APPLE" OFF)
+CMAKE_DEPENDENT_OPTION(USE_SYSTEM_MOLTENVK "Use the system MoltenVK lib (instead of the bundled one)" OFF "APPLE" ON)
 
 option(USE_CCACHE "Use CCache for faster building" ON)
 

README.md

@@ -51,12 +51,10 @@ You can also contact any of the developers on Discord to learn more about the cu
 
 ## Downloads
 
-* __Windows__: [Releases](https://gitlab.com/suyu-emu/suyu/-/releases)
-* __Linux__: [Releases](https://gitlab.com/suyu-emu/suyu/-/releases)
-* __macOS__: [Releases](https://gitlab.com/suyu-emu/suyu/-/releases)
-* __Android__: [Releases](https://gitlab.com/suyu-emu/suyu/-/releases)
+* __Windows__: WIP
+* __Linux__: WIP
 
-We have official builds [here.](https://gitlab.com/suyu-emu/suyu/-/releases) If any website or person is claiming to have a build for suyu, take that with a grain of salt.
+We don't have any official builds yet! If any website or person is claiming to have a build for suyu, take that with a grain of salt, because it might contain malware. Until we do have an official build, it might be a better idea to keep using the last version of yuzu.
 
 ## Building
 

src/hid_core/frontend/emulated_controller.cpp

@@ -762,8 +762,6 @@ void EmulatedController::StartMotionCalibration() {
 
 void EmulatedController::SetButton(const Common::Input::CallbackStatus& callback, std::size_t index,
                                    Common::UUID uuid) {
-    const auto player_index = Service::HID::NpadIdTypeToIndex(npad_id_type);
-    const auto& player = Settings::values.players.GetValue()[player_index];
     if (index >= controller.button_values.size()) {
         return;
     }
@@ -919,8 +917,13 @@ void EmulatedController::SetButton(const Common::Input::CallbackStatus& callback
 
     lock.unlock();
 
-    if (player.connected) {
-        Connect();
+    if (!is_connected) {
+        if (npad_id_type == NpadIdType::Player1 && npad_type != NpadStyleIndex::Handheld) {
+            Connect();
+        }
+        if (npad_id_type == NpadIdType::Handheld && npad_type == NpadStyleIndex::Handheld) {
+            Connect();
+        }
     }
     TriggerOnChange(ControllerTriggerType::Button, true);
 }

src/suyu/loading_screen.cpp

@@ -31,23 +31,22 @@ constexpr char PROGRESSBAR_STYLE_BUILD[] = R"(
 QProgressBar {
   background-color: black;
   border: 2px solid white;
-  border-radius: 4px;
+  border-radius: 10px;
   padding: 2px;
 }
 QProgressBar::chunk {
-  background-color: #ff3c28;
-  width: 1px;
+  background-color: qlineargradient(spread:pad, x1:0, y1:0, x2:1, y2:0, stop:0 rgba(98, 160, 234, 255), stop:1 rgba(237, 51, 59, 255));
+  border-radius: 6px;
 })";
 
 constexpr char PROGRESSBAR_STYLE_COMPLETE[] = R"(
 QProgressBar {
-  background-color: #0ab9e6;
+  background-color: black;
   border: 2px solid white;
-  border-radius: 4px;
-  padding: 2px;
+  border-radius: 10px;
+  padding: 4px;
 }
 QProgressBar::chunk {
-  background-color: #ff3c28;
 })";
 
 LoadingScreen::LoadingScreen(QWidget* parent)
@@ -99,7 +98,7 @@ void LoadingScreen::Prepare(Loader::AppLoader& loader) {
 #ifdef SUYU_QT_MOVIE_MISSING
         QPixmap map;
         map.loadFromData(buffer.data(), buffer.size());
-        ui->banner->setPixmap(map);
+        setPixmap(map);
 #else
         backing_mem = std::make_unique<QByteArray>(reinterpret_cast<char*>(buffer.data()),
                                                    static_cast<int>(buffer.size()));
@@ -116,6 +115,8 @@ void LoadingScreen::Prepare(Loader::AppLoader& loader) {
         map.loadFromData(buffer.data(), static_cast<uint>(buffer.size()));
         ui->logo->setPixmap(map);
     }
+    ui->logo->setVisible(false);
+    ui->banner->setVisible(false);
 
     slow_shader_compile_start = false;
     OnLoadProgress(VideoCore::LoadCallbackStage::Prepare, 0, 0);

src/suyu/loading_screen.ui

@@ -49,6 +49,9 @@
       </property>
       <item alignment="Qt::AlignLeft|Qt::AlignTop">
        <widget class="QLabel" name="logo">
+        <property name="enabled">
+         <bool>false</bool>
+        </property>
         <property name="text">
          <string/>
         </property>
@@ -78,7 +81,7 @@
           </property>
           <property name="styleSheet">
            <string notr="true">background-color: black; color: white;
-font: 75 20pt &quot;Arial&quot;;</string>
+font: 500 20pt &quot;Ubuntu&quot;;</string>
           </property>
           <property name="text">
            <string>Loading Shaders 387 / 1628</string>
@@ -96,19 +99,25 @@ font: 75 20pt &quot;Arial&quot;;</string>
           <property name="minimumSize">
            <size>
             <width>500</width>
-            <height>40</height>
+            <height>30</height>
+           </size>
+          </property>
+          <property name="maximumSize">
+           <size>
+            <width>16777215</width>
+            <height>30</height>
            </size>
           </property>
           <property name="styleSheet">
            <string notr="true">QProgressBar {
-color: white;
+background-color: black;
 border: 2px solid white;
-outline-color: black;
-border-radius: 20px;
+border-radius: 10px;
+padding: 2px;
 }
 QProgressBar::chunk {
-background-color: white;
-border-radius: 15px;
+background-color: qlineargradient(spread:pad, x1:0, y1:0, x2:1, y2:0, stop:0 rgba(98, 160, 234, 255), stop:1 rgba(237, 51, 59, 255));
+border-radius: 6px;
 }</string>
           </property>
           <property name="value">
@@ -129,7 +138,7 @@ border-radius: 15px;
           </property>
           <property name="styleSheet">
            <string notr="true">background-color: black; color: white;
-font: 75 15pt &quot;Arial&quot;;</string>
+font: 500 15pt &quot;Ubuntu&quot;;</string>
           </property>
           <property name="text">
            <string>Estimated Time 5m 4s</string>
@@ -140,6 +149,9 @@ font: 75 15pt &quot;Arial&quot;;</string>
       </item>
       <item alignment="Qt::AlignRight|Qt::AlignBottom">
        <widget class="QLabel" name="banner">
+        <property name="enabled">
+         <bool>false</bool>
+        </property>
         <property name="styleSheet">
          <string notr="true">background-color: black;</string>
         </property>

src/suyu/main.cpp

@@ -1535,11 +1535,12 @@ void GMainWindow::ConnectMenuEvents() {
     connect_menu(ui->action_Show_Folders_In_List, &GMainWindow::OnToggleFoldersInList);
 
     connect_menu(ui->action_Reset_Window_Size_720, &GMainWindow::ResetWindowSize720);
+    connect_menu(ui->action_Reset_Window_Size_800, &GMainWindow::ResetWindowSize800);
     connect_menu(ui->action_Reset_Window_Size_900, &GMainWindow::ResetWindowSize900);
     connect_menu(ui->action_Reset_Window_Size_1080, &GMainWindow::ResetWindowSize1080);
-    ui->menu_Reset_Window_Size->addActions({ui->action_Reset_Window_Size_720,
-                                            ui->action_Reset_Window_Size_900,
-                                            ui->action_Reset_Window_Size_1080});
+    ui->menu_Reset_Window_Size->addActions(
+        {ui->action_Reset_Window_Size_720, ui->action_Reset_Window_Size_800,
+         ui->action_Reset_Window_Size_900, ui->action_Reset_Window_Size_1080});
 
     // Multiplayer
     connect(ui->action_View_Lobby, &QAction::triggered, multiplayer_state,
@@ -3530,6 +3531,14 @@ void GMainWindow::ResetWindowSize720() {
     ResetWindowSize(Layout::ScreenUndocked::Width, Layout::ScreenUndocked::Height);
 }
 
+void GMainWindow::ResetWindowSize800() {
+    if (!ui->action_Single_Window_Mode->isChecked()) {
+        render_window->resize(1280, 800);
+    } else {
+        resize(1280, 800);
+    }
+}
+
 void GMainWindow::ResetWindowSize900() {
     ResetWindowSize(1600U, 900U);
 }

src/suyu/main.h

@@ -393,6 +393,7 @@ private slots:
     void ToggleWindowMode();
     void ResetWindowSize(u32 width, u32 height);
     void ResetWindowSize720();
+    void ResetWindowSize800();
     void ResetWindowSize900();
     void ResetWindowSize1080();
     void OnAlbum();

src/suyu/main.ui

@@ -45,7 +45,7 @@
      <x>0</x>
      <y>0</y>
      <width>1280</width>
-     <height>21</height>
+     <height>22</height>
     </rect>
    </property>
    <widget class="QMenu" name="menu_File">
@@ -102,6 +102,14 @@
      <property name="iconText">
       <string>Reset Window Size to 720p</string>
      </property>
+    </action>
+        <action name="action_Reset_Window_Size_800">
+     <property name="text">
+      <string>Reset Window Size to &amp;800p</string>
+     </property>
+     <property name="iconText">
+      <string>Reset Window Size to 800p</string>
+     </property>
     </action>
     <action name="action_Reset_Window_Size_900">
      <property name="text">
@@ -124,7 +132,7 @@
     <addaction name="action_Display_Dock_Widget_Headers"/>
     <addaction name="action_Show_Filter_Bar"/>
     <addaction name="action_Show_Status_Bar"/>
-    <addaction name="action_Show_Folders_In_List" />
+    <addaction name="action_Show_Folders_In_List"/>
     <addaction name="separator"/>
     <addaction name="menu_Reset_Window_Size"/>
     <addaction name="menu_View_Debugging"/>