tacosukoneko/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

decoders: Break instead of continue

Browse source 
continue causes a memory leak in A Hat in Time.
This commit is contained in:
lat9nq 2021-06-04 05:12:14 -04:00
parent 1feefabeba
commit 287a0f72a5
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/video_core/textures/decoders.cpp
View file

@ -66,9 +66,9 @@ void Swizzle(std::span<u8> output, std::span<const u8> input, u32 bytes_per_pixe
if (const auto offset = (TO_LINEAR ? unswizzled_offset : swizzled_offset); if (const auto offset = (TO_LINEAR ? unswizzled_offset : swizzled_offset);
offset >= input.size()) { offset >= input.size()) {
// TODO(Rodrigo): This is an out of bounds access that should never happen. To // TODO(Rodrigo): This is an out of bounds access that should never happen. To
// avoid crashing the emulator, continue. // avoid crashing the emulator, break.
ASSERT_MSG(false, "offset {} exceeds input size {}!", offset, input.size()); ASSERT_MSG(false, "offset {} exceeds input size {}!", offset, input.size());
continue; break;
} }
u8* const dst = &output[TO_LINEAR ? swizzled_offset : unswizzled_offset]; u8* const dst = &output[TO_LINEAR ? swizzled_offset : unswizzled_offset];