tacosukoneko/suyu
1
0
Fork 0
forked from suyu/suyu
Code Pull requests Activity

emit_spirv_image: Fix depth image implicit lod sample in compute

Browse source 
Ensures all drivers behave the same way in this case.
This commit is contained in:
ameerj 2021-09-24 20:38:43 -04:00
parent 3791c7ca82
commit 06894b0711
1 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/shader_recompiler/backend/spirv/emit_spirv_image.cpp
View file

@ -355,11 +355,22 @@ Id EmitImageSampleExplicitLod(EmitContext& ctx, IR::Inst* inst, const IR::Value&
Id EmitImageSampleDrefImplicitLod(EmitContext& ctx, IR::Inst* inst, const IR::Value& index, Id EmitImageSampleDrefImplicitLod(EmitContext& ctx, IR::Inst* inst, const IR::Value& index,
Id coords, Id dref, Id bias_lc, const IR::Value& offset) { Id coords, Id dref, Id bias_lc, const IR::Value& offset) {
const auto info{inst->Flags<IR::TextureInstInfo>()}; const auto info{inst->Flags<IR::TextureInstInfo>()};
const ImageOperands operands(ctx, info.has_bias != 0, false, info.has_lod_clamp != 0, bias_lc, if (ctx.stage == Stage::Fragment) {
offset); const ImageOperands operands(ctx, info.has_bias != 0, false, info.has_lod_clamp != 0,
return Emit(&EmitContext::OpImageSparseSampleDrefImplicitLod, bias_lc, offset);
&EmitContext::OpImageSampleDrefImplicitLod, ctx, inst, ctx.F32[1], return Emit(&EmitContext::OpImageSparseSampleDrefImplicitLod,
Texture(ctx, info, index), coords, dref, operands.MaskOptional(), operands.Span()); &EmitContext::OpImageSampleDrefImplicitLod, ctx, inst, ctx.F32[1],
Texture(ctx, info, index), coords, dref, operands.MaskOptional(),
operands.Span());
} else {
// Implicit lods in compute behave on hardware as if sampling from LOD 0.
// This check is to ensure all drivers behave this way.
const Id lod{ctx.Const(0.0f)};
const ImageOperands operands(ctx, false, true, false, lod, offset);
return Emit(&EmitContext::OpImageSparseSampleDrefExplicitLod,
&EmitContext::OpImageSampleDrefExplicitLod, ctx, inst, ctx.F32[1],
Texture(ctx, info, index), coords, dref, operands.Mask(), operands.Span());
}
} }
Id EmitImageSampleDrefExplicitLod(EmitContext& ctx, IR::Inst* inst, const IR::Value& index, Id EmitImageSampleDrefExplicitLod(EmitContext& ctx, IR::Inst* inst, const IR::Value& index,