suyu/suyu
188
214
Fork 31
Code Issues 116 Pull requests 6 Projects 1 Releases 2 Packages Wiki Activity Actions 1

Changing 2023 to 2024 (Android files) #27

Closed
Downloafy wants to merge 14 commits from Downloafy/suyu-forked:dev into dev
pull from: Downloafy/suyu-forked:dev
merge into: suyu:dev
Conversation 2 Commits 14 Files changed 14 +14 -14
Downloafy commented 2024-03-23 22:43:45 +01:00
First-time contributor
Copy link

If this is left unchanged this could be potentially copyrighted/dmcaed in these countries (CA/US/CHN)

If this is left unchanged this could be potentially copyrighted/dmcaed in these countries (CA/US/CHN)
Downloafy added 14 commits 2024-03-23 22:43:46 +01:00 
If this wasn't updated this could've been copyrighted
I gotta do them all manually.
Might get copyrighted if isn't changed
Might get copyrighted if not changed
might get copyrighted if not changed
might get copyrighted if not changed
might get copyrighted if not changed
might get copyrighted if not changed
might get copyrighted if not changed
might get copyrighted if not changed.
might get copyrighted if not changed.
might get copyrighted if not changed.
might get copyrighted if not changed.
might get copyrighted if not changed.
copyright
Some checks failed
suyu-ci / Check REUSE Specification (pull_request) Has been cancelled
Details
codespell / Check for spelling errors (pull_request) Has been cancelled
Details
suyu verify / Verify Format (pull_request) Has been cancelled
Details
suyu verify / test build (linux-fresh, clang) (pull_request) Has been cancelled
Details
suyu verify / test build (linux-fresh, linux) (pull_request) Has been cancelled
Details
suyu verify / test build (linux-mingw, windows) (pull_request) Has been cancelled
Details
suyu verify / android (pull_request) Has been cancelled
Details
c8a26934c4 
might get copyrighted if not changed.
Downloafy commented 2024-03-23 22:47:54 +01:00
Author
First-time contributor
Copy link

ill do the rest tomorrow as i dont have time right now

ill do the rest tomorrow as i dont have time right now
Fijxu commented 2024-03-23 22:55:10 +01:00
Contributor
Copy link

This is not correct licensing. For some reason JuanCStar in 88b901a24e just appended & 2024 suyu Emulator Project alongside SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project and Leon Denis in c41d9d62a3 literally changed everything from yuzu to suyu and that is not the way licensing works. You can't just change the name of the Organization/Natural Person. That code is from the people from yuzu and if anyone is going to make any changes they should append their own Organization/Name/Nickname bellow the original copyright text.

Those strings should keep as # SPDX-FileCopyrightText: 2023 yuzu Emulator Project and if we make any real changes to the code, # SPDX-FileCopyrightText: 2024 suyu Emulator Project should be appended in this kind of Format.

# SPDX-FileCopyrightText: 2023 yuzu Emulator Project
# SPDX-FileCopyrightText: 2024 suyu Emulator Project

The FSF would be pretty mad at us.

Also. Do not create 14 commits for little changes like this. You could literally put all those changes in a single commit.

This is not correct licensing. For some reason JuanCStar in 88b901a24ed489a4fb1f97f4ec9950697c3c83d1 just appended ` & 2024 suyu Emulator Project` alongside ` SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project` and Leon Denis in https://git.suyu.dev/suyu/suyu/commit/c41d9d62a33a37914e0361d6c81818ee18f31f26 literally changed everything from `yuzu` to `suyu` and that is not the way licensing works. You can't just change the name of the Organization/Natural Person. That code is from the people from yuzu and if anyone is going to make any changes they should append their own Organization/Name/Nickname bellow the original copyright text. Those strings should keep as `# SPDX-FileCopyrightText: 2023 yuzu Emulator Project` and if we make any real changes to the code, `# SPDX-FileCopyrightText: 2024 suyu Emulator Project` should be appended in this kind of Format. ``` # SPDX-FileCopyrightText: 2023 yuzu Emulator Project # SPDX-FileCopyrightText: 2024 suyu Emulator Project ``` The FSF would be pretty mad at us. Also. Do not create 14 commits for little changes like this. You could literally put all those changes in a single commit.
Fijxu added the
invalid
 label 2024-03-23 22:55:51 +01:00
million requested changes 2024-03-23 23:02:19 +01:00
million left a comment
First-time contributor
Copy link

I agree with what Fijxu said, this is a lawsuit waiting to happen

I agree with what Fijxu said, this is a lawsuit waiting to happen
Exverge closed this pull request 2024-03-23 23:20:18 +01:00
chaphidoesstuff added this to the suyu project 2024-10-02 13:05:32 +02:00
Some checks failed
suyu-ci / Check REUSE Specification (pull_request) Has been cancelled
Details
codespell / Check for spelling errors (pull_request) Has been cancelled
Details
suyu verify / Verify Format (pull_request) Has been cancelled
Details
suyu verify / test build (linux-fresh, clang) (pull_request) Has been cancelled
Details
suyu verify / test build (linux-fresh, linux) (pull_request) Has been cancelled
Details
suyu verify / test build (linux-mingw, windows) (pull_request) Has been cancelled
Details
suyu verify / android (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
million
Labels
Clear labels   
CI

   
Low Priority

   
Needs Approvals

   
Needs Rebase

   
android

Relating to the android build

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
translations

Relating to strings for different langauges

  
wontfix

This won't be fixed

No labels
CI
Low Priority
Needs Approvals
Needs Rebase
android
bug
duplicate
enhancement
help wanted
invalid
question
translations
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
suyu
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: suyu/suyu#27
No description provided.
Delete branch "Downloafy/suyu-forked:dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?