CMake external downloads fail #56

New Issue

Closed

opened 2024-03-25 01:44:54 +01:00 by darkshadow · 4 comments

darkshadow commented

2024-03-25 01:44:54 +01:00

Is there an existing issue for this?

I have searched the existing issues

Affected Commit or Release

everything since license-fix (#31)

Description of Issue

CMake fails to download the required external packages since PR #31 was merged. In that PR, the base URL in DownloadExternals.cmake was updated to be this repository, but more edits are actually needed. All of the package repo paths need to be changed as well since the way raw data is accessed is slightly different from the way Gitlab does it. Since it's slightly different the download fails as the file can't be found, and then CMake fails.

The package_repo lines need to be changed from -/raw to raw/branch
Also, the package_base_url line needs a trailing forward slash.

Expected Behavior

CMake downloads the external packages

Reproduction Steps

This will only be noticed when building the repository the first time (or if you remove the build folder) since anyone that has the downloads before this would already have the files and the downloads would be skipped.

Easiest way to reproduce it is to rename your build folder, make a new one, and try running CMake. CMake will fail when it tries to download the external packages.

Log File

System Configuration

Any

### Is there an existing issue for this? - [x] I have searched the existing issues ### Affected Commit or Release everything since license-fix (#31) ### Description of Issue CMake fails to download the required external packages since PR #31 was merged. In that PR, the base URL in `DownloadExternals.cmake` was updated to be this repository, but more edits are actually needed. All of the package repo paths need to be changed as well since the way raw data is accessed is slightly different from the way Gitlab does it. Since it's slightly different the download fails as the file can't be found, and then CMake fails. The `package_repo` lines need to be changed from `-/raw` to `raw/branch` Also, the `package_base_url` line __needs__ a trailing forward slash. ### Expected Behavior CMake downloads the external packages ### Reproduction Steps This will only be noticed when building the repository the first time (or if you remove the build folder) since anyone that has the downloads before this would already have the files and the downloads would be skipped. Easiest way to reproduce it is to rename your build folder, make a new one, and try running CMake. CMake will fail when it tries to download the external packages. ### Log File NA ### System Configuration Any

darkshadow added the

bug

label 2024-03-25 01:44:54 +01:00

Fijxu commented

2024-03-25 02:04:23 +01:00

Owner

You are absolutely right. In that commit I changed the git URL at line 10 from

set(package_base_url "https://gitlab.com/suyu-emu") to -> set(package_base_url "https://git.suyu.dev/suyu")

Thanks to that the others lines like

set(package_repo "ext-windows-bin/-/raw/master/")

set(package_repo "ext-linux-bin/-/raw/main/")

Were completely broken because forgejo does not use the same form of URLs that Gitlab uses. I am going to fix this ASAP.

Thanks for noticing out! And sorry for the inconvenience.

Related: #55

You are absolutely right. In that commit I changed the git URL at line `10` from `set(package_base_url "https://gitlab.com/suyu-emu")` to -> `set(package_base_url "https://git.suyu.dev/suyu")` Thanks to that the others lines like ``` set(package_repo "ext-windows-bin/-/raw/master/") ``` ``` set(package_repo "ext-linux-bin/-/raw/main/") ``` Were completely broken because forgejo does not use the same form of URLs that Gitlab uses. I am going to fix this ASAP. Thanks for noticing out! And sorry for the inconvenience. Related: #55

👍 1

darkshadow commented

2024-03-25 02:50:27 +01:00

Author

@Fijxu I see you posted a fix, but you missed the trailing forward slash on the base URL, and the downloads are still failing.

Line 10 needs to be set(package_base_url "https://git.suyu.dev/suyu/")

The way the script puts the URL together needs the trailing forward slash on the base URL, otherwise when it gets put together it becomes something like https://git.suyu.dev/suyuext-windows-bin/raw/master/ffmpeg-6.0.7z. That trailing forward slash is important ;)

@Fijxu I see you posted a fix, but you missed the trailing forward slash on the base URL, and the downloads are still failing. Line 10 needs to be `set(package_base_url "https://git.suyu.dev/suyu/")` The way the script puts the URL together __needs__ the trailing forward slash on the base URL, otherwise when it gets put together it becomes something like `https://git.suyu.dev/suyuext-windows-bin/raw/master/ffmpeg-6.0.7z`. That trailing forward slash is important ;)

Fijxu commented

2024-03-25 03:16:23 +01:00

Owner

@darkshadow Pull the repo and test it again if you can.