suyu/suyu
183
212
Fork 31
Code Issues 116 Pull requests 6 Projects 1 Releases 2 Packages Wiki Activity Actions 7

Comment out unimplemented check
Some checks failed
codespell / Check for spelling errors (push) Successful in 9s
Details
codespell / Check for spelling errors (pull_request) Successful in 10s
Details
suyu-ci / Check REUSE Specification (pull_request) Successful in 9s
Details
suyu verify / Verify Format (pull_request) Failing after 2m19s
Details
suyu verify / test build (linux-fresh, clang) (pull_request) Has been skipped
Details
suyu verify / test build (linux-fresh, linux) (pull_request) Has been skipped
Details
suyu verify / android (pull_request) Has been skipped
Details

Browse source 
In my testing on macOS, MK8 sometimes crashed at this function, giving a void type instead of u32.
I've temporarily commented this out until (if) this is implemented and added a check for if it is implemented
This commit is contained in:
Exverge 2024-03-30 19:34:32 -04:00
parent 48e86d6e84
commit 62f7da6c5d
Signed by: Exverge
GPG key ID: 19AAFC0AC6A9B35A
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/shader_recompiler/backend/spirv/emit_spirv_image.cpp
View file

@ -196,9 +196,9 @@ Id Texture(EmitContext& ctx, IR::TextureInstInfo info, [[maybe_unused]] const IR
} }
Id TextureImage(EmitContext& ctx, IR::TextureInstInfo info, const IR::Value& index) { Id TextureImage(EmitContext& ctx, IR::TextureInstInfo info, const IR::Value& index) {
if (!index.IsImmediate() || index.U32() != 0) { //if (!index.IsImmediate() || index.Type() == Shader::IR::Type::U32 || index.U32() != 0) {
throw NotImplementedException("Indirect image indexing"); // throw NotImplementedException("Indirect image indexing");
} //}
if (info.type == TextureType::Buffer) { if (info.type == TextureType::Buffer) {
const TextureBufferDefinition& def{ctx.texture_buffers.at(info.descriptor_index)}; const TextureBufferDefinition& def{ctx.texture_buffers.at(info.descriptor_index)};
if (def.count > 1) { if (def.count > 1) {
@ -215,9 +215,9 @@ Id TextureImage(EmitContext& ctx, IR::TextureInstInfo info, const IR::Value& ind
} }
std::pair<Id, bool> Image(EmitContext& ctx, const IR::Value& index, IR::TextureInstInfo info) { std::pair<Id, bool> Image(EmitContext& ctx, const IR::Value& index, IR::TextureInstInfo info) {
if (!index.IsImmediate() || index.U32() != 0) { //if (!index.IsImmediate() || index.Type() == Shader::IR::Type::U32 || index.U32() != 0) {
throw NotImplementedException("Indirect image indexing"); // throw NotImplementedException("Indirect image indexing");
} //}
if (info.type == TextureType::Buffer) { if (info.type == TextureType::Buffer) {
const ImageBufferDefinition def{ctx.image_buffers.at(info.descriptor_index)}; const ImageBufferDefinition def{ctx.image_buffers.at(info.descriptor_index)};
return {ctx.OpLoad(def.image_type, def.id), def.is_integer}; return {ctx.OpLoad(def.image_type, def.id), def.is_integer};