From e85a08ec345ab3c350c05c2646dd7f323afee826 Mon Sep 17 00:00:00 2001
From: MerryMage <MerryMage@users.noreply.github.com>
Date: Thu, 21 May 2020 22:31:54 +0100
Subject: [PATCH] CMakeLists: MSVC: Weaken warning level for externals

---
 CMakeLists.txt           | 15 +++++++++------
 externals/CMakeLists.txt |  4 +++-
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index bb1e696a..5e1458ce 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -45,14 +45,17 @@ list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/CMakeModules")
 if (MSVC)
     set(DYNARMIC_CXX_FLAGS
         /std:c++latest # CMAKE_CXX_STANDARD has no effect on MSVC until CMake 3.10.
+        /experimental:external
+        /external:W0
+        /external:anglebrackets
         /W4
-        /w34263 # Non-virtual member function hides base class virtual function
+        /w44263 # Non-virtual member function hides base class virtual function
         /w44265 # Class has virtual functions, but destructor is not virtual
-        /w34456 # Declaration of 'var' hides previous local declaration
-        /w34457 # Declaration of 'var' hides function parameter
-        /w34458 # Declaration of 'var' hides class member
-        /w34459 # Declaration of 'var' hides global definition
-        /w34946 # Reinterpret-cast between related types
+        /w44456 # Declaration of 'var' hides previous local declaration
+        /w44457 # Declaration of 'var' hides function parameter
+        /w44458 # Declaration of 'var' hides class member
+        /w44459 # Declaration of 'var' hides global definition
+        /w44946 # Reinterpret-cast between related types
         /wd4592 # Symbol will be dynamically initialized (implementation limitation)
         /permissive- # Stricter C++ standards conformance
         /MP
diff --git a/externals/CMakeLists.txt b/externals/CMakeLists.txt
index afdf1656..2fb4f1ea 100644
--- a/externals/CMakeLists.txt
+++ b/externals/CMakeLists.txt
@@ -21,7 +21,9 @@ target_include_directories(mp INTERFACE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE
 
 # robin-map
 
-add_subdirectory(robin-map)
+add_library(robin_map INTERFACE)
+add_library(tsl::robin_map ALIAS robin_map)
+target_include_directories(robin_map SYSTEM INTERFACE "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/robin-map/include>")
 
 # xbyak