suyu/dynarmic
28
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity

x64/reg_alloc: Use type alias for array returned by GetArgumentInfo()

Browse source 
This way if the number ever changes, we don't need to change the type in
other places.
This commit is contained in:
Lioncash 2018-08-13 11:10:34 -04:00 committed by MerryMage
parent 2188765e28
commit c41b5a3492
3 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/backend_x64/emit_x64_aes.cpp
View file

@ -19,7 +19,7 @@ namespace AES = Common::Crypto::AES;
using AESFn = void(AES::State&, const AES::State&);
static void EmitAESFunction(std::array<Argument, 3> args, EmitContext& ctx, BlockOfCode& code,
static void EmitAESFunction(RegAlloc::ArgumentInfo args, EmitContext& ctx, BlockOfCode& code,
IR::Inst* inst, AESFn fn) {
constexpr u32 stack_space = static_cast<u32>(sizeof(AES::State)) * 2;
const Xbyak::Xmm input = ctx.reg_alloc.UseXmm(args[0]);

4
src/backend_x64/reg_alloc.cpp
View file

@ -208,8 +208,8 @@ bool Argument::IsInMemory() const {
return HostLocIsSpill(*reg_alloc.ValueLocation(value.GetInst()));
}
std::array<Argument, 3> RegAlloc::GetArgumentInfo(IR::Inst* inst) {
std::array<Argument, 3> ret = { Argument{*this}, Argument{*this}, Argument{*this} };
RegAlloc::ArgumentInfo RegAlloc::GetArgumentInfo(IR::Inst* inst) {
ArgumentInfo ret = { Argument{*this}, Argument{*this}, Argument{*this} };
for (size_t i = 0; i < inst->NumArgs(); i++) {
const IR::Value& arg = inst->GetArg(i);
ret[i].value = arg;

4
src/backend_x64/reg_alloc.h
View file

@ -91,10 +91,12 @@ private:
class RegAlloc final {
public:
using ArgumentInfo = std::array<Argument, 3>;
explicit RegAlloc(BlockOfCode& code, size_t num_spills, std::function<Xbyak::Address(HostLoc)> spill_to_addr)
: hostloc_info(NonSpillHostLocCount + num_spills), code(code), spill_to_addr(std::move(spill_to_addr)) {}
std::array<Argument, 3> GetArgumentInfo(IR::Inst* inst);
ArgumentInfo GetArgumentInfo(IR::Inst* inst);
Xbyak::Reg64 UseGpr(Argument& arg);
Xbyak::Xmm UseXmm(Argument& arg);