suyu/dynarmic
28
1
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity

intrusive_list: Get rid of unnecessary static_casts

Browse source 
The only valid objects to add to the list are those that inherit from
IntrusiveListNode. Therefore anything being added to the list that isn't
inheriting from it will cause compilation to fail.
This commit is contained in:
Lioncash 2016-08-18 10:14:29 -04:00 committed by MerryMage
parent 67509935f6
commit 95a83543f2
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/common/intrusive_list.h
View file

@ -47,7 +47,7 @@ public:
* @param node Node to add to the list.
*/
void Prepend(T& node) {
AddAfter(root.get(), static_cast<IntrusiveListNode<T>*>(&node));
AddAfter(root.get(), &node);
}
/**
@ -55,7 +55,7 @@ public:
* @param node Node to add to the list.
*/
void Append(T& node) {
AddBefore(root.get(), static_cast<IntrusiveListNode<T>*>(&node));
AddBefore(root.get(), &node);
}
/**
@ -64,7 +64,7 @@ public:
* @param new_node Node to add to the list.
*/
void AddAfter(T& existing, T& node) {
AddAfter(static_cast<IntrusiveListNode<T>*>(&existing), static_cast<IntrusiveListNode<T>*>(&node));
AddAfter(&existing, &node);
}
/**
@ -73,7 +73,7 @@ public:
* @param new_node Node to add to the list.
*/
void AddBefore(T& existing, T& node) {
AddBefore(static_cast<IntrusiveListNode<T>*>(&existing), static_cast<IntrusiveListNode<T>*>(&node));
AddBefore(&existing, &node);
}
/**
@ -208,7 +208,7 @@ IntrusiveListIterator<T> IntrusiveList<T>::erase(const IntrusiveListIterator<T>&
template <typename T>
IntrusiveListIterator<T> IntrusiveList<T>::iterator_to(T& item) {
return IntrusiveListIterator<T>(root.get(), static_cast<IntrusiveListNode<T>*>(&item));
return IntrusiveListIterator<T>(root.get(), &item);
}
template <typename T>
@ -223,7 +223,7 @@ IntrusiveListIterator<T> IntrusiveList<T>::end() const {
template <typename T>
IntrusiveListIterator<T> IntrusiveList<T>::iterator_to(T& item) const {
return IntrusiveListIterator<T>(root.get(), static_cast<IntrusiveListNode<T>*>(&item));
return IntrusiveListIterator<T>(root.get(), &item);
}
} // namespace Common