diff --git a/src/frontend/decoder/thumb1.h b/src/frontend/decoder/thumb1.h index bffc64d6..248d6c3c 100644 --- a/src/frontend/decoder/thumb1.h +++ b/src/frontend/decoder/thumb1.h @@ -56,7 +56,7 @@ private: }; template -static const std::array, 23> g_thumb1_instruction_table {{ +static const std::array, 24> g_thumb1_instruction_table {{ #define INST(fn, name, bitstring) detail::detail::GetMatcher(name, bitstring) @@ -84,7 +84,7 @@ static const std::array, 23> g_thumb1_instruction_table {{ { INST(&V::thumb1_ROR_reg, "ROR (reg)", "0100000111sssddd") }, { INST(&V::thumb1_TST_reg, "TST (reg)", "0100001000mmmnnn") }, { INST(&V::thumb1_RSB_imm, "RSB (imm)", "0100001001nnnddd") }, - //{ INST(&V::thumb1_CMP_rr, "CMP (rr)", "0100001010mmmnnn") }, + { INST(&V::thumb1_CMP_reg, "CMP (reg)", "0100001010mmmnnn") }, //{ INST(&V::thumb1_CMN_rr, "CMN (rr)", "0100001011mmmnnn") }, //{ INST(&V::thumb1_ORRS_rr, "ORRS (rr)", "0100001100mmmddd") }, //{ INST(&V::thumb1_MULS_rr, "MULS (rr)", "0100001101mmmddd") }, diff --git a/src/frontend/disassembler_thumb.cpp b/src/frontend/disassembler_thumb.cpp index 82e141db..632a89f4 100644 --- a/src/frontend/disassembler_thumb.cpp +++ b/src/frontend/disassembler_thumb.cpp @@ -187,6 +187,10 @@ public: return Common::StringFromFormat("rsbs %s, %s, #0", RegStr(d), RegStr(n)); } + std::string thumb1_CMP_reg(Reg m, Reg n) { + return Common::StringFromFormat("cmp %s, %s", RegStr(n), RegStr(m)); + } + std::string thumb1_ADD_reg_t2(bool d_n_hi, Reg m, Reg d_n_lo) { Reg d_n = d_n_hi ? (d_n_lo + 8) : d_n_lo; return Common::StringFromFormat("add %s, %s", RegStr(d_n), RegStr(m)); diff --git a/src/frontend/translate_thumb.cpp b/src/frontend/translate_thumb.cpp index 8641c575..6cf9a3bf 100644 --- a/src/frontend/translate_thumb.cpp +++ b/src/frontend/translate_thumb.cpp @@ -269,6 +269,15 @@ struct TranslatorVisitor final { ir.SetVFlag(result.overflow); return true; } + bool thumb1_CMP_reg(Reg m, Reg n) { + // CMP , + auto result = ir.SubWithCarry(ir.GetRegister(n), ir.GetRegister(m), ir.Imm1(1)); + ir.SetNFlag(ir.MostSignificantBit(result.result)); + ir.SetZFlag(ir.IsZero(result.result)); + ir.SetCFlag(result.carry); + ir.SetVFlag(result.overflow); + return true; + } bool thumb1_ADD_reg_t2(bool d_n_hi, Reg m, Reg d_n_lo) { Reg d_n = d_n_hi ? (d_n_lo + 8) : d_n_lo;