suyu/breakpad
26
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
No description
1957 commits 1 branch 0 tags 15 MiB
C++ 70.3%
Makefile 13.4%
C 5%
Shell 4.4%
Objective-C 3.1%
Other 3.7%
Find a file
Zequan Wu 54d878abcb Fix incorrect source file name for inlined frames 
Processor shows incorrect source file name if a frame have an inlined
frame and their source files are different.
Consider this example:
FILE 0 /tmp/a.h
FILE 1 /tmp/a.cpp
INLINE_ORIGIN 0 0 foo()
FUNC 1110 a 0 main
INLINE 0 22 0 1110 7
1110 7 3 0
1117 3 23 1

When querying the address 0x1110, we know this line 0x1110 corresponds
to /tmp/a.h line 3 and it's inside a inlined function foo() which is
defined at /tmp/a.h and called at line 22. But we don't know at which
file it's being called at line 22. So, we will get stacks like this:
void foo() /tmp/a.h:3
int main() /tmp/a.h:22

The correct stacks should be this:
void foo() /tmp/a.h:3
int main() /tmp/a.cpp:22

In this change:
1. Remove file_id field for INLINE_ORIGIN record.
2. Add call_site_file_id for INLINE record to represents the file where
this call being inlined.

After adding call_site_file_id to it (as third field), it looks like
this:
FILE 0 /tmp/a.h
FILE 1 /tmp/a.cpp
INLINE_ORIGIN 0 foo()
FUNC 1110 a 0 main
INLINE 0 22 1 0 1110 7
1110 7 3 0
1117 3 23 1

Bug: 1190878
Change-Id: Ibbb697d2f7e1b6ac3208cac6fae4353c8743198d
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3232838
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2021-10-20 21:15:06 +00:00
.github/workflows CI: convert Travis to GH actions 2021-10-14 09:00:39 +00:00
android Use breakpad_getcontext on all Linux platforms missing getcontext 2020-03-16 21:27:07 +00:00
autotools Fix Travis build by running tests as root 2018-02-20 11:08:52 +00:00
docs core_handler: coredump handler to produce minidump 2020-11-23 23:15:15 +00:00
m4 Only use O_CLOEXEC on platforms that support it 2017-05-10 21:32:37 +00:00
src Fix incorrect source file name for inlined frames 2021-10-20 21:15:06 +00:00
.clang-format Add a .clang-format file to give us local control over Chromium style. 2020-08-31 18:46:34 +00:00
.gitignore Add core_handler and pid2md into git ignore 2021-02-06 15:06:11 +00:00
aclocal.m4 Add src/processor/stackwalk_common.{cc,h} to src_libbreakpad_a_SOURCES 2021-01-29 12:43:57 +00:00
appveyor.yml Appveyor CI for Windows MSVS build 2017-02-13 17:57:15 +00:00
AUTHORS Make build system less annoying (#8) r=bryner 2006-08-30 20:05:05 +00:00
breakpad-client.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
breakpad.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
ChangeLog Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
codereview.settings codereview.settings: do not force squashing behavior 2019-08-14 17:56:21 +00:00
configure Do not build core_handler unless memfd_create is available 2020-12-21 22:07:02 +00:00
configure.ac Do not build core_handler unless memfd_create is available 2020-12-21 22:07:02 +00:00
default.xml gtest: update to 1.11 release 2021-10-14 15:56:05 +00:00
DEPS gtest: update to 1.11 release 2021-10-14 15:56:05 +00:00
INSTALL autoreconf -f -i 2013-12-10 17:53:50 +00:00
LICENSE There are source files with APSL-2.0 as well. 2020-07-17 01:32:59 +00:00
Makefile.am Consistently call BaseName() in various Usage() functions. 2021-04-07 20:37:52 +00:00
Makefile.in Consistently call BaseName() in various Usage() functions. 2021-04-07 20:37:52 +00:00
NEWS Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
OWNERS add OWNERS settings 2021-06-03 16:26:13 +00:00
README.ANDROID Update symbol file documentation links. 2016-06-10 06:29:06 -04:00
README.md CI: convert Travis to GH actions 2021-10-14 09:00:39 +00:00

README.md

Breakpad

Breakpad is a set of client and server components which implement a crash-reporting system.

Getting started (from main)

  1. First, download depot_tools and ensure that they’re in your PATH.

  2. Create a new directory for checking out the source code (it must be named breakpad).

    mkdir breakpad && cd breakpad

  3. Run the fetch tool from depot_tools to download all the source repos.

    fetch breakpad
cd src

  4. Build the source.

    ./configure && make

    You can also cd to another directory and run configure from there to build outside the source tree.

    This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).

  5. Optionally, run tests.

    make check

  6. Optionally, install the built libraries

    make install

If you need to reconfigure your build be sure to run make distclean first.

To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.

To request change review

  1. Follow the steps above to get the source and build it.

  2. Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.

  3. Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.

  4. At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.