suyu/breakpad
26
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
No description
1595 commits 1 branch 0 tags 15 MiB
C++ 70.3%
Makefile 13.4%
C 5%
Shell 4.4%
Objective-C 3.1%
Other 3.7%
Find a file
Mike Frysinger 4e82b6fa11 minidump: mark Read as override in derived classes 
The base class here declares Read as virtual, so make sure it's
marked as override in the derived classes.  This fixes some build
errors with clang.

src/google_breakpad/processor/minidump.h:853:8: error:
  'Read' overrides a member function but is not marked 'override'
  [-Werror,-Winconsistent-missing-override]
  bool Read(uint32_t expected_size_);
       ^
src/google_breakpad/processor/minidump.h:153:16: note:
  overridden virtual function is here
  virtual bool Read(uint32_t expected_size) = 0;
               ^

Change-Id: Ie4e5fec097b7f37739433a9deb39e7ed60471461
Reviewed-on: https://chromium-review.googlesource.com/444385
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
2017-02-20 18:03:14 +00:00
android sample_app: enable C++11 for Android builds 2016-04-04 21:35:26 -04:00
autotools autotools: refresh config.{sub,guess} 2017-02-06 13:57:59 -05:00
docs Update links 2016-11-18 17:24:37 +00:00
m4 autotools: move -W flags to configure detection 2017-02-16 22:48:56 +00:00
scripts travis: add a clang build 2017-02-17 16:53:16 +00:00
src minidump: mark Read as override in derived classes 2017-02-20 18:03:14 +00:00
.gitignore GitIgnore: Add dump_syms_mac 2016-11-14 20:16:05 +00:00
.travis.yml travis: add a clang build 2017-02-17 16:53:16 +00:00
aclocal.m4 autotools: move -W flags to configure detection 2017-02-16 22:48:56 +00:00
appveyor.yml Appveyor CI for Windows MSVS build 2017-02-13 17:57:15 +00:00
AUTHORS Make build system less annoying (#8) r=bryner 2006-08-30 20:05:05 +00:00
breakpad-client.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
breakpad.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
ChangeLog Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
codereview.settings Switch to Gerrit for code reviews 2016-07-27 20:07:49 +00:00
configure autotools: move -W flags to configure detection 2017-02-16 22:48:56 +00:00
configure.ac autotools: move -W flags to configure detection 2017-02-16 22:48:56 +00:00
default.xml Upgrade google test to 1.8.0 2016-11-23 23:04:33 +00:00
DEPS Appveyor CI for Windows MSVS build 2017-02-13 17:57:15 +00:00
INSTALL autoreconf -f -i 2013-12-10 17:53:50 +00:00
LICENSE Renaming file COPYING to LICENSE and appending the disclaimer from src/common/convert_UTF.h to LICENSE. 2014-02-27 19:23:16 +00:00
Makefile.am autotools: move -W flags to configure detection 2017-02-16 22:48:56 +00:00
Makefile.in autotools: move -W flags to configure detection 2017-02-16 22:48:56 +00:00
NEWS Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
README.ANDROID Update symbol file documentation links. 2016-06-10 06:29:06 -04:00
README.md Appveyor CI for Windows MSVS build 2017-02-13 17:57:15 +00:00

README.md

Breakpad

Breakpad is a set of client and server components which implement a crash-reporting system.

Getting started (from master)

  1. First, download depot_tools and ensure that they’re in your PATH.

  2. Create a new directory for checking out the source code (it must be named breakpad).

    mkdir breakpad && cd breakpad

  3. Run the fetch tool from depot_tools to download all the source repos.

    fetch breakpad
cd src

  4. Build the source.

    ./configure && make

    You can also cd to another directory and run configure from there to build outside the source tree.

    This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).

  5. Optionally, run tests.

    make check

  6. Optionally, install the built libraries

    make install

If you need to reconfigure your build be sure to run make distclean first.

To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.

To request change review

  1. Follow the steps above to get the source and build it.

  2. Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.

  3. Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.

  4. At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.