suyu/breakpad
26
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

upload_system_symbols: Don't retry if file already exists on the server

Browse source 
Bug: 1400770
Change-Id: I4c9c683c91848f7eb404ff3c86187dfa63d06e37
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4117730
Reviewed-by: Robert Sesek <rsesek@chromium.org>
This commit is contained in:
Leonard Grey 2022-12-21 09:12:13 -05:00
parent 79326ebe94
commit d91b6cb75a
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/tools/mac/upload_system_symbols/upload_system_symbols.go
View file

@ -229,6 +229,11 @@ func (uq *UploadQueue) worker() {
// Success. No retry needed.
fmt.Printf("Uploaded %s to %s\n", symfile, server)
break
} else if exitError, ok := err.(*exec.ExitError); ok && exitError.ExitCode() == 2 && *apiKey != "" {
// Exit code 2 in protocol v2 means the file already exists on the server.
// No point retrying.
fmt.Printf("File %s already exists on %s\n", symfile, server)
break
} else {
log.Printf("Error running symupload(%s, %s), attempt %d: %v: %s\n", symfile, server, i, err, output)
time.Sleep(1 * time.Second)