suyu/breakpad
26
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fixing minidump_dump to handle nacl dumps.

Browse source 
Since nacl was not listed in decoding the code identifier, minidump_dump
produces errors like this (and non-zero return code):
2013-09-05 13:41:04: minidump.cc:2044: ERROR: MinidumpModule code_identifier
requires known platform, found 0x8205

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3424
TEST=tested with minidumps from nacl locally
R=mark@chromium.org,mseaborn@chromium.org

Review URL: https://breakpad.appspot.com/628002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1211 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
bradnelson@chromium.org 2013-09-05 22:04:05 +00:00
parent 24c6c0aaef
commit ae35566b8d
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/processor/minidump.cc
View file

@ -2029,6 +2029,7 @@ string MinidumpModule::code_identifier() const {
case MD_OS_SOLARIS: case MD_OS_SOLARIS:
case MD_OS_ANDROID: case MD_OS_ANDROID:
case MD_OS_LINUX: case MD_OS_LINUX:
case MD_OS_NACL:
case MD_OS_PS3: { case MD_OS_PS3: {
// TODO(mmentovai): support uuid extension if present, otherwise fall // TODO(mmentovai): support uuid extension if present, otherwise fall
// back to version (from LC_ID_DYLIB?), otherwise fall back to something // back to version (from LC_ID_DYLIB?), otherwise fall back to something