From 83a55520607edb9ec8a5d0c3c31821236a076312 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Tue, 21 Jun 2016 11:14:28 -0400 Subject: [PATCH] travis: add coverity scan integration R=ted.mielczarek@gmail.com Review URL: https://codereview.chromium.org/2078283002 . --- .travis.yml | 10 +++++++++- README.md | 1 + scripts/travis-build.sh | 24 ++++++++++++++++++++++++ 3 files changed, 34 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 34691284..a92dc735 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,6 +1,9 @@ # Travis build integration. # https://docs.travis-ci.com/ language: cpp + +# Order here matters for implicit matrix generation and coverity scan. +# See scripts/travis-build.sh for details. # TODO: add a clang build as well. compiler: - gcc @@ -15,9 +18,14 @@ addons: # selection. If clang is added, this should move to be set inside the # matrix. env: - - USE_CC=gcc-4.8 USE_CXX=g++-4.8 + global: + - secure: "FPczJ1u7FWGXOtUVf5AONeexfQDYnKRtuNs3phLwlPPAbgAlIc/WeTRSHC8DAb1T8IyPdN3Zi7cqLz0dvPol0iX1fWSfr8YdtW0ea8nUYH5ldmmp6H75FEUJUcISmYwL4WN7TldC6Hnzrlbw/0xmBH8gtAgddtBXKc9P9SwEZvM4OiFMHbMPwZEhRj+D95rfH12lgh3D16nbXGnx3rSNbHszvIxrU2VvlLo9Aa+hbmVj5CsBiNJjhDS64ie+VMTkuzcWNqLRYaGOCQ8ftKAlj/fjGfoKjPDN9dSJg9gW1FjOMPeQo93qhSc/hCmTq7sWxBJu48telinUgESdE5q/8gRf5J05ImWPntZAkC/wQkA20K7Kp/fH1CRaYXQMWKjts8c6dQZ5R4WxE4WXUo5rz573Ti9uyVTLys9whnzaib3YbqYv04irkhpgzo3rd8PF8SXpgK99ySQCcv/Dh7UQuXPpcaknOk2mBySXjQDgpQHHXDN2uUek1HEo5xit8fQuQw3TdPIZ9ZgzQ/c5/Dx6sLWAGEfVH9MN+hy6AiZnJ1JI+XF82kAf1pnf8WddHtlE7pAdWRFQt0iOj9T9esV1/o0VCJVzJLRdpKecF0sTpJxDuan6cFI0tNCkNjHFA5wJKYAvdOPAmYkqre7aIIqSOKy3Fjh9JP9CBJFy7eals9U=" + matrix: + - USE_CC=gcc-4.8 USE_CXX=g++-4.8 before_install: ./scripts/travis-checkout.sh script: ./scripts/travis-build.sh + +# Order here matters; see compiler comment above. # TODO: add mac support os: - linux diff --git a/README.md b/README.md index ce30a6e3..f1db2993 100644 --- a/README.md +++ b/README.md @@ -9,6 +9,7 @@ crash-reporting system. * Discussion/Questions: [google-breakpad-discuss@googlegroups.com](https://groups.google.com/d/forum/google-breakpad-discuss) * Developer/Reviews: [google-breakpad-dev@googlegroups.com](https://groups.google.com/d/forum/google-breakpad-dev) * Tests: [![Build Status](https://travis-ci.org/google/breakpad.svg?branch=master)](https://travis-ci.org/google/breakpad) +* Coverage [![Coverity Status](https://scan.coverity.com/projects/9215/badge.svg)](https://scan.coverity.com/projects/google-breakpad) ## Getting started (from master) diff --git a/scripts/travis-build.sh b/scripts/travis-build.sh index e994fe7b..6d16e14e 100755 --- a/scripts/travis-build.sh +++ b/scripts/travis-build.sh @@ -19,6 +19,26 @@ setup_env() { export JOBS=$(( $NCPUS < 4 ? $NCPUS : 4 )) } +# We have to do this by hand rather than use the coverity addon because of +# matrix explosion: https://github.com/travis-ci/travis-ci/issues/1975 +coverity_scan() { + if [ "${TRAVIS_JOB_NUMBER##*.}" != "1" ] || \ + [ -n "${TRAVIS_TAG}" ] || \ + [ "${TRAVIS_PULL_REQUEST}" = "true" ] + then + echo "Skipping coverity scan." + return + fi + + export COVERITY_SCAN_PROJECT_NAME="${TRAVIS_REPO_SLUG}" + export COVERITY_SCAN_NOTIFICATION_EMAIL="google-breakpad-dev@googlegroups.com" + export COVERITY_SCAN_BUILD_COMMAND="build" + export COVERITY_SCAN_BUILD_COMMAND_PREPEND="git clean -q -x -d -f; git checkout -f" + export COVERITY_SCAN_BRANCH_PATTERN="master" + + curl -s "https://scan.coverity.com/scripts/travisci_build_coverity_scan.sh" | bash || : +} + # Do an in-tree build and make sure tests pass. build() { ./configure @@ -38,6 +58,10 @@ main() { setup_env build build_out_of_tree + + # Do scans last as they like to dirty the tree and some tests + # expect a clean tree (like code style checks). + coverity_scan } main "$@"