Correct native symbol upload and UUID.
The auto-detection of the UUID was missing the extra "0" added for compatibility reasons. The native upload also was sending malformed HTTP. Change-Id: I8c261fc525f0f0086f269f2dee02941dd55488cb Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2739320 Reviewed-by: Nelson Billing <nbilling@google.com> Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
parent
46f4b593ee
commit
7279404aea
2 changed files with 5 additions and 8 deletions
|
@ -50,13 +50,7 @@
|
||||||
|
|
||||||
//=============================================================================
|
//=============================================================================
|
||||||
- (NSData*)bodyData {
|
- (NSData*)bodyData {
|
||||||
NSMutableData* postBody = [NSMutableData data];
|
return [NSData dataWithContentsOfFile:file_];
|
||||||
|
|
||||||
[HTTPRequest appendFileToBodyData:postBody
|
|
||||||
withName:@"symbol_file"
|
|
||||||
withFileOrData:file_];
|
|
||||||
|
|
||||||
return postBody;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
@end
|
@end
|
||||||
|
|
|
@ -307,6 +307,10 @@ string DumpSymbols::Identifier() {
|
||||||
i = compacted.find('-', i))
|
i = compacted.find('-', i))
|
||||||
compacted.erase(i, 1);
|
compacted.erase(i, 1);
|
||||||
|
|
||||||
|
// The pdb for these IDs has an extra byte, so to make everything uniform put
|
||||||
|
// a 0 on the end of mac IDs.
|
||||||
|
compacted += "0";
|
||||||
|
|
||||||
return compacted;
|
return compacted;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -411,7 +415,6 @@ bool DumpSymbols::CreateEmptyModule(scoped_ptr<Module>& module) {
|
||||||
string identifier = Identifier();
|
string identifier = Identifier();
|
||||||
if (identifier.empty())
|
if (identifier.empty())
|
||||||
return false;
|
return false;
|
||||||
identifier += "0";
|
|
||||||
|
|
||||||
// Create a module to hold the debugging information.
|
// Create a module to hold the debugging information.
|
||||||
module.reset(new Module(module_name,
|
module.reset(new Module(module_name,
|
||||||
|
|
Loading…
Reference in a new issue