suyu/breakpad
26
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix sign-compare compiler warning in MicrodumpWriterTest

Browse source 
Commit 7a8980997d introduced additional
tests into MicrodumpWriterTest, two of which throw warnings which break
"make check" under default settings on Linux, because the Makefiles are
configured with -Werror=sign-compare.

This patch just makes the signedness of the assertion arguments match.

Change-Id: Ib522f44205c84f91bc9b93276fad60ebbf005f60
Reviewed-on: https://chromium-review.googlesource.com/418938
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
Mike Percy 2016-12-10 02:21:15 +00:00 committed by Mike Frysinger
parent c13d6fa467
commit 5c42d7288a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/client/linux/microdump_writer/microdump_writer_unittest.cc
View file

@ -246,7 +246,7 @@ TEST(MicrodumpWriterTest, NoOutputIfUninteresting) {
MappingList no_mappings;
CrashAndGetMicrodump(no_mappings, kMicrodumpExtraInfo, &buf);
ASSERT_EQ(0, buf.size());
ASSERT_EQ(0U, buf.size());
}
// Ensure that output occurs if the interest region is set, and
@ -268,7 +268,7 @@ TEST(MicrodumpWriterTest, OutputIfInteresting) {
MappingList no_mappings;
CrashAndGetMicrodump(no_mappings, kMicrodumpExtraInfo, &buf);
ASSERT_LT(0, buf.size());
ASSERT_LT(0U, buf.size());
}
// Ensure that the product info and build fingerprint metadata show up in the