suyu/breakpad
26
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Windows: Fix remaining level 4 warnings.

Browse source 
R=mark@chromium.org

Review URL: https://breakpad.appspot.com/954002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1267 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
thestig@chromium.org 2013-12-18 22:43:56 +00:00
parent 74f640a92e
commit 4a0f9bf030
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/common/windows/pdb_source_line_writer.cc
View file

@ -36,6 +36,8 @@
#include <ImageHlp.h> #include <ImageHlp.h>
#include <stdio.h> #include <stdio.h>
#include <limits>
#include "common/windows/dia_util.h" #include "common/windows/dia_util.h"
#include "common/windows/guid_string.h" #include "common/windows/guid_string.h"
#include "common/windows/string_utils-inl.h" #include "common/windows/string_utils-inl.h"
@ -390,10 +392,10 @@ bool PDBSourceLineWriter::PrintFrameData() {
if (!FindTable(session_, &frame_data_enum)) if (!FindTable(session_, &frame_data_enum))
return false; return false;
DWORD last_type = -1; DWORD last_type = std::numeric_limits<DWORD>::max()
DWORD last_rva = -1; DWORD last_rva = std::numeric_limits<DWORD>::max()
DWORD last_code_size = 0; DWORD last_code_size = 0;
DWORD last_prolog_size = -1; DWORD last_prolog_size = std::numeric_limits<DWORD>::max()
CComPtr<IDiaFrameData> frame_data; CComPtr<IDiaFrameData> frame_data;
ULONG count = 0; ULONG count = 0;

2
src/tools/windows/symupload/symupload.cc
View file

@ -153,7 +153,7 @@ static bool DumpSymbolsToTempFile(const wchar_t *file,
return writer.GetModuleInfo(pdb_info); return writer.GetModuleInfo(pdb_info);
} }
void printUsageAndExit() { __declspec(noreturn) void printUsageAndExit() {
wprintf(L"Usage: symupload [--timeout NN] <file.exe|file.dll> <symbol upload URL>\n\n"); wprintf(L"Usage: symupload [--timeout NN] <file.exe|file.dll> <symbol upload URL>\n\n");
wprintf(L"Timeout is in milliseconds, or can be 0 to be unlimited\n\n"); wprintf(L"Timeout is in milliseconds, or can be 0 to be unlimited\n\n");
wprintf(L"Example:\n\n\tsymupload.exe --timeout 0 chrome.dll http://no.free.symbol.server.for.you\n"); wprintf(L"Example:\n\n\tsymupload.exe --timeout 0 chrome.dll http://no.free.symbol.server.for.you\n");