suyu/breakpad
26
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove usages of make_unique

Browse source 
Building fails for some people because configure requires c++11 but make_unique is a c++14 feature.

Change-Id: I23ce689fc92e9e90a95e7643ff29602f6b32ccbb
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3107784
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
This commit is contained in:
Zequan Wu 2021-08-19 11:48:16 -07:00 committed by Joshua Peraza
parent 524a6249f0
commit 4959def222
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/common/dwarf_cu_to_module.cc
View file

@ -766,9 +766,9 @@ void DwarfCUToModule::InlineHandler::Finish() {
Module::InlineOrigin* origin = Module::InlineOrigin* origin =
cu_context_->file_context->file_private_->inline_origin_map cu_context_->file_context->file_private_->inline_origin_map
.GetOrCreateInlineOrigin(specification_offset_, name_); .GetOrCreateInlineOrigin(specification_offset_, name_);
unique_ptr<Module::Inline> in = std::make_unique<Module::Inline>( unique_ptr<Module::Inline> in(
origin, ranges, call_site_line_, inline_nest_level_, new Module::Inline(origin, ranges, call_site_line_, inline_nest_level_,
std::move(child_inlines_)); std::move(child_inlines_)));
inlines_.push_back(std::move(in)); inlines_.push_back(std::move(in));
} }

2
src/processor/basic_source_line_resolver.cc
View file

@ -258,7 +258,7 @@ int BasicSourceLineResolver::Module::ConstructInlineFrames(
new_frame.trust = StackFrame::FRAME_TRUST_INLINE; new_frame.trust = StackFrame::FRAME_TRUST_INLINE;
// Must add frames before calling ConstructInlineFrames to get correct order. // Must add frames before calling ConstructInlineFrames to get correct order.
int current_idx = inlined_frames->size(); int current_idx = inlined_frames->size();
inlined_frames->push_back(std::make_unique<StackFrame>(new_frame)); inlined_frames->push_back(unique_ptr<StackFrame>(new StackFrame(new_frame)));
int source_line = ConstructInlineFrames(&new_frame, address, int source_line = ConstructInlineFrames(&new_frame, address,
in->child_inlines, inlined_frames); in->child_inlines, inlined_frames);
if (source_line != -1) { if (source_line != -1) {