diff --git a/src/build/common.gypi b/src/build/common.gypi index 52d5686e..f3a0e23b 100644 --- a/src/build/common.gypi +++ b/src/build/common.gypi @@ -31,34 +31,13 @@ # since gyp_chromium is automatically forcing its inclusion. { 'variables': { - # .gyp files or targets should set chromium_code to 1 if they build - # Chromium-specific code, as opposed to external code. This variable is - # used to control such things as the set of warnings to enable, and - # whether warnings are treated as errors. - 'chromium_code%': 0, - # Variables expected to be overriden on the GYP command line (-D) or by # ~/.gyp/include.gypi. # Putting a variables dict inside another variables dict looks kind of - # weird. This is done so that "branding" and "buildtype" are defined as - # variables within the outer variables dict here. This is necessary - # to get these variables defined for the conditions within this variables - # dict that operate on these variables. + # weird. This is necessary to get these variables defined for the conditions + # within this variables dict that operate on these variables. 'variables': { - # Override branding to select the desired branding flavor. - 'branding%': 'Chromium', - - # Override buildtype to select the desired build flavor. - # Dev - everyday build for development/testing - # Official - release build (generally implies additional processing) - # TODO(mmoss) Once 'buildtype' is fully supported (e.g. Windows gyp - # conversion is done), some of the things which are now controlled by - # 'branding', such as symbol generation, will need to be refactored based - # on 'buildtype' (i.e. we don't care about saving symbols for non-Official - # builds). - 'buildtype%': 'Dev', - 'variables': { # Compute the architecture that we're building on. 'conditions': [ @@ -72,49 +51,19 @@ 'host_arch%': 'ia32', }], ], - - # Whether we're building a ChromeOS build. We set the initial - # value at this level of nesting so it's available for the - # toolkit_views test below. - 'chromeos%': '0', }, - # Set default value of toolkit_views on for Windows and Chrome OS. - # We set it at this level of nesting so the value is available for - # other conditionals below. - 'conditions': [ - ['OS=="win" or chromeos==1', { - 'toolkit_views%': 1, - }, { - 'toolkit_views%': 0, - }], - ], - 'host_arch%': '<(host_arch)', # Default architecture we're building for is the architecture we're # building on. 'target_arch%': '<(host_arch)', - # We do want to build Chromium with Breakpad support in certain - # situations. I.e. for Chrome bot. - 'linux_chromium_breakpad%': 0, - # And if we want to dump symbols. - 'linux_chromium_dump_symbols%': 0, - # Also see linux_strip_binary below. - - # Copy conditionally-set chromeos variable out one scope. - 'chromeos%': '<(chromeos)', - # This variable tells WebCore.gyp and JavaScriptCore.gyp whether they are # are built under a chromium full build (1) or a webkit.org chromium # build (0). 'inside_chromium_build%': 1, - # Set to 1 to enable fast builds. It disables debug info for fastest - # compilation. - 'fastbuild%': 0, - # Set to 1 compile with -fPIC cflag on linux. This is a must for shared # libraries on linux x86-64 and arm. 'linux_fpic%': 0, @@ -135,16 +84,9 @@ 'disable_sse2%': 0, }, - # Define branding and buildtype on the basis of their settings within the - # variables sub-dict above, unless overridden. - 'branding%': '<(branding)', - 'buildtype%': '<(buildtype)', 'target_arch%': '<(target_arch)', 'host_arch%': '<(host_arch)', - 'toolkit_views%': '<(toolkit_views)', - 'chromeos%': '<(chromeos)', 'inside_chromium_build%': '<(inside_chromium_build)', - 'fastbuild%': '<(fastbuild)', 'linux_fpic%': '<(linux_fpic)', 'python_ver%': '<(python_ver)', 'arm_version%': '<(arm_version)', @@ -267,55 +209,14 @@ 'gcc_version%': '